From patchwork Thu Oct 12 18:30:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 23506 Received: (qmail 106164 invoked by alias); 12 Oct 2017 18:30:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 105816 invoked by uid 89); 12 Oct 2017 18:30:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Oct 2017 18:30:48 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 57930780D0 for ; Thu, 12 Oct 2017 18:30:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 57930780D0 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from cascais.localdomain (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 40BEE1836B for ; Thu, 12 Oct 2017 18:30:43 +0000 (UTC) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [pushed] Tighten remote check in gdb.base/argv0-symlink.exp Date: Thu, 12 Oct 2017 19:30:40 +0100 Message-Id: <1507833040-17055-1-git-send-email-palves@redhat.com> Check for gdbserver instead of dejagnu remote. Unlike what the comment says, the test actually fails with target remote + gdbserver (it does pass with extended-remote). The result is: FAIL -> KFAIL with --target_board=native-gdbserver KPASS -> PASS with --target_board=native-extended-gdbserver gdb/testsuite/ChangeLog: 2017-10-12 Pedro Alves Simon Marchi * gdb.base/argv0-symlink.exp: kfail on remote gdbserver, instead of on dejagnu remote boards. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.base/argv0-symlink.exp | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 0fa3afb..e6a4281 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,4 +1,10 @@ 2017-10-12 Pedro Alves + Simon Marchi + + * gdb.base/argv0-symlink.exp: kfail on remote gdbserver, + instead of on dejagnu remote boards. + +2017-10-12 Pedro Alves Simon Marchi * gdb.base/inferior-died.exp: Remove is_remote and isnative diff --git a/gdb/testsuite/gdb.base/argv0-symlink.exp b/gdb/testsuite/gdb.base/argv0-symlink.exp index a1248ed..efac9e0 100644 --- a/gdb/testsuite/gdb.base/argv0-symlink.exp +++ b/gdb/testsuite/gdb.base/argv0-symlink.exp @@ -80,8 +80,9 @@ gdb_test_no_output "set print repeats 10000" gdb_test_no_output "set print elements 10000" if { $has_argv0 } { - # gdbserver does not have this issue. - if ![is_remote target] { + # gdbserver in extended-remote mode does not have this issue. + # Plain remote does, however. + if {[target_info gdb_protocol] != "extended-remote" || ![target_is_gdbserver]} { setup_kfail "*-*-*" gdb/15934 } gdb_test {print argv[0]} "/$dirlink/$filelink\"" $test