From patchwork Tue Oct 10 09:26:28 2017
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Florian Weimer <fweimer@redhat.com>
X-Patchwork-Id: 23422
Received: (qmail 129324 invoked by alias); 10 Oct 2017 09:26:34 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 129304 invoked by uid 89); 10 Oct 2017 09:26:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,
	GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD,
	SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 32EA87EA83
Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com;
	dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com;
	spf=fail smtp.mailfrom=fweimer@redhat.com
Subject: Re: [PATCH] scripts/test-installation.pl: Ignore nss_test* DSOs [BZ
	#21911]
To: Rical Jasan <ricaljasan@pacific.net>
Cc: libc-alpha@sourceware.org
References: <20170810122423.B1965439942E1@oldenburg.str.redhat.com>
	<a49eaf6d-4871-b2a1-0ebf-a5854ce11346@pacific.net>
From: Florian Weimer <fweimer@redhat.com>
Message-ID: <6e277d96-429c-3140-2248-cbc790d2c0c5@redhat.com>
Date: Tue, 10 Oct 2017 11:26:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
	Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <a49eaf6d-4871-b2a1-0ebf-a5854ce11346@pacific.net>

On 10/07/2017 12:55 PM, Rical Jasan wrote:
> On 08/10/2017 05:24 AM, Florian Weimer wrote:
>> 2017-08-10  Florian Weimer  <fweimer@redhat.com>
>>
>> 	[BZ #21911]
>> 	* scripts/test-installation.pl: Ignore nss_test* DSOs.
>>
>> diff --git a/scripts/test-installation.pl b/scripts/test-installation.pl
>> index c5b9fdefd2..4b0e9f3c4a 100755
>> --- a/scripts/test-installation.pl
>> +++ b/scripts/test-installation.pl
>> @@ -124,7 +124,7 @@ while (<SOVERSIONS>) {
>>       next if ($build_mathvec == 0 && $name eq "mvec");
>>       if ($name ne "nss_ldap" && $name ne "db1"
>>   	&& !($name =~/^nss1_/) && $name ne "thread_db"
>> -	&& $name ne "nss_test1" && $name ne "libgcc_s") {
>> +	&& $name !~ /^nss_test\d+/ && $name ne "libgcc_s") {
>>         $link_libs .= " -l$name";
>>         $versions{$name} = $version;
>>       }
> 
> An anchor would more closely preserve the test (i.e.,
> "/^nss_test\d+$/"), and avoid matches like "nss_test9 garb @ g3".

Good point.  Updated patch attached.

Thanks,
Florian


2017-10-10  Florian Weimer  <fweimer@redhat.com>

	[BZ #21911]
	* scripts/test-installation.pl: Ignore nss_test* DSOs.

diff --git a/scripts/test-installation.pl b/scripts/test-installation.pl
index 45c666b0a2..74d25e1c8d 100755
--- a/scripts/test-installation.pl
+++ b/scripts/test-installation.pl
@@ -123,7 +123,7 @@ while (<SOVERSIONS>) {
     next if ($build_mathvec == 0 && $name eq "mvec");
     if ($name ne "nss_ldap" && $name ne "db1"
 	&& $name ne "thread_db"
-	&& $name ne "nss_test1" && $name ne "libgcc_s") {
+	&& $name !~ /^nss_test\d+$/ && $name ne "libgcc_s") {
       $link_libs .= " -l$name";
       $versions{$name} = $version;
     }