Patchwork Don't try building gdb against guile-2.2

login
register
mail settings
Submitter Simon Marchi
Date Oct. 8, 2017, 4:47 p.m.
Message ID <20171008164703.12953-1-simon.marchi@polymtl.ca>
Download mbox | patch
Permalink /patch/23391/
State New
Headers show

Comments

Simon Marchi - Oct. 8, 2017, 4:47 p.m.
GDB currently doesn't build with Guile 2.2 (see PR 21104).  If one has
both Guile 2.2 and 2.0 installed, GDB will pick up Guile 2.2 first and
fail building.  Until somebody does the work of adapting the GDB code to
Guile 2.2, we should not try using it.  This patch therefore removes it
from configure.

gdb/ChangeLog:

	* configure.ac (try_guile_versions): Remove guile-2.2.
	* configure: Regenerate.
---
 gdb/configure    | 4 ++--
 gdb/configure.ac | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Eli Zaretskii - Oct. 8, 2017, 5:13 p.m.
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Cc: Simon Marchi <simon.marchi@polymtl.ca>
> Date: Sun,  8 Oct 2017 12:47:03 -0400
> 
> GDB currently doesn't build with Guile 2.2 (see PR 21104).  If one has
> both Guile 2.2 and 2.0 installed, GDB will pick up Guile 2.2 first and
> fail building.  Until somebody does the work of adapting the GDB code to
> Guile 2.2, we should not try using it.  This patch therefore removes it
> from configure.
> 
> gdb/ChangeLog:
> 
> 	* configure.ac (try_guile_versions): Remove guile-2.2.
> 	* configure: Regenerate.

Should we perhaps have a configure-time option, by default off, to use
Guile 2.2?  Otherwise, how would that "somebody" work on fixing this
problem, if they cannot even try building with Guile 2.2?

Thanks.
Simon Marchi - Oct. 8, 2017, 5:20 p.m.
On 2017-10-08 13:13, Eli Zaretskii wrote:
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>> Cc: Simon Marchi <simon.marchi@polymtl.ca>
>> Date: Sun,  8 Oct 2017 12:47:03 -0400
>> 
>> GDB currently doesn't build with Guile 2.2 (see PR 21104).  If one has
>> both Guile 2.2 and 2.0 installed, GDB will pick up Guile 2.2 first and
>> fail building.  Until somebody does the work of adapting the GDB code 
>> to
>> Guile 2.2, we should not try using it.  This patch therefore removes 
>> it
>> from configure.
>> 
>> gdb/ChangeLog:
>> 
>> 	* configure.ac (try_guile_versions): Remove guile-2.2.
>> 	* configure: Regenerate.
> 
> Should we perhaps have a configure-time option, by default off, to use
> Guile 2.2?  Otherwise, how would that "somebody" work on fixing this
> problem, if they cannot even try building with Guile 2.2?
> 
> Thanks.

They can pass --with-guile=guile-2.2.  try_guile_versions, AFAIU, 
contains the version to try by default if the version to use is not 
explicitly passed (--with-guile or --with-guile=yes).

Simon
Eli Zaretskii - Oct. 8, 2017, 5:42 p.m.
> Date: Sun, 08 Oct 2017 13:20:28 -0400
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Cc: gdb-patches@sourceware.org
> 
> > Should we perhaps have a configure-time option, by default off, to use
> > Guile 2.2?  Otherwise, how would that "somebody" work on fixing this
> > problem, if they cannot even try building with Guile 2.2?
> > 
> > Thanks.
> 
> They can pass --with-guile=guile-2.2.  try_guile_versions, AFAIU, 
> contains the version to try by default if the version to use is not 
> explicitly passed (--with-guile or --with-guile=yes).

Ah, okay.  That's good enough, I think.

Patch

diff --git a/gdb/configure b/gdb/configure
index 4d473cc934..6b445e4f67 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -5950,7 +5950,7 @@  DEPDIR="${am__leading_dot}deps"
 ac_config_commands="$ac_config_commands depdir"
 
 
-# Create sub-directories for objects and depedencies.
+# Create sub-directories for objects and dependencies.
 CONFIG_SRC_SUBDIR="arch"
 
 
@@ -10313,7 +10313,7 @@  fi
 
 
 
-try_guile_versions="guile-2.2 guile-2.0"
+try_guile_versions="guile-2.0"
 have_libguile=no
 case "${with_guile}" in
 no)
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 4d8d6c7e76..4e64c80f62 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1138,7 +1138,7 @@  AC_MSG_RESULT([$with_guile])
 dnl We check guile with pkg-config.
 AC_PATH_PROG(pkg_config_prog_path, pkg-config, missing)
 
-try_guile_versions="guile-2.2 guile-2.0"
+try_guile_versions="guile-2.0"
 have_libguile=no
 case "${with_guile}" in
 no)