Patchwork Flash memory size not aligned to address

login
register
mail settings
Submitter Mark Rages
Date Oct. 5, 2017, 9:49 p.m.
Message ID <CAASrBQnaCto4VSC5e0A9_NCfJQaxVTXpdt6f_bpEyoOs5_6Bnw@mail.gmail.com>
Download mbox | patch
Permalink /patch/23365/
State New
Headers show

Comments

Mark Rages - Oct. 5, 2017, 9:49 p.m.
The Nordic nRF52 memory map, reported from black magic probe:

Num Enb Low Addr High Addr Attrs
0 y 0x00000000 0x00080000 flash blocksize 0x1000 nocache
1 y 0x10001000 0x10001210 flash blocksize 0x210 nocache
2 y 0x20000000 0x20010000 rw nocache

The region at 0x10001000 is "UICR" and it is a section of flash that is
erased all at once.

Notice the odd size: 0x210 is the size of the region defined in the
datasheet.

But because the block size was listed as 0x210, gdb was insisting on
issuing two erase commands divisible by 0x210, starting below 0x10001000.

This patch fixes it by doing the alignment computation from the start of
the region, not from address 0:


 /* Given the list of memory requests to be WRITTEN, this function

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d8d5772..d2dc194 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2017-10-05  Mark Rages <markrages@gmail.com>
+
+       * target-memory.c (block_boundaries): Fix for block address not
+       aligned on block size.
+
 2017-10-05  Tristan Gingold  <tgingold@free.fr>

        * MAINTAINERS (Misc): Update my email address.
@@ -6962,7 +6967,7 @@ 

 2017-05-08  Alan Hayward  <alan.hayward@arm.com>

-       * mn10300-linux-tdep.c (am33_supply_gregset_method): Use
+       * mn10300-linux-tdep.c (am33_supply_gregset_method): Use
        regcache->raw_supply_zeroed.

 2017-05-06  Sergio Durigan Junior  <sergiodj@redhat.com>
diff --git a/gdb/target-memory.c b/gdb/target-memory.c
index 1c8faa8..4651200 100644
--- a/gdb/target-memory.c
+++ b/gdb/target-memory.c
@@ -138,14 +138,18 @@  block_boundaries (CORE_ADDR address, CORE_ADDR
*begin, CORE_ADDR *end)
 {
   struct mem_region *region;
   unsigned blocksize;
+  CORE_ADDR address_in_region;

   region = lookup_mem_region (address);
   gdb_assert (region->attrib.mode == MEM_FLASH);
   blocksize = region->attrib.blocksize;
+
+  address_in_region = address - region->lo;
+
   if (begin)
-    *begin = address / blocksize * blocksize;
+    *begin = region->lo + address_in_region / blocksize * blocksize;
   if (end)
-    *end = (address + blocksize - 1) / blocksize * blocksize;
+    *end = region->lo + (address_in_region + blocksize - 1) / blocksize *
blocksize;
 }