Patchwork sim: common: Fix pointer sign warnings

login
register
mail settings
Submitter Stafford Horne
Date Oct. 3, 2017, 3:44 p.m.
Message ID <20171003154437.11329-1-shorne@gmail.com>
Download mbox | patch
Permalink /patch/23299/
State New
Headers show

Comments

Stafford Horne - Oct. 3, 2017, 3:44 p.m.
When compiling we get the following warnings:

  common/cgen-accfp.c: In function ‘fixsfsi’:
  common/cgen-accfp.c:370:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
     sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
                  ^
  common/cgen-accfp.c: In function ‘fixdfsi’:
  common/cgen-accfp.c:381:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
     sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
                  ^
sim/common/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* cgen-accfp.c (fixsfsi): Change res from unsigned32 to signed32.
	(fixdfsi): Change res from unsigned32 to signed32.
---
 sim/common/cgen-accfp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/sim/common/cgen-accfp.c b/sim/common/cgen-accfp.c
index 5d600c6e41..ab3a477bbe 100644
--- a/sim/common/cgen-accfp.c
+++ b/sim/common/cgen-accfp.c
@@ -364,7 +364,7 @@  static SI
 fixsfsi (CGEN_FPU* fpu, int how UNUSED, SF x)
 {
   sim_fpu op1;
-  unsigned32 res;
+  signed32 res;
 
   sim_fpu_32to (&op1, x);
   sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
@@ -375,7 +375,7 @@  static SI
 fixdfsi (CGEN_FPU* fpu, int how UNUSED, DF x)
 {
   sim_fpu op1;
-  unsigned32 res;
+  signed32 res;
 
   sim_fpu_64to (&op1, x);
   sim_fpu_to32i (&res, &op1, sim_fpu_round_near);