Correct shell compatibility issue detected with pkgsrc.
Commit Message
String comparison of in a POSIX bourne shell must be done
with '=', not '=='. For example the NetBSD sh(1) does not
support it.
gdb/ChangeLog
2017-09-05 Kamil Rytarowski <n54@gmx.com>
* config/djgpp/djconfig.sh: Correct shell portability issue
---
gdb/ChangeLog | 4 ++++
gdb/config/djgpp/djconfig.sh | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
Comments
> String comparison of in a POSIX bourne shell must be done
> with '=', not '=='. For example the NetBSD sh(1) does not
> support it.
>
> gdb/ChangeLog
> 2017-09-05 Kamil Rytarowski <n54@gmx.com>
>
> * config/djgpp/djconfig.sh: Correct shell portability issue
Indeed. Looks good, so go ahead and push to master.
I did notice you were missing a period at the end of the sentence
in the ChangeLog entry above, but it's in the diff. Can you fix it
before pushing?
Thanks!
> ---
> gdb/ChangeLog | 4 ++++
> gdb/config/djgpp/djconfig.sh | 2 +-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 6d2eae58bc..a8e1837b6a 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,7 @@
> +2017-09-05 Kamil Rytarowski <n54@gmx.com>
> +
> + * config/djgpp/djconfig.sh: Correct shell portability issue.
> +
> 2017-09-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
>
> * objfiles.c (get_objfile_bfd_data): Remove useless obstack_init
> diff --git a/gdb/config/djgpp/djconfig.sh b/gdb/config/djgpp/djconfig.sh
> index 6c0d8698e8..dbaf8f5d76 100644
> --- a/gdb/config/djgpp/djconfig.sh
> +++ b/gdb/config/djgpp/djconfig.sh
> @@ -92,7 +92,7 @@ TMPFILE="${TMPDIR-.}/cfg.tmp"
>
> # We need to skip the build directory if it is a subdirectory of $srcdir,
> # otherwise we will have an infinite recursion on our hands...
> -if test "`pwd`" == "${srcdir}" ; then
> +if test "`pwd`" = "${srcdir}" ; then
> SKIPDIR=""
> SKIPFILES=""
> else
> --
> 2.14.1
On 06.09.2017 02:17, Joel Brobecker wrote:
>> String comparison of in a POSIX bourne shell must be done
>> with '=', not '=='. For example the NetBSD sh(1) does not
>> support it.
>>
>> gdb/ChangeLog
>> 2017-09-05 Kamil Rytarowski <n54@gmx.com>
>>
>> * config/djgpp/djconfig.sh: Correct shell portability issue
>
> Indeed. Looks good, so go ahead and push to master.
>
> I did notice you were missing a period at the end of the sentence
> in the ChangeLog entry above, but it's in the diff. Can you fix it
> before pushing?
>
> Thanks!
>
I've fixed it locally but I cannot push the patch myself.
$ git push upstream master
fatal: remote error: access denied or repository not exported:
/git/binutils-gdb.git
I have the papers done for GNU binutils, GDB and GCC.
>> ---
>> gdb/ChangeLog | 4 ++++
>> gdb/config/djgpp/djconfig.sh | 2 +-
>> 2 files changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
>> index 6d2eae58bc..a8e1837b6a 100644
>> --- a/gdb/ChangeLog
>> +++ b/gdb/ChangeLog
>> @@ -1,3 +1,7 @@
>> +2017-09-05 Kamil Rytarowski <n54@gmx.com>
>> +
>> + * config/djgpp/djconfig.sh: Correct shell portability issue.
>> +
>> 2017-09-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
>>
>> * objfiles.c (get_objfile_bfd_data): Remove useless obstack_init
>> diff --git a/gdb/config/djgpp/djconfig.sh b/gdb/config/djgpp/djconfig.sh
>> index 6c0d8698e8..dbaf8f5d76 100644
>> --- a/gdb/config/djgpp/djconfig.sh
>> +++ b/gdb/config/djgpp/djconfig.sh
>> @@ -92,7 +92,7 @@ TMPFILE="${TMPDIR-.}/cfg.tmp"
>>
>> # We need to skip the build directory if it is a subdirectory of $srcdir,
>> # otherwise we will have an infinite recursion on our hands...
>> -if test "`pwd`" == "${srcdir}" ; then
>> +if test "`pwd`" = "${srcdir}" ; then
>> SKIPDIR=""
>> SKIPFILES=""
>> else
>> --
>> 2.14.1
>
> I've fixed it locally but I cannot push the patch myself.
>
> $ git push upstream master
> fatal: remote error: access denied or repository not exported:
> /git/binutils-gdb.git
>
> I have the papers done for GNU binutils, GDB and GCC.
Time to give you Write After Approval access.
I'll contact you privately about it.
@@ -1,3 +1,7 @@
+2017-09-05 Kamil Rytarowski <n54@gmx.com>
+
+ * config/djgpp/djconfig.sh: Correct shell portability issue.
+
2017-09-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
* objfiles.c (get_objfile_bfd_data): Remove useless obstack_init
@@ -92,7 +92,7 @@ TMPFILE="${TMPDIR-.}/cfg.tmp"
# We need to skip the build directory if it is a subdirectory of $srcdir,
# otherwise we will have an infinite recursion on our hands...
-if test "`pwd`" == "${srcdir}" ; then
+if test "`pwd`" = "${srcdir}" ; then
SKIPDIR=""
SKIPFILES=""
else