diff mbox

[v2,0/2] Various build fixes for NetBSD

Message ID 20170904200416.GA5610@SDF.ORG
State New, archived
Headers

Commit Message

coypu Sept. 4, 2017, 8:04 p.m. UTC 
  Hi,

I've needed amendments to patch #3, and an additional patch.
The additional patch is needed as kamil had removed sys/user.h in
netbsd.

Thank you.
From 147b605f040889110fc47bf6b9d2b00af7317958 Mon Sep 17 00:00:00 2001
From: coypu <coypu@sdf.org>
Date: Mon, 4 Sep 2017 22:59:17 +0300
Subject: [PATCH 1/2] Use existing configure test to guard inclusion of
 sys/user.h

---
 gdb/bsd-kvm.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

John Baldwin Sept. 4, 2017, 10:18 p.m. UTC | #1 
On Monday, September 04, 2017 08:04:16 PM coypu@sdf.org wrote:
> Hi,
> 
> I've needed amendments to patch #3, and an additional patch.
> The additional patch is needed as kamil had removed sys/user.h in
> netbsd.

To be clear, you now want bsd-kvm.o for NetBSD/amd64?  Previously I had
included this but then removed it as the current amd64-nbsd-nat.c doesn't
include a call to 'bsd_kvm_add_target' with a suitable callback function
to supply registers from a PCB.  Without that callback, the kvm target
won't be able to walk stacks or switch to other threads making it less
useful.

For now I will push the other fixes without bsd-kvm.o for amd64 but I can
add that in as a followup commit easily enough.
diff mbox

Patch

diff --git a/gdb/bsd-kvm.c b/gdb/bsd-kvm.c
index f872fc084..67f7e5113 100644
--- a/gdb/bsd-kvm.c
+++ b/gdb/bsd-kvm.c
@@ -37,7 +37,9 @@ 
 #include "readline/readline.h"
 #include <sys/param.h>
 #include <sys/proc.h>
+#ifdef HAVE_SYS_USER_H
 #include <sys/user.h>
+#endif
 
 #include "bsd-kvm.h"