[14/58] Mark internal gshadow functions with attribute_hidden [BZ #18822]

Message ID 20170901180029.9527-15-hjl.tools@gmail.com
State Committed
Commit 94fd682c9b7c0b1ed95234a491f86b8d529e15c2
Headers

Commit Message

H.J. Lu Sept. 1, 2017, 5:59 p.m. UTC
  Mark internal gshadow functions with attribute_hidden to allow direct
access within libc.so and libc.a without using GOT nor PLT.

	[BZ #18822]
	* include/gshadow.h (__fgetsgent_r): Add attribute_hidden.
	(__sgetsgent_r): Likewise.
---
 include/gshadow.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
  

Comments

H.J. Lu Oct. 1, 2017, 10:02 p.m. UTC | #1
On 9/1/17, H.J. Lu <hjl.tools@gmail.com> wrote:
> Mark internal gshadow functions with attribute_hidden to allow direct
> access within libc.so and libc.a without using GOT nor PLT.
>
> 	[BZ #18822]
> 	* include/gshadow.h (__fgetsgent_r): Add attribute_hidden.
> 	(__sgetsgent_r): Likewise.

Tested with build-many-glibcs.py.  I am checking it in.
  

Patch

diff --git a/include/gshadow.h b/include/gshadow.h
index 532801afd0..aa6a5a693e 100644
--- a/include/gshadow.h
+++ b/include/gshadow.h
@@ -4,9 +4,11 @@ 
 # ifndef _ISOMAC
 
 extern int __fgetsgent_r (FILE *stream, struct sgrp *resbuf, char *buffer,
-			  size_t buflen, struct sgrp **result);
+			  size_t buflen, struct sgrp **result)
+     attribute_hidden;
 extern int __sgetsgent_r (const char *string, struct sgrp *resbuf,
-			  char *buffer, size_t buflen, struct sgrp **result);
+			  char *buffer, size_t buflen, struct sgrp **result)
+     attribute_hidden;
 
 struct parser_data;
 extern int _nss_files_parse_sgent (char *line, struct sgrp *result,