From patchwork Thu Aug 31 16:00:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 22450 Received: (qmail 10959 invoked by alias); 31 Aug 2017 16:02:07 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 10950 invoked by uid 89); 31 Aug 2017 16:02:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=(unknown) X-HELO: NAM02-BL2-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Message-ID: <1504195258.3182.13.camel@cavium.com> Subject: [PATCH][aarch64] Change argument type passed to ifunc resolvers From: Steve Ellcey Reply-To: sellcey@cavium.com To: libc-alpha Cc: Szabolcs Nagy Date: Thu, 31 Aug 2017 09:00:58 -0700 Mime-Version: 1.0 X-ClientProxiedBy: MWHPR21CA0070.namprd21.prod.outlook.com (10.172.93.160) To DM5PR07MB3545.namprd07.prod.outlook.com (10.164.153.143) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31e75ad4-a7c9-41b2-d11a-08d4f0897a27 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR07MB3545; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3545; 3:EBuQrt4mWn7YgTKNAuG3F/V1uUjCXB3FrIKkHaqqWfUFUV+5wymTJ4Hj0cGgsC9GNQ/0rDPTb1LWGRT0gwwy5oVeCnId/kuZMiNXdbXJDUts/YrKwMQ0p1n04jDSxoRsbqEr/SSfmcii/vl9xVP49X1FktsuYtEMWFjPt1kyhuyGPIT2P5y61KW0rWOTgaxPXgBW1pfsUe3rsM3gRr1gfVS3C1ZWkuhEwmQFEW8+hAUUWwQuIGSMNBQGjnTnE2NQ; 25:7YkYViFsSLQAwBbRabqufKTV3D1fQFb2HakcKWrQF57YBiPyNTvNzDL3keqqAARxsy4fTCEWTtgD4j3SKG7JoJa8/0MVA4YystbUevWWV0wvZYcqKe6ROuNRdwlJgkwdUtd7md/Ts4x62zi6d3pfkJFTphFuqNezdxnPXGf+jfP2rfuKp/fpL4inaXrrsh2GS1i3J4OL+27nsmsMJX97iSBISIugCCxiVt76iB5uL78r4SfgcjXo2Xm4sTnYkhWT1x2zmrLcWNNtOj0q1cBZr8RP6ChrEXNgXZBlUjMYi1BLqljB56Dw8ro7SpH1DSjgiNysOFXMd7cu0z0fxqQjmg==; 31:AINimOelkWYQ7Vucd8hej053/nSWFB8ex5sZMALHhQKUj5CMK8eHf7W/1iH9Fkn6AIhbVRxYFXGBRRDE5QoMXfEdENwDq2nlhpssNDq4i2VfvexqzzFf/DM1EebbaJhxDDb0xzHBBw30QCHFnM/xXKDu+AE4Ijlib70puW/m/XLOTL8JST8Cues3dzbnWbu5zBAaGnkaEqWge18Y4R5Lnmf4EjGBo0JGFEvEjeHa9hQ= X-MS-TrafficTypeDiagnostic: DM5PR07MB3545: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3545; 20:1OZAQYaGyU0IOq07TvQ43vwTz7VXlSs4h/YYIbnxp5tpnaS0LqQsd/7bEJ45kU0efbVn7JnGtNHXD/fWos9gD8+8F9MYhPPJEPpmr5RAMSftAEGSXwtcuAgVgcc7HG2McpMvkP6G7voU1MjXq/ZHIFO+h5Asb/EiRj6SzJ1nTHHdvk+CNOaO+7ldPDctS1FYTcQTixKfxSoLv0heeeJKpon5+ssKzo4O0cl4uLaBix2KF+nxaoZvX2Hk6tdIEG4B9uN2gxv/DuitsTclLii2w4DV0rFfthveMvLj9ehrgaCawhqXIz9KeIxeVbIiPhFfdgahYuVFaRvBuGZJV9azZxjYYUlIQdrhxS9DOJLb+AAsvs1OUW39WUlHgXchUijyDw/JQr8MbxZw0x4dipqzHBqrDkDL6oUeEpGBKKjsyGfXL+IG1aZbWKE8V9r4Zbi3fxS4Osy9cIVGZoAQDN7SQEdroTuqu8VMMI8KP8W5aV6VpdPdHj1X6uC5onX+WiG3; 4:81M6U2cCMiIo3LQNHWIbspYIORkSo174dEu+gCojuRovP0M2elD3J7ofGywNdsbLkLCyOz7eWTnGw1U7kMvwxpEFiORcW4pf2Chzw3u86Fm8RYu7yd1J0UVO1KARLVq3NbgVoMg/5UtL+rh9VT/UXvnYAtFw/MT3u4IIW/FWEPLzjue5fI8yTZMYnLRCZDBYndQbYgLDuGS96HO5AfihzDnaxxlnuEN/I38blFdcqK0pj0JmGWj+Glp79QlJGbqd X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR07MB3545; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR07MB3545; X-Forefront-PRVS: 04163EF38A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(377424004)(189002)(199003)(478600001)(3450700001)(42186005)(50986999)(43066003)(101416001)(69596002)(2906002)(6116002)(2870700001)(8936002)(189998001)(50226002)(6666003)(8676002)(81156014)(81166006)(3846002)(105586002)(5660300001)(23676002)(47776003)(110136004)(6506006)(6486002)(4326008)(36756003)(68736007)(106356001)(103116003)(6916009)(7736002)(97736004)(66066001)(305945005)(6512007)(6306002)(25786009)(53936002)(50466002)(966005)(33646002)(72206003)(53416004)(5820100001)(99106002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3545; H:sellcey-dt.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjA3TUIzNTQ1OzIzOkhKTytLWlh2UlNyOGFCWHJqUG5JTkN6OVBu?= =?utf-8?B?M2V3YXVRUTIyampkWkwxWkNLb3BhdkxWZkNvMkhzeERueDBWV0pVT1YxdUxk?= =?utf-8?B?dXZIOHg3TUpUcGlCb0R5STd5Z2srQzlxOWpOd1ZEWEVGY0NiaDVacHpFNVZD?= =?utf-8?B?OXVKaDBYSXU0aWpCdEpYRExheTB2WXNKMWpkZXZLSzdhQWVTaVFSaDlyN0hD?= =?utf-8?B?Q1JnR21tbk5lNmpEVi9OaytBK0tsN2RySEtuM1M0SGpwUWVuS2xmNlZjZ1Zl?= =?utf-8?B?ZTdxNVZEVU9IQ3ZaSUhtU2U0N3ZveFRjZ1dqWTdVY3NKa2o1MzZEQlQ5ZFV1?= =?utf-8?B?bE9rNkZ0R05Dejc2cFFUOUxMd1Uzb0I0d2I0WHlEazZ4Wk93K0JFemJ5ZVlm?= =?utf-8?B?L1IrYmdielp3aHFVaFVFZVFnWlJPblpQTkZOaElTaVhyclpGck5RS3U0cEU5?= =?utf-8?B?VkhoMDE0aCtrVHdFU1dZSkZ5ZWM3RzVKYjNNMjZBenZ0ajBKeGF2YzRlaUZs?= =?utf-8?B?WkxvWTFxRzBUdTFYOFE0OEZ1NXJ3TThTWEJOVHJnckpxVS85NTRVY3ZLSWF1?= =?utf-8?B?MG1DUFcrUXlpQXF3Um1PNzdoTWFuSHZzckgzRnVRck12eklBajBQMkpUZ25y?= =?utf-8?B?NGFRUEpFNGNQZ1AwdGlRY2ZTNjVpdGNTZkVaQ0dIWVFHdk5GM1FTVVZGVFoy?= =?utf-8?B?VTg1Kzh3amtnTmIzNG1iaXRtQkFIUld6Y2VWVEhRaU1yeGhrWXc0K0RHOTUv?= =?utf-8?B?V0Y1Skl1dmZSUk1zbkZSYjFPMlY5T1JpdDZSbTRncXQwSnc5Z3c3ZmZUM0RM?= =?utf-8?B?bVdCRXI3R3g0M01ubEVIbTJRTEpvbjFFa3FaaW9vMlFFRFFnZldqRndLN1Vl?= =?utf-8?B?K3A4YmV2anNsZHhnMEZWUFpnNkZTSW1iay8rOW1wMDQ5b2hvNTJUOStFalRV?= =?utf-8?B?R1FLTFRSL3g0Q3JrdFNEVSt0VG8xejBFUkNYenM4Zm1GbG9Icjc5Skt6TG1L?= =?utf-8?B?bEtxbS83V2IzN0J0Yko4MHlrUERZbTN0Z2RwSXc5UTNERFlIRTFXckUwTStG?= =?utf-8?B?cEtHSVFwY0V6b09UVFRLeFY5WU01MGlyajk1ZjdEVUZRRGZudjFoNFQ4bFpq?= =?utf-8?B?MVJYc1NkK3BZcFRObjl6akZmT2paRXQ2ODdWTFlOOUlNZkFwNHFIWkc0NnFK?= =?utf-8?B?S2s2V2tUdmNubE1FM2MycitJSHg3RCtvVWdJSVl2M2FJRDlYUjN5dVh5d1hk?= =?utf-8?B?d3FRYmpJbTU0MzZ1a0RFMDZrN0JiVENWa3RseXdrdk85WEcwUTl0aEhnbU9L?= =?utf-8?B?V1Vuc1JKZXYrUlBzM281V29FZXhtdEF2VHRkTStqTWJsQ2ljbTk1eWkzY0lo?= =?utf-8?B?RmJHZnFMSzhwNUtiR1RMZzdmaVNZcmdQd295SjBIVEVyK2N1VXRMRzBQejcv?= =?utf-8?B?TU1id1BuZjkydCtSdk5mdmZ4OEhnZ3hrc0JDS1NqWlBzVE5rNkZIZEYrT2NL?= =?utf-8?B?ZDVXejVZNnhEUlZtNEd4Z285VTNpK1YzYUhJMkZ1VWV6S05oNTFtNVVlWUI3?= =?utf-8?Q?1vYiMq9S3c8Is0f/E8omUxR023T7hl+wKLwnafDKaQdI=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3545; 6:vdpat+TO4rCZJBCFs7XKDAHwK7I4QUNvYdVz8mpVad/M17Yo3OlDWKIqAoiRBqD96B2/TJVX7AyCM2IaJMuYdKpXR2LXR4zKsyGJ7+SRBHwyb82QQ4QmKF7iks5vTevB5JVC1F5OTokpqaHgxHFPcxF3/CRiCgriBXLvFVUwcrmKUbV0gEpdRitQpdFtm8PqtrIfJ/U0nrUiBFGC/3xCswB1S3z2/MM1pbDJHdMcPGSpBsfQ6jcqCD+pIT8o4d27wbwvwgaCxUNkZw7+ux5cVUUzQyYSBvTNikGJ79iApBqEcfnpdpeJdSDAfNXO5huAkCzJc3io1toGs9C4C4ruCw==; 5:Y3MWETqtqCgSe2qYAMJFPF6C/BRc9GitIFhMigdxpq+swvtJ0a6gPnYeP0nYjfx9Ej8OQ5zf1uDqly6i8i07rSW0LhXBZOK+itCOTvX3Kgeh+rwpSJJhyOs5Lv/FlFZaCJnHJNnFMoeMPLKsRXHDEw==; 24:10kALHiGFxlza+i5f7xJHPVZKsmm3ZjfivRKWwSwqBVbBdgeY5bumSckyR3B5l2WYn5DqtO8OVfOleZCaChI2PCdQq1Vw1NRWcbtIqjnU3I=; 7:jCZipnMQZ9KeIASSNYLcvJ5xLS/ry3NQEkoNCrTNbfPXfY6cHjdR1srMGSOaMhmeoQjSSReBAfCSPWsK2UIBzhsEMZ/I9RA0WiEAy2YbW6HeAClvgOG12dvKmyB0TF9jOplt93rCv6DONCOpE8fGDCP6nK/K2A8xcvLuDymOaSqiXiJ1LIkOj/SseMGNbnY9v8MNZpdhMZ1/g1j6GRA6CkYlNlCBv/cJqVuLc1i+Z7Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2017 16:01:01.4041 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3545 This is a one line patch split out from: https://sourceware.org/ml/libc-alpha/2017-08/msg01310.html It just changes the type of the argument passed to ifunc resolvers from 'unsigned int long' to 'uint64_t'.  This should make no difference for the existing LP64 ABI but will also work for the new ILP32 ABI.  I would like to check this in before submitting a patch to GCC that uses IFUNCs in libatomic so that the types agree. Tested on aarch64, OK to checkin? Steve Ellcey sellcey@cavium.com 2017-08-31  Steve Ellcey   * sysdeps/aarch64/dl-irel.h: (elf_ifunc_invoke): Change argument type in resolver call. diff --git a/sysdeps/aarch64/dl-irel.h b/sysdeps/aarch64/dl-irel.h index 4a80275..a794c82 100644 --- a/sysdeps/aarch64/dl-irel.h +++ b/sysdeps/aarch64/dl-irel.h @@ -31,7 +31,7 @@ static inline ElfW(Addr)  __attribute ((always_inline))  elf_ifunc_invoke (ElfW(Addr) addr)  { -  return ((ElfW(Addr) (*) (unsigned long int)) (addr)) (GLRO(dl_hwcap)); +  return ((ElfW(Addr) (*) (uint64_t)) (addr)) (GLRO(dl_hwcap));  }    static inline void