From patchwork Tue Aug 22 17:46:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 22313 Received: (qmail 30113 invoked by alias); 22 Aug 2017 17:46:53 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 29733 invoked by uid 89); 22 Aug 2017 17:46:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=one, Hx-languages-length:1380, H*r:sk:NAM02-B, H*r:104.47.38 X-HELO: NAM02-BL2-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Message-ID: <1503423981.28672.31.camel@cavium.com> Subject: [PATCH] aarch64: Fix ipc_perm definition for ILP32 From: Steve Ellcey Reply-To: sellcey@cavium.com To: libc-alpha Date: Tue, 22 Aug 2017 10:46:21 -0700 Mime-Version: 1.0 X-ClientProxiedBy: MWHPR09CA0035.namprd09.prod.outlook.com (10.173.46.149) To MWHPR07MB3551.namprd07.prod.outlook.com (10.164.192.140) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 63d180d6-03c7-44ee-9846-08d4e985b566 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:MWHPR07MB3551; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3551; 3:kFYEP+5iDtpcQ13UFjfkiXu5wmdk8fyIkK8L+iSZOBcvo+bqecZOCB+FIKSA6QrDIzy0rurCEMAnb609CoCeb6XNK9MULr7vIjZPSh3eDdUfz1Zu+GCAlA4s+86Ca+UtL9BTlARFpXLxmzV0x0GFXBFh6taE8jMS60be73szhdxmZLENn8CiLHM/qkxNSSU1GbQPU2Fl9xnTxQNNb4HPI8vnrxXhlDXunCIRUO2dlyFPDysH2Pubdv/wIVPpuzHz; 25:r8U00iazYiljklHOQaiFnRLJpVEIIBhFGw/3GyEGkcx0Kq6sDT4foHOTmokFjGh10gV3nzM8g690SEXNqLCM6s+xaxHmrRYyWSGVXh3sLKgvO89O0CW3plQtaxkF18xBFUsBzkX5CDLjMc5nnuWkMqk3K4qDM36vgISyqNaadKlKQd23ffevULDeejmK+nWj8AssbSek39Ej8Lg9+I6qrQU/GkOOVAfcdM/xaqr0nb56z25Q57MuDa8tD90GKz1ZwYxmgcgO2P7uUnnP18sqEr5JHQNOiIhWzrq20lT7xOybgfPlpiI4lZFEhqZ9g2ZqhUCgLi4VqCxO3JU0Ugi5cw==; 31:SJCDn5io9QaalbmbJ2MxC03DfObxdxsmy7hHfVJJhGgOgSlfDf1jEb0hTOPiFG0iZ8PMInfjULfFCVP46Z2A6yhBouTtVPKxy/Zd9jOYXoZc3MRALHRwfLD4KLmaLwrl7zWbJOpoSaI6jzvZcMdOAwwnLHNL7HtLLoFZCyCA1AKPuG5YPaJ+OsF8pHakc14tgNsB1SmW4BPRyAPd9/NaOuYUHoAEbeG4HhN2DlDskLE= X-MS-TrafficTypeDiagnostic: MWHPR07MB3551: X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3551; 20:5XdQ1R5cpMKMzIsCZJ+y+0hLyI6R47AvctHqItW6MvgfQX9x26dp9Nu3QmnFuPuovBfjFExr94FBzeAW2XF10Qr8XbDzUlrqt72XkOqhe983x4IPDju8vouY3NL1IjqbtGdmfqFNMpXqG3QYGSPRUOPf4hBbDnmjIPHO6Wt9LDKPsQHhcdP9d2BKDFem8fq4cfKaoyjfMBWrk9P2EqnF37KmvRD7On+ijRB9fwmUc0DGNIk3IWbqXYXit3XoSR+7d5mmsULPmI3X7Pft4cQZ4tnPDM8UWjOFnQ3RXOuG76A35QM347cyUyydrOMUIyEZFvVJD8ZBYFqTrML3AyJXkA9lveld99kojy4QlE8q1/lgucIIu4C+hR+vU2H5IkOu/IeJ6Rruye+en3/uyuIS8oErZ1D8kklYtRs0K+lBLjrb6VJpQMoqWeBkoX2KTjib8YUauPUybFY2XfEPuKXP9yfXFaKzwzY9UySetxUQeo9q9fG/ruz5JSJwRoAROiYP; 4:TKtcJe5QT6MNzyWGkRqdgVMiF/ztH6hv35EvOSMK/keh5gNIIy8/UoMBvaq3RjlRbYrFw1U6Uzc7BI8xYvkc3Ta4MNK71TxfXHRjbr8yWNAmvTJr+CFB0Wx0Jp26pLfBQA0UuRQu4+yAngB655Af6qdO0I8yPp28Baj6zlPtQitpvlbt3bULBfxTIB50ybGMmBJKzLeYufki5LproholB1e52uHNvTFYgPY8g0sfyldALmcbhSXa5wBupPzTdydV X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR07MB3551; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR07MB3551; X-Forefront-PRVS: 04073E895A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(377424004)(189002)(199003)(23676002)(81156014)(2870700001)(69596002)(2906002)(43066003)(101416001)(478600001)(72206003)(7350300001)(189998001)(47776003)(66066001)(50986999)(25786009)(103116003)(5660300001)(97736004)(6486002)(68736007)(3450700001)(110136004)(6506006)(8676002)(6512007)(6666003)(33646002)(53416004)(6116002)(50226002)(106356001)(105586002)(50466002)(3846002)(305945005)(42186005)(81166006)(7736002)(5820100001)(6916009)(36756003)(53936002)(99106002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3551; H:sellcey-dt.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjA3TUIzNTUxOzIzOndJa1YwZ2hKYXFaOW51WVhpVEhTWWVHb0Iw?= =?utf-8?B?eU9PMWtCQkY1VDY2TlZSYStVR3pZMWpadW1aaitCa29aUlhwbzZ5SGNHNy96?= =?utf-8?B?WE9WRDdYWXllMTBrd2FvejNUWlA1QkJjRGJWYW5wZ1c4NEJYeVVHMllPZjVE?= =?utf-8?B?c2VhUjNuZG02NkZjdXhWc1NzSjVodmhpcGVPMGUxZmpzTnNkQmxzWk1QVUJX?= =?utf-8?B?TldEN3ZrOTRhZkROZUdGTjI2VG5KMkdDOEJpaVRGWExiY2JPa1NqbjNNa2ha?= =?utf-8?B?R2F3VXhJNDl5QU1YOFRuWnJwbUszR0wzelJwUnpiTE5ZUzY4aWNOYmJ0ZkRz?= =?utf-8?B?S1FvMFozZlB2ejMzYWg3RG45Q0JIYjZ3V21OUzNXa1NuK1FvY0pSVTlKOXdL?= =?utf-8?B?all4QmVNZ3YrSHdkUUFXT0tLQ0NFdVJqc3BtSm5GTjI0dEtYN20vZjMxYVhZ?= =?utf-8?B?c25tL210a3AvMjcrZWFLVVJSRnIxV3hrMVpYMjJoVXdXVFFCYzUxbk45alpm?= =?utf-8?B?R1EwWGZJMk5xQ1hYYUxoMkkrVERhbnVaKzJaN2NmditWMWVMejNMR2lqRElm?= =?utf-8?B?anBuZjROS1c4OUV0bC9xbU1nZ3htRmI4OVJHK2ZJc3BVQkd3OVVqZExhQWti?= =?utf-8?B?WFVXYnlvalFLa3hoMlc4bTFxbzBqR3RZcE44dFJXR2FYZEo5UHRFSGg2MHNV?= =?utf-8?B?eGJhdHoyM1VpSEk1WUxKb2dFMHVseW9hbDVUTTc0YlA4VGxxUGlUZHppbWxx?= =?utf-8?B?bDIrUVlmUVliN2dHUk9Pcm1KQ3BvSm5oNEV0cGF1aVUrKzFpaWJ0NzRZYmxW?= =?utf-8?B?T3gvclJ3SUI0REVDaFprZ1Y1ZHNvUFdOc1EwczV4dXVtN29mTysvOHV6TzJB?= =?utf-8?B?eXhaai93eVRGeXBBcDJhTlcyYzFqcURwc1A1dW0wV01QUlZZWi9NcHJtcUhW?= =?utf-8?B?a3BOYU1POFJIb1hScWVLSlFUVGJIQklOd0VQdjB3OTZwcExoVmtSR1pXRmVz?= =?utf-8?B?czdvSDhBWDc5b29Hd0JzVmhQQ2I4R0hUcFJuZkxnNTAzeXJNYWtTQjdiaURM?= =?utf-8?B?OXZzSjRsekh6NXZ4WjdMdVp1ejZzcGg5KzVGcnlqUUpUUUlVdEI1M2RVd3Ry?= =?utf-8?B?WDl1SGsyNGdWMVZaemRkaUliZzF2WFk1ZWJqZXgvNGNMY2s4MnM4UG1WL0gv?= =?utf-8?B?ZHNWS2trUzJaSkxGSXhya0E5S0JmUm9LU0l3YVA3MnFlNFQ4a1JqMW5wMitC?= =?utf-8?B?MS9wRU8vZ2JuZ3dCM1lya3AzVENBeTlJSlJMeHBuZXdMUHhLeGV6NHQ3STdQ?= =?utf-8?B?K2R2N1owMkFSeWY0c0FDcUFTVHJLVTMvSVpsamF6UUlTY0RPbXo1QVF3N0J1?= =?utf-8?B?T05KOUhhL0xKNEFUT0lZb3M4aHUvd0Z6RWVNT3hETDdjN3dSdSsxam81bjlv?= =?utf-8?B?L0d6MjBrMEZ0TktIdk8za2RacmRQQkZ1WTdESEdINE1yYjRZWGdFcXNZZkl0?= =?utf-8?B?a3ZNbktuYnhaTGcreG14NU4xYmx0UW1nTTJqbm1ZeVhoUEZ2amVFTzZ3YlEy?= =?utf-8?Q?a/+jfsto7xN27cukavY70yqc1kZ7hmVuqC8TNfMKeXgA=3D?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3551; 6:yp6Gjh8VND3ekmweNcRXkNYMeGsQEhx+sap61xfHHrXaAHkOr102S/1uuWK+tdoHg2ivBlPLiEWMLUnZ02hE9C7UU26TGTkgn5UaZO7YquYkZEfzxz320vP28eQUwwB9wos8rG5E1RbQ6Rd4Jz51JB9LdTo2umfaJIdyFrKh7h6OBBLikYf3A+8THOle9K6oI19t8x8Wb1OZKMUaoDpiTCdn6v5jwgnntadi5BAYXwlTY9TWx1XLqP5QGbe6SzYEsQ0PkoDZg1e4EULDoPq9eC5RfaABIoWlESD0B9blnkAFsSH0SYjSM79CaHcHjcDMyXaq+5cWfNTsVeFwwEgaqw==; 5:CK21lyVlNf/zIMUY6nDGTWGe2EQ8vCaga/KEPlzztS9Gk08ZfDt+8QSaiSgn5L4FLnwAMdHhNhDKAlUCSMjcAfrUh6DZcU20AEpddzGPMiRleb3qIKgHjr4ebXuuTVBz3CFFUU+Lq+V/mGQ03Vl9Gw==; 24:GBmliyuh8dPhVBJAw7rkVGin7uVNIMaiaYDXg88LbZz/8OnMa2zd2LSVczUderVakY8bYdjDyGmO+zpYwgLI4wjlK7AVrpiQYAGXlRaG8lA=; 7:B2yze7X7F49qCrZ2PVk9xIYJN3kJumTWhLPMvj9js4jrdp0UZEP3criOXfq8yUESPcq+KsWcB/a73131AiUtU5bwuc4v0FZMOcLl0MjTp/tx7Z9+sZVPc5LVaFBHbUE5IE72GEcoBNnp4X49q2wTS25sobkaX5KKMnqeOjrevWV9NQljf9mxiURQkgxcza4hlrB1iKqDbFtBtMxfF/TZvOyrCFiuwuUy6xGvzqCjC5Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2017 17:46:24.8310 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3551 Here is another aarch64 ILP32 patch.  The mode field in ipc_perm in ILP32 should be a 16 bit field, not a 32 bit one.  This was out-of-sync with what the kernel had.  This was causing sysvipc/test-sysvsem to fail in ILP32 mode. This change is only needed for ILP32 so it doesn't need to go in until we add that ABI but I am sending out for review and comments. 2017-08-22  Yury Norov       Steve Ellcey   * sysdeps/unix/sysv/linux/aarch64/bits/ipc.h (ipc_perm): Ifdef and pad the mode field for ILP32. diff --git a/sysdeps/unix/sysv/linux/aarch64/bits/ipc.h b/sysdeps/unix/sysv/linu x/aarch64/bits/ipc.h index cd1f06e..cd05b74 100644 --- a/sysdeps/unix/sysv/linux/aarch64/bits/ipc.h +++ b/sysdeps/unix/sysv/linux/aarch64/bits/ipc.h @@ -46,7 +46,12 @@ struct ipc_perm      __gid_t gid; /* Owner's group ID.  */      __uid_t cuid; /* Creator's user ID.  */      __gid_t cgid; /* Creator's group ID.  */ +#ifdef __LP64      unsigned int mode; /* Read/write permission.  */ +#else +    unsigned short int mode; /* Read/write permission.  */ +    unsigned short int __pad0; +#endif      unsigned short int __seq; /* Sequence number.  */      unsigned short int __pad1;      __syscall_ulong_t __glibc_reserved1;