[2/3] x86: Mark VDSO_SYMBOL(getcpu) with attribute_hidden [BZ #18822]

Message ID 20170818162823.GB21741@gmail.com
State Committed
Commit 483d70687919ab42c3c6498a99e51b210e5f45ca
Headers

Commit Message

Lu, Hongjiu Aug. 18, 2017, 4:28 p.m. UTC
  VDSO_SYMBOL(getcpu) is defined as hidden in Linux/x86_64 init-first.c
and unused for Linux/i386.

OK for master?

H.J.
---
	[BZ #18822]
	* sysdeps/unix/sysv/linux/x86/libc-vdso.h (VDSO_SYMBOL(getcpu)):
	Add attribute_hidden.
---
 sysdeps/unix/sysv/linux/x86/libc-vdso.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Florian Weimer Aug. 21, 2017, 12:38 p.m. UTC | #1
On 08/18/2017 06:28 PM, H.J. Lu wrote:
> 	* sysdeps/unix/sysv/linux/x86/libc-vdso.h (VDSO_SYMBOL(getcpu)):
> 	Add attribute_hidden.

Looks okay.

Florian
  

Patch

diff --git a/sysdeps/unix/sysv/linux/x86/libc-vdso.h b/sysdeps/unix/sysv/linux/x86/libc-vdso.h
index 6cc3285461..89c70b4e42 100644
--- a/sysdeps/unix/sysv/linux/x86/libc-vdso.h
+++ b/sysdeps/unix/sysv/linux/x86/libc-vdso.h
@@ -29,7 +29,8 @@ 
 extern long int (*VDSO_SYMBOL(clock_gettime)) (clockid_t, struct timespec *)
   attribute_hidden;
 
-extern long int (*VDSO_SYMBOL(getcpu)) (unsigned *, unsigned *, void *);
+extern long int (*VDSO_SYMBOL(getcpu)) (unsigned *, unsigned *, void *)
+  attribute_hidden;
 
 #endif