[1/1] Fix abmon for bem_ZM

Message ID 1502877838-17067-1-git-send-email-akhilesh.k@samsung.com
State Committed
Delegated to: Mike Fabian
Headers

Commit Message

Akhilesh Kumar Aug. 16, 2017, 10:03 a.m. UTC
  Names of Months and Days for Bemba (Zambia)
Ref is taken form
http://scriptsource.org/cms/scripts/page.php?item_id=entry_detail&uid=czeauxc7tq

[BZ #21960]
	*locales/bem_ZM :  Fix months abb names
---
 localedata/locales/bem_ZM |   26 +++++++++++++-------------
 1 files changed, 13 insertions(+), 13 deletions(-)
  

Comments

Mike FABIAN Aug. 17, 2017, 8:20 a.m. UTC | #1
Akhilesh Kumar <akhilesh.k@samsung.com> wrote:

> Names of Months and Days for Bemba (Zambia)
> Ref is taken form
> http://scriptsource.org/cms/scripts/page.php?item_id=entry_detail&uid=czeauxc7tq
>
> [BZ #21960]
> 	*locales/bem_ZM :  Fix months abb names
> ---
>  localedata/locales/bem_ZM |   26 +++++++++++++-------------
>  1 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/localedata/locales/bem_ZM b/localedata/locales/bem_ZM
> index a09d53e..e02856e 100644
> --- a/localedata/locales/bem_ZM
> +++ b/localedata/locales/bem_ZM
> @@ -62,19 +62,19 @@ mon  "<U004A><U0061><U006E><U0075><U0061><U0072><U0069>";/
>       "<U004F><U006B><U0074><U006F><U0062><U0061>";/
>       "<U004E><U006F><U0076><U0065><U006D><U0062><U0061>";/
>       "<U0044><U0069><U0073><U0065><U006D><U0062><U0061>"
> -% Jan, Feb, Mar, Apr, May, Jun, July, Aug, Sep, Oct, Nov, Dec
> -abmon  "<U004A><U0061><U006E>";/
> -       "<U0046><U0065><U0062>";/
> -       "<U004D><U0061><U0072>";/
> -       "<U0041><U0070><U0072>";/
> -       "<U004D><U0061><U0079>";/
> -       "<U004A><U0075><U006E>";/
> -       "<U004A><U0075><U006C><U0079>";/
> -       "<U0041><U0075><U0067>";/
> -       "<U0053><U0065><U0070>";/
> -       "<U004F><U0063><U0074>";/
> -       "<U004E><U006F><U0076>";/
> -       "<U0044><U0065><U0063>"
> +% http://scriptsource.org/cms/scripts/page.php?item_id=entry_detail&uid=czeauxc7tq

This link gives CLDR as the source, below the month and day names the
page says:

    Source	 Common Locale Data Repository (CLDR)
    Copyright	© 1991-2011 Unicode, Inc.
    License	Restricted content - see terms below
    All rights reserved. Distributed under the Terms of Use at  www.unicode.org/copyright.html.

> +abmon  "Jan";/
> +       "Feb";/
> +       "Mac";/
> +       "Epr";/
> +       "Mei";/
> +       "Jun";/
> +       "Jul";/
> +       "Oga";/
> +       "Sep";/
> +       "Okt";/
> +       "Nov";/
> +       "Dis"

So this is OK, I checked again that it agrees with CLDR.

But I think I’ll remove your reference to scriptsource.org because
that is just an indirect reference to CLDR.

>  % Pa Mulungu, Palichimo, Palichibuli, Palichitatu, Palichine, Palichisano, Pachibelushi
>  day  "<U0050><U0061><U0020><U004D><U0075><U006C><U0075><U006E><U0067><U0075>";/
>       "<U0050><U0061><U006C><U0069><U0063><U0068><U0069><U006D><U006F>";/
  
Mike FABIAN Aug. 17, 2017, 9:08 a.m. UTC | #2
Mike FABIAN <mfabian@redhat.com> wrote:

> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>
>> Names of Months and Days for Bemba (Zambia)
>> Ref is taken form
>> http://scriptsource.org/cms/scripts/page.php?item_id=entry_detail&uid=czeauxc7tq
>>
>> [BZ #21960]
>> 	*locales/bem_ZM :  Fix months abb names
>> ---
>>  localedata/locales/bem_ZM |   26 +++++++++++++-------------
>>  1 files changed, 13 insertions(+), 13 deletions(-)
>>
>> diff --git a/localedata/locales/bem_ZM b/localedata/locales/bem_ZM
>> index a09d53e..e02856e 100644
>> --- a/localedata/locales/bem_ZM
>> +++ b/localedata/locales/bem_ZM
>> @@ -62,19 +62,19 @@ mon  "<U004A><U0061><U006E><U0075><U0061><U0072><U0069>";/
>>       "<U004F><U006B><U0074><U006F><U0062><U0061>";/
>>       "<U004E><U006F><U0076><U0065><U006D><U0062><U0061>";/
>>       "<U0044><U0069><U0073><U0065><U006D><U0062><U0061>"
>> -% Jan, Feb, Mar, Apr, May, Jun, July, Aug, Sep, Oct, Nov, Dec
>> -abmon  "<U004A><U0061><U006E>";/
>> -       "<U0046><U0065><U0062>";/
>> -       "<U004D><U0061><U0072>";/
>> -       "<U0041><U0070><U0072>";/
>> -       "<U004D><U0061><U0079>";/
>> -       "<U004A><U0075><U006E>";/
>> -       "<U004A><U0075><U006C><U0079>";/
>> -       "<U0041><U0075><U0067>";/
>> -       "<U0053><U0065><U0070>";/
>> -       "<U004F><U0063><U0074>";/
>> -       "<U004E><U006F><U0076>";/
>> -       "<U0044><U0065><U0063>"
>> +% http://scriptsource.org/cms/scripts/page.php?item_id=entry_detail&uid=czeauxc7tq
>
> This link gives CLDR as the source, below the month and day names the
> page says:
>
>     Source	 Common Locale Data Repository (CLDR)
>     Copyright	© 1991-2011 Unicode, Inc.
>     License	Restricted content - see terms below
>     All rights reserved. Distributed under the Terms of Use at
> www.unicode.org/copyright.html.
>
>> +abmon  "Jan";/
>> +       "Feb";/
>> +       "Mac";/
>> +       "Epr";/
>> +       "Mei";/
>> +       "Jun";/
>> +       "Jul";/
>> +       "Oga";/
>> +       "Sep";/
>> +       "Okt";/
>> +       "Nov";/
>> +       "Dis"
>
> So this is OK, I checked again that it agrees with CLDR.
>
> But I think I’ll remove your reference to scriptsource.org because
> that is just an indirect reference to CLDR.
>
>>  % Pa Mulungu, Palichimo, Palichibuli, Palichitatu, Palichine, Palichisano, Pachibelushi
>>  day  "<U0050><U0061><U0020><U004D><U0075><U006C><U0075><U006E><U0067><U0075>";/
>>       "<U0050><U0061><U006C><U0069><U0063><U0068><U0069><U006D><U006F>";/

committed.
  
Akhilesh Kumar Aug. 23, 2017, 4:45 a.m. UTC | #3
> >  DEFINE_LANGUAGE_CODE ("Marshallese", mh, mah, mah)
> >  DEFINE_LANGUAGE_CODE3 ("Marwari", mwr, mwr)
> >  DEFINE_LANGUAGE_CODE3 ("Masai", mas, mas)
>> +DEFINE_LANGUAGE_CODE3 ("Mauritius", mfe, mfe)
> 
> “Mauritius” is the name of the country.

> The name of the language in English should be “Mauritian Creole” or

> “Morisyen”.

  Changes done 
> >  DEFINE_LANGUAGE_CODE3 ("Mayan languages", myn, myn)

>>  DEFINE_LANGUAGE_CODE3 ("Meadow Mari", mhr, mhr)

> >  DEFINE_LANGUAGE_CODE3 ("Mende", men, men)

> > diff --git a/localedata/SUPPORTED b/localedata/SUPPORTED

> > index 197917b..e8f4764 100644

> > --- a/localedata/SUPPORTED

> > +++ b/localedata/SUPPORTED

> > @@ -311,6 +311,7 @@ lzh_TW/UTF-8 \

> >  mag_IN/UTF-8 \

> 

> > +       "lin";/

> > +       "mar";/

>> +       "mer";/

> > +	"ze ";/

> > +	"van";/

> > +	"sam"

> 

> Could you use the whitespace in a consistant way instead of a mixture

> of tabs and spaces?

Changes Done 
> > +%

> > +% Full weekday names

> > +day     "dimans";/

> > +        "lindi";/

> > +        "mardi";/

> > +        "merkredi";/

> > +        "zedi";/

> > +        "vandredi";/

> > +        "samdi"

> > +        "desam"

> > +%

> > +d_t_fmt     "<U0025><U0061><U0020><U0025><U0064><U0020><U0025><U0062><U0020><U0025><U0059><U0020><U0025><U0054><U0020><U0025><U005A>"

>> +d_fmt       "<U0025><U0064><U002F><U0025><U006D><U002F><U0025><U0079>"

> > +t_fmt       "<U0025><U0054>"

> > +am_pm       "AM";"PM"

> > +t_fmt_ampm  "<U0025><U006C><U003A><U0025><U004D><U003A><U0025><U0053><U0020><U0025><U0050><U0020><U0025><U005A>"

> > +date_fmt    "<U0025><U0061><U0020><U0025><U0065><U0020><U0025><U0062>/

> > +<U0020><U0025><U0048><U003A><U0025><U004D><U003A><U0025><U0053><U0020>/

> > +<U0025><U005A><U0020><U0025><U0059>"

>> +END LC_TIME

> 

> These are all ASCII, so you could write the text directly here as well

> instead of the code points.

Done  
> > +% http://wikitravel.org/en/User:LiangHH/Mauritian_Creole_phrasebook

> > +LC_MESSAGES

> > +yesexpr "<U005E>[+1yY]"

> > 

> > <U005E> could be written directly, i.e.

> 

>yesexpr "^[+1yY]

> 

> > +noexpr  "[-0nN]"

> 

> Why is the ^ missing here?

 Done  
> > +yesstr  "Yes"

>> +nostr   "No"

> > +END LC_MESSAGES

> > +int_curr_symbol     "MUR "

>> +currency_symbol     "Rs"

> 

> According to the Wikipedia page you quote, this should be “₨”, not “Rs”.

Agree
> > +mon_decimal_point   "."

> > +mon_thousands_sep   ","

> 

>According to mfe.xml in CLDR, U+00A0 NO-BREAK SPACE is used as a

> thousands separator.  So we should not use “,” but  U+202F NARROW

> NO-BREAK SPACE (We consistently use the narrow version in thousands_sep

> and mon_thousands_sep in glibc currently).

Agree  
> > +mon_grouping        3;3

> > +positive_sign       ""

> > +negative_sign       "-"

> > +int_frac_digits     2

> > +frac_digits         2

> > +p_cs_precedes       1

> > +int_p_sep_by_space  1

> > +p_sep_by_space      1

>> +n_cs_precedes       1

> > +int_n_sep_by_space  1

> > +n_sep_by_space      1

> > +p_sign_posn         1

> > +n_sign_posn         1

> > +%

> > +END LC_MONETARY

>> +

> > +LC_NUMERIC

> > +decimal_point          "."

> > +thousands_sep          ","

> 

> According to mfe.xml in CLDR, U+00A0 NO-BREAK SPACE is used as a

> thousands separator.  So we should not use “,” but  U+202F NARROW

> NO-BREAK SPACE (We consistently use the narrow version in thousands_sep

> and mon_thousands_sep in glibc currently).

Changes Done  
> > +grouping               3

> > +END LC_NUMERIC

> > +

>> +LC_PAPER

> > +copy "i18n"

> > +END LC_PAPER

> > +

> > +LC_TELEPHONE

> > +% https://www.howtocallabroad.com/mauritius/

> > +tel_int_fmt "+%c %l"

>> +% 00 Africa: all countries except Kenya, Nigeria, Tanzania and Uganda

> > +int_select     "00"

> > +int_prefix     "230"

> > +END LC_TELEPHONE

> > +

> > +LC_MEASUREMENT

> > +copy "i18n"

> > +END LC_MEASUREMENT

> > +

> > +

> > +

> > +LC_NAME

> > +name_fmt    "<U0025><U0064><U0025><U0074><U0025><U0067><U0025><U0074>/

>> +<U0025><U006D><U0025><U0074><U0025><U0066>"

> 

> Could be written directly because it is ASCII.

Done  
> > +name_miss   "Miss."

> > +name_mr     "Mr."

> > +name_mrs    "Mrs."

>> +name_ms     "Ms."

> > +END LC_NAME

> > +

> > +

> > +LC_ADDRESS

> > +postal_fmt   "%f%N%h%s%N%T"

> > +country_name "Mauritius"

> > +country_ab2  "MU"

> > +country_ab3  "MUS"

> > +country_num  480

> +% https://en.wikipedia.org/wiki/List_of_international_vehicle_registration_codes

> +country_car  "MS"

> +country_isbn "978-613,978-620,978-99903,978-99949"

> +lang_name    "Morisyen"

> 

> According to mfe.xml in CLDR, this should be “kreol morisien”,

> Wikipedia has it capitalized as “Kreol Morisien”. I think we should

>follow CLDR here.

Done  
> > +lang_ab      "mfe"

> 

> lang_ab should contain the iso-639-1 code, but as there is no iso-639-1

> code for Morisyen, it should be empty or omitted, I think.

> 

>> +lang_term    "mfe"

> > +lang_lib     "mfe"

> 

> I think lang_lib is the iso-639-2 code and there is no iso-639-2

> code for Morisyen either, only iso-639-3.

> 

> I am not sure what one should do in such a case. I guess using the

> iso-639-3 code in lang_lib as well is OK, 


Thanks Mike for nice review all above comments are integrated 

https://sourceware.org/ml/libc-alpha/2017-08/msg01099.html

> > +END LC_ADDRESS
  

Patch

diff --git a/localedata/locales/bem_ZM b/localedata/locales/bem_ZM
index a09d53e..e02856e 100644
--- a/localedata/locales/bem_ZM
+++ b/localedata/locales/bem_ZM
@@ -62,19 +62,19 @@  mon  "<U004A><U0061><U006E><U0075><U0061><U0072><U0069>";/
      "<U004F><U006B><U0074><U006F><U0062><U0061>";/
      "<U004E><U006F><U0076><U0065><U006D><U0062><U0061>";/
      "<U0044><U0069><U0073><U0065><U006D><U0062><U0061>"
-% Jan, Feb, Mar, Apr, May, Jun, July, Aug, Sep, Oct, Nov, Dec
-abmon  "<U004A><U0061><U006E>";/
-       "<U0046><U0065><U0062>";/
-       "<U004D><U0061><U0072>";/
-       "<U0041><U0070><U0072>";/
-       "<U004D><U0061><U0079>";/
-       "<U004A><U0075><U006E>";/
-       "<U004A><U0075><U006C><U0079>";/
-       "<U0041><U0075><U0067>";/
-       "<U0053><U0065><U0070>";/
-       "<U004F><U0063><U0074>";/
-       "<U004E><U006F><U0076>";/
-       "<U0044><U0065><U0063>"
+% http://scriptsource.org/cms/scripts/page.php?item_id=entry_detail&uid=czeauxc7tq
+abmon  "Jan";/
+       "Feb";/
+       "Mac";/
+       "Epr";/
+       "Mei";/
+       "Jun";/
+       "Jul";/
+       "Oga";/
+       "Sep";/
+       "Okt";/
+       "Nov";/
+       "Dis"
 % Pa Mulungu, Palichimo, Palichibuli, Palichitatu, Palichine, Palichisano, Pachibelushi
 day  "<U0050><U0061><U0020><U004D><U0075><U006C><U0075><U006E><U0067><U0075>";/
      "<U0050><U0061><U006C><U0069><U0063><U0068><U0069><U006D><U006F>";/