Patchwork [RFA] Use std::move in a few places

login
register
mail settings
Submitter Tom Tromey
Date Aug. 11, 2017, 7:55 p.m.
Message ID <20170811195528.31392-1-tom@tromey.com>
Download mbox | patch
Permalink /patch/22105/
State New
Headers show

Comments

Tom Tromey - Aug. 11, 2017, 7:55 p.m.
This patch adds std::move to few spots where it seems to be missing.

Regression tested by the buildbot.

ChangeLog
2017-08-11  Tom Tromey  <tom@tromey.com>

	* break-catch-throw.c (handle_gnu_v3_exceptions): Use std::move.
	* break-catch-syscall.c (create_syscall_event_catchpoint): Use
	std::move.
	* break-catch-sig.c (create_signal_catchpoint): Use std::move.
---
 gdb/ChangeLog             | 7 +++++++
 gdb/break-catch-sig.c     | 2 +-
 gdb/break-catch-syscall.c | 2 +-
 gdb/break-catch-throw.c   | 2 +-
 4 files changed, 10 insertions(+), 3 deletions(-)

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c588291..a143d4d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@ 
+2017-08-11  Tom Tromey  <tom@tromey.com>
+
+	* break-catch-throw.c (handle_gnu_v3_exceptions): Use std::move.
+	* break-catch-syscall.c (create_syscall_event_catchpoint): Use
+	std::move.
+	* break-catch-sig.c (create_signal_catchpoint): Use std::move.
+
 2017-08-11  Pedro Alves  <palves@redhat.com>
 
 	* infrun.c (process_event_stop_test): Adjust
diff --git a/gdb/break-catch-sig.c b/gdb/break-catch-sig.c
index c8529de..98888c9 100644
--- a/gdb/break-catch-sig.c
+++ b/gdb/break-catch-sig.c
@@ -322,7 +322,7 @@  create_signal_catchpoint (int tempflag, std::vector<gdb_signal> &&filter,
 
   c = new signal_catchpoint ();
   init_catchpoint (c, gdbarch, tempflag, NULL, &signal_catchpoint_ops);
-  c->signals_to_be_caught = filter;
+  c->signals_to_be_caught = std::move (filter);
   c->catch_all = catch_all;
 
   install_breakpoint (0, c, 1);
diff --git a/gdb/break-catch-syscall.c b/gdb/break-catch-syscall.c
index 58fc279..701645e 100644
--- a/gdb/break-catch-syscall.c
+++ b/gdb/break-catch-syscall.c
@@ -375,7 +375,7 @@  create_syscall_event_catchpoint (int tempflag, std::vector<int> &&filter,
 
   c = new syscall_catchpoint ();
   init_catchpoint (c, gdbarch, tempflag, NULL, ops);
-  c->syscalls_to_be_caught = filter;
+  c->syscalls_to_be_caught = std::move (filter);
 
   install_breakpoint (0, c, 1);
 }
diff --git a/gdb/break-catch-throw.c b/gdb/break-catch-throw.c
index e71a885..5318e5f 100644
--- a/gdb/break-catch-throw.c
+++ b/gdb/break-catch-throw.c
@@ -382,7 +382,7 @@  handle_gnu_v3_exceptions (int tempflag, std::string &&except_rx,
      the right thing.  */
   cp->type = bp_breakpoint;
   cp->kind = ex_event;
-  cp->exception_rx = except_rx;
+  cp->exception_rx = std::move (except_rx);
   cp->pattern = std::move (pattern);
 
   re_set_exception_catchpoint (cp.get ());