Patchwork [AArch64,5/6] Implement gdbarch_core_read_description

login
register
mail settings
Submitter Jiong Wang
Date Aug. 9, 2017, 12:18 p.m.
Message ID <acf76d2e-3d27-434d-b144-c8c61ea5cd5f@foss.arm.com>
Download mbox | patch
Permalink /patch/22037/
State New
Headers show

Comments

Jiong Wang - Aug. 9, 2017, 12:18 p.m.
Currently, AArch64 only have one target description which is tdesc_aarch64.  So,
we haven't implemented any target description detetion mechanism for core file.

This patch is an initial implement of core_read_description method.  The "pauth"
feature or any future feature can use this to conditionally return selected
description.

gdb/
2017-08-09  Jiong Wang<jiong.wang@arm.com>

	* aarch64-linux-tdep.c (aarch64_linux_core_read_description): New
	function.
	(aarch64_linux_init_abi): Register gdbarch_core_read_description.
Yao Qi - Aug. 9, 2017, 2:22 p.m.
Jiong Wang <jiong.wang@foss.arm.com> writes:

> 2017-08-09  Jiong Wang<jiong.wang@arm.com>

Two spaces between your name and email address.

>
> 	* aarch64-linux-tdep.c (aarch64_linux_core_read_description): New
> 	function.
> 	(aarch64_linux_init_abi): Register gdbarch_core_read_description.
>
>
> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
> index d2ca70a..ec6125a 100644
> --- a/gdb/aarch64-linux-tdep.c
> +++ b/gdb/aarch64-linux-tdep.c
> @@ -231,6 +231,20 @@ aarch64_linux_iterate_over_regset_sections (struct gdbarch *gdbarch,
>        NULL, cb_data);
>  }
>  
> +/* Determine target description from core file.  */

/* Implement the "core_read_description" gdbarch method.  */

> +
> +static const struct target_desc *
> +aarch64_linux_core_read_description (struct gdbarch *gdbarch,
> +				     struct target_ops *target, bfd *abfd)
> +{
> +  CORE_ADDR aarch64_hwcap = 0;
> +
> +  if (target_auxv_search (target, AT_HWCAP, &aarch64_hwcap) != 1)
> +    return NULL;
> +
> +  return tdesc_aarch64;
> +}

This patch doesn't depend on other patches, so it can go in now.
Jiong Wang - Aug. 9, 2017, 2:57 p.m.
> This patch doesn't depend on other patches, so it can go in now.
>
I had committed this patch after addressing all comments, but just reverted.

it's my bad haven't give it a quick build.  It depends on AT_HWCAP defined in patch 1 and the value needs to be synced with kernel...

Patch

diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index d2ca70a..ec6125a 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -231,6 +231,20 @@  aarch64_linux_iterate_over_regset_sections (struct gdbarch *gdbarch,
       NULL, cb_data);
 }
 
+/* Determine target description from core file.  */
+
+static const struct target_desc *
+aarch64_linux_core_read_description (struct gdbarch *gdbarch,
+				     struct target_ops *target, bfd *abfd)
+{
+  CORE_ADDR aarch64_hwcap = 0;
+
+  if (target_auxv_search (target, AT_HWCAP, &aarch64_hwcap) != 1)
+    return NULL;
+
+  return tdesc_aarch64;
+}
+
 /* Implementation of `gdbarch_stap_is_single_operand', as defined in
    gdbarch.h.  */
 
@@ -1018,6 +1032,8 @@  aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
 
   set_gdbarch_iterate_over_regset_sections
     (gdbarch, aarch64_linux_iterate_over_regset_sections);
+  set_gdbarch_core_read_description
+    (gdbarch, aarch64_linux_core_read_description);
 
   /* SystemTap related.  */
   set_gdbarch_stap_integer_prefixes (gdbarch, stap_integer_prefixes);