diff mbox

[v3] Fix Days and Months name for Afar Locale

Message ID 1502186127-30851-1-git-send-email-akhilesh.k@samsung.com
State Rejected
Delegated to: Mike Fabian
Headers

Commit Message

Akhilesh Kumar Aug. 8, 2017, 9:55 a.m. UTC 
  Reference is taken from "Localization Standard for Afaraf"

http://www.mcit.gov.et/documents/1268465/1282796/Localization+\
Standard+for+AFARAF/4dab7d83-e6df-4f4f-b236-b89748c456e9?version=1.0

---
 localedata/locales/aa_DJ |   91 ++++++++++++++++++++----------------------
 localedata/locales/aa_ET |   99 +++++++++++++++++++++++-----------------------
 2 files changed, 93 insertions(+), 97 deletions(-)
 mode change 100644 => 100755 localedata/locales/aa_DJ

Comments

Mike FABIAN Aug. 8, 2017, 12:39 p.m. UTC | #1 
Akhilesh Kumar <akhilesh.k@samsung.com> wrote:

> Reference is taken from "Localization Standard for Afaraf"
>
> http://www.mcit.gov.et/documents/1268465/1282796/Localization+\
> Standard+for+AFARAF/4dab7d83-e6df-4f4f-b236-b89748c456e9?version=1.0

Nice, so the month and day names we had so far, were almost completly
wrong, according to that standard ..

> -%
> -% Equivalent of AM PM
> -%
> -am_pm    "<U0073><U0061><U0061><U006B><U0075>";/
> -         "<U0063><U0061><U0072><U0072><U0061>"

Why did you remove am_pm? and only for aa_DJ, not for aa_ET?

> +mon      "Waysu";/
> +         "Diteli";/
> +         "Ximoli";/
> +         "Kaxxa<U002D>Garablu";/
> +         "Qunxa<U002D>Garablu";/
> +         "Naharsi<U002D>kudo";/
> +         "Ciggilta<U002D>kudo";/
> +         "Agda<U002D>baxisso";/
> +         "Caxah<U002D>alsa";/
> +         "Qado<U002D>Dirri";/
> +         "Qasa<U002D>Dirri";/
> +         "Laqeeni";/
> +         "Paguume"

The <U002D> could be written as “-”.

>  %
>  % Equivalent of AM PM
>  %

Here you left the AM/PM.

There are also aa_ER and aa_ER@saaho which also seem to contain the
wrong month and day names.
Mike FABIAN Aug. 8, 2017, 12:48 p.m. UTC | #2 
Akhilesh Kumar <akhilesh.k@samsung.com> wrote:

> Reference is taken from "Localization Standard for Afaraf"
>
> http://www.mcit.gov.et/documents/1268465/1282796/Localization+\
> Standard+for+AFARAF/4dab7d83-e6df-4f4f-b236-b89748c456e9?version=1.0
>
> ---
>  localedata/locales/aa_DJ |   91 ++++++++++++++++++++----------------------
>  localedata/locales/aa_ET |   99 +++++++++++++++++++++++-----------------------

[...]

> -%
> +day      "Acaada";/
> +  	  "Itleeni";/ 	
> + 	  "Talaata"

There is a ;/ missing here.

> +         "Arbaqa";/
> +	  "Kameesi";/
> +         "Gumqaata";/
> +         "Sabti"

[...]

> +% 
> +abmon    "Way";/
> +         "Dit";/
> +         "Xim";/
> +	  "Kax"

and here a ;/ is missing.

> +         "Qun";/
> +         "Nah";/
> +         "cig";/
> +         "Agd";/
> +         "Cax";/
> +         "Qad";/
> +         "Qas";/
> +         "Laq";/
> +         "Pag"
Mike FABIAN Aug. 8, 2017, 1:47 p.m. UTC | #3 
Mike FABIAN <mfabian@redhat.com> wrote:

> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>
>> Reference is taken from "Localization Standard for Afaraf"
>>
>> http://www.mcit.gov.et/documents/1268465/1282796/Localization+\
>> Standard+for+AFARAF/4dab7d83-e6df-4f4f-b236-b89748c456e9?version=1.0
>
> Nice, so the month and day names we had so far, were almost completly
> wrong, according to that standard ..
>
>> -%
>> -% Equivalent of AM PM
>> -%
>> -am_pm    "<U0073><U0061><U0061><U006B><U0075>";/
>> -         "<U0063><U0061><U0072><U0072><U0061>"
>
> Why did you remove am_pm? and only for aa_DJ, not for aa_ET?
>
>> +mon      "Waysu";/
>> +         "Diteli";/
>> +         "Ximoli";/
>> +         "Kaxxa<U002D>Garablu";/
>> +         "Qunxa<U002D>Garablu";/
>> +         "Naharsi<U002D>kudo";/
>> +         "Ciggilta<U002D>kudo";/
>> +         "Agda<U002D>baxisso";/
>> +         "Caxah<U002D>alsa";/
>> +         "Qado<U002D>Dirri";/
>> +         "Qasa<U002D>Dirri";/
>> +         "Laqeeni";/
>> +         "Paguume"

These are 13 month names.

http://www.mcit.gov.et/documents/1268465/1282796/Localization+Standard+for+AFARAF/4dab7d83-e6df-4f4f-b236-b89748c456e9?version=1.0

says:

> 9. Calendar  
> 9.1 System of the Calendar   
> 
> Ethiopia officially uses a calendar which is different from the
> Gregorian calendar.  The calendar is known as Ethiopian Calendar (E.C.)
> which is 7 years behind the Gregorian calendar, from September 11/ 12 to
> December, and 8 years behind for the rest, i.e.  January to September
> 10/ 11.  The calendar has 12 months each having 30 days equally and an
> additional 5/6 days depending on the leap year, where 5 days are during
> normal year and 6 days for the Ethiopian leap year. These additional 5/6
> days are called P'agume and come at the end of the year as the “13th
> month”.
>  
> In the Ethiopian calendar, New Year starts on the 1st of the month of
> Meskerem which falls on 11th of September in the Gregorian calendar
> except the year next to the Ethiopian leap year which is September 12.
>  
> 9.2   Names of Months   
> Table 3: Afaraf names of months  
> 
> [... table with the names of the 13 months ...]

I’m not sure how this can be put in to the aa_* locale files at all.

glibc does not support Ethiopian calendar, or does it?
Rafal Luzynski Aug. 8, 2017, 6:22 p.m. UTC | #4 
8.08.2017 15:47 Mike FABIAN <mfabian@redhat.com> wrote:
> [...]
> These are 13 month names.
> [...]
> > [... table with the names of the 13 months ...]
>
> I’m not sure how this can be put in to the aa_* locale files at all.
>
> glibc does not support Ethiopian calendar, or does it?

glibc does not support anything other than the Gregorian calendar
and there is no easy way to change it.  We can't define MON_13 as
MON_12 + 1 because this equals AM_STR.  We can't shift the constants
because this would cause a huge ABI incompatibility.  Lots of
date/time processing functions report an error if a month number
is greater than 12 (or greater than 11 if the month number is
zero-based).

If preparing locales for the countries which use non-Gregorian
calendars we should rather ask how do they call Gregorian months.

Non-Gregorian calendars are supportable only if they accidentally
follow the same rules as Gregorian.  For example, Julian calendar
should be supportable.  But this is not helpful for many
non-European countries.

For non-Gregorian calendars ICU library is probably a better choice.

Regards,

Rafal
Rafal Luzynski Aug. 8, 2017, 6:32 p.m. UTC | #5 
8.08.2017 11:55 Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
> [...]
> --- a/localedata/locales/aa_DJ
> +++ b/localedata/locales/aa_DJ
> [...]
> +abmon "Way";/
> + "Dit";/
> + "Xim";/
> + "Kax"
> + "Qun";/
> + "Nah";/
> + "cig";/

"cig" is lowercase, most probably consequently should be "Cig".

> [...]
> --- a/localedata/locales/aa_ET
> +++ b/localedata/locales/aa_ET
> [...]
> +abmon "Way";/
> + "Dit";/
> + "Xim";/
> + "Kax"
> + "Qun";/
> + "Nah";/
> + "cig";/

The same here.

Regards,

Rafal
Mike FABIAN Aug. 9, 2017, 6:01 a.m. UTC | #6 
Rafal Luzynski <digitalfreak@lingonborough.com> wrote:

> If preparing locales for the countries which use non-Gregorian
> calendars we should rather ask how do they call Gregorian months.

Yes, I agree!

With the month names from 

http://www.mcit.gov.et/documents/1268465/1282796/Localization+Standard+for+AFARAF/4dab7d83-e6df-4f4f-b236-b89748c456e9?version=1.0

wrong month names will be displayed because the calendar calculation
glibc does is gregorian and the months from that Ethiopian calendar
just don’t fit to the gregorian calendar system.

So we would need to know how the Gregorian months are called in
Afar.
diff mbox

Patch

diff --git a/localedata/locales/aa_DJ b/localedata/locales/aa_DJ
old mode 100644
new mode 100755
index 98fbc1c..463cb79
--- a/localedata/locales/aa_DJ
+++ b/localedata/locales/aa_DJ
@@ -32,7 +32,7 @@  title      "Afar language locale for Djibouti (Cadu//Laaqo Dialects)."
 source     "Ge'ez Frontier Foundation"
 address    "7802 Solomon Seal Dr., Springfield, VA 22152, USA"
 contact    ""
-email      "locales@geez.org"
+email      "locales@geez.org, akhilesh.k@samsung.com"
 tel        ""
 fax        ""
 language   "Afar"
@@ -186,61 +186,58 @@  END LC_NAME
 
 
 LC_TIME
-%
+% http://www.mcit.gov.et/documents/1268465/1282796/Localization+Standard+for+AFARAF/4dab7d83-e6df-4f4f-b236-b89748c456e9?version=1.0
 % Abbreviated weekday names (%a)
 %
-abday    "<U0061><U0063><U0061>";/
-         "<U0065><U0074><U006C>";/
-         "<U0074><U0061><U006C>";/
-         "<U0061><U0072><U0062>";/
-         "<U006B><U0061><U006D>";/
-         "<U0067><U0075><U006D>";/
-         "<U0073><U0061><U0062>"
+abday    "Ac";/
+         "It";/
+         "Ta";/
+         "Ar";/
+         "Ka";/
+         "Gu";/
+         "Sa"
 %
 % Full weekday names (%A)
 %
-day      "<U0041><U0063><U0061><U0061><U0064><U0061>";/
-         "<U0045><U0074><U006C><U0065><U0065><U006E><U0069>";/
-         "<U0054><U0061><U006C><U0061><U0061><U0074><U0061>";/
-         "<U0041><U0072><U0062><U0061><U0071><U0061>";/
-         "<U004B><U0061><U006D><U0069><U0069><U0073><U0069>";/
-         "<U0047><U0075><U006D><U0071><U0061><U0074><U0061>";/
-         "<U0053><U0061><U0062><U0074><U0069>"
-%
+day      "Acaada";/
+  	  "Itleeni";/ 	
+ 	  "Talaata"	
+         "Arbaqa";/
+	  "Kameesi";/
+         "Gumqaata";/
+         "Sabti"
+% http://www.mcit.gov.et/documents/1268465/1282796/Localization+Standard+for+AFARAF/4dab7d83-e6df-4f4f-b236-b89748c456e9?version=1.0
 % Abbreviated month names (%b)
-%
-abmon    "<U0071><U0075><U006E>";/
-         "<U006E><U0061><U0068>";/
-         "<U0063><U0069><U0067>";/
-         "<U0061><U0067><U0064>";/
-         "<U0063><U0061><U0078>";/
-         "<U0071><U0061><U0073>";/
-         "<U0071><U0061><U0064>";/
-         "<U006C><U0065><U0071>";/
-         "<U0077><U0061><U0079>";/
-         "<U0064><U0069><U0074>";/
-         "<U0078><U0069><U006D>";/
-         "<U006B><U0061><U0078>"
+% 
+abmon    "Way";/
+         "Dit";/
+         "Xim";/
+	  "Kax"
+         "Qun";/
+         "Nah";/
+         "cig";/
+         "Agd";/
+         "Cax";/
+         "Qad";/
+         "Qas";/
+         "Laq";/
+         "Pag"
 %
 % Full month names (%B)
 %
-mon      "<U0051><U0075><U006E><U0078><U0061><U0020><U0047><U0061><U0072><U0061><U0062><U006C><U0075>";/
-         "<U004B><U0075><U0064><U006F>";/
-         "<U0043><U0069><U0067><U0067><U0069><U006C><U0074><U0061><U0020><U004B><U0075><U0064><U006F>";/
-         "<U0041><U0067><U0064><U0061><U0020><U0042><U0061><U0078><U0069><U0073><U0073><U006F>";/
-         "<U0043><U0061><U0078><U0061><U0068><U0020><U0041><U006C><U0073><U0061>";/
-         "<U0051><U0061><U0073><U0061><U0020><U0044><U0069><U0072><U0072><U0069>";/
-         "<U0051><U0061><U0064><U006F><U0020><U0044><U0069><U0072><U0072><U0069>";/
-         "<U004C><U0069><U0069><U0071><U0065><U006E>";/
-         "<U0057><U0061><U0079><U0073><U0075>";/
-         "<U0044><U0069><U0074><U0065><U006C><U0069>";/
-         "<U0058><U0069><U006D><U006F><U006C><U0069>";/
-         "<U004B><U0061><U0078><U0078><U0061><U0020><U0047><U0061><U0072><U0061><U0062><U006C><U0075>"
-%
-% Equivalent of AM PM
-%
-am_pm    "<U0073><U0061><U0061><U006B><U0075>";/
-         "<U0063><U0061><U0072><U0072><U0061>"
+mon      "Waysu";/
+         "Diteli";/
+         "Ximoli";/
+         "Kaxxa<U002D>Garablu";/
+         "Qunxa<U002D>Garablu";/
+         "Naharsi<U002D>kudo";/
+         "Ciggilta<U002D>kudo";/
+         "Agda<U002D>baxisso";/
+         "Caxah<U002D>alsa";/
+         "Qado<U002D>Dirri";/
+         "Qasa<U002D>Dirri";/
+         "Laqeeni";/
+         "Paguume"
 %
 % Appropriate date representation (%x)
 %	"%d.%m.%Y"
diff --git a/localedata/locales/aa_ET b/localedata/locales/aa_ET
index 78e7df2..c1a785c 100644
--- a/localedata/locales/aa_ET
+++ b/localedata/locales/aa_ET
@@ -18,9 +18,6 @@  escape_char /
 % Afar Civilization Researcher, Melka Werer Research Center.
 % Prepared and contributed to glibc by Daniel Yacob <locales@geez.org>.
 %
-% This locale data has been developed under the Yeha Project:
-%      http://yeha.sourceforge.net/
-%
 % build with: localedef -f UTF-8 -i aa_ET aa_ET
 %
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -29,16 +26,16 @@  escape_char /
 LC_IDENTIFICATION
 %
 title      "Afar language locale for Ethiopia (Cadu//Carra Dialects)."
-source     "Ge'ez Frontier Foundation"
-address    "7802 Solomon Seal Dr., Springfield, VA 22152, USA"
+source     "Samsung Electronics Co., Ltd."
+address    ""
 contact    ""
-email      "locales@geez.org"
+email      "locales@geez.org, akhilesh.k@samsung.com"
 tel        ""
 fax        ""
-language   "Afar"
+language   "Afar/Afaraf"
 territory  "Ethiopia"
-revision   "0.20"
-date       "2003-07-05"
+revision   "0.30"
+date       "2017-08-08"
 
 category "i18n:2012";LC_IDENTIFICATION
 category "i18n:2012";LC_COLLATE
@@ -152,56 +149,58 @@  END LC_NAME
 
 
 LC_TIME
-%
+% http://www.mcit.gov.et/documents/1268465/1282796/Localization+Standard+for+AFARAF/4dab7d83-e6df-4f4f-b236-b89748c456e9?version=1.0
 % Abbreviated weekday names (%a)
 %
-abday    "<U0041><U0063><U0061>";/
-         "<U0045><U0074><U006C>";/
-         "<U0054><U0061><U006C>";/
-         "<U0041><U0072><U0062>";/
-         "<U004B><U0061><U006D>";/
-         "<U0047><U0075><U006D>";/
-         "<U0053><U0061><U0062>"
+abday    "Ac";/
+         "It";/
+         "Ta";/
+         "Ar";/
+         "Ka";/
+         "Gu";/
+         "Sa"
 %
 % Full weekday names (%A)
 %
-day      "<U0041><U0063><U0061><U0061><U0064><U0061>";/
-         "<U0045><U0074><U006C><U0065><U0065><U006E><U0069>";/
-         "<U0054><U0061><U006C><U0061><U0061><U0074><U0061>";/
-         "<U0041><U0072><U0062><U0061><U0071><U0061>";/
-         "<U004B><U0061><U006D><U0069><U0069><U0073><U0069>";/
-         "<U0047><U0075><U006D><U0071><U0061><U0074><U0061>";/
-         "<U0053><U0061><U0062><U0074><U0069>"
-%
+day      "Acaada";/
+	  "Itleeni";/ 	
+	  "Talaata"	
+         "Arbaqa";/
+	  "Kameesi";/
+         "Gumqaata";/
+         "Sabti"
+% http://www.mcit.gov.et/documents/1268465/1282796/Localization+Standard+for+AFARAF/4dab7d83-e6df-4f4f-b236-b89748c456e9?version=1.0
 % Abbreviated month names (%b)
-%
-abmon    "<U0051><U0075><U006E>";/
-         "<U004B><U0075><U0064>";/
-         "<U0043><U0069><U0067>";/
-         "<U0041><U0067><U0064>";/
-         "<U0043><U0061><U0078>";/
-         "<U0051><U0061><U0073>";/
-         "<U0051><U0061><U0064>";/
-         "<U004C><U0065><U0071>";/
-         "<U0057><U0061><U0079>";/
-         "<U0044><U0069><U0074>";/
-         "<U0058><U0069><U006D>";/
-         "<U004B><U0061><U0078>"
+% 
+abmon    "Way";/
+         "Dit";/
+         "Xim";/
+	 "Kax"
+         "Qun";/
+         "Nah";/
+         "cig";/
+         "Agd";/
+         "Cax";/
+         "Qad";/
+         "Qas";/
+         "Laq";/
+         "Pag"
 %
 % Full month names (%B)
 %
-mon      "<U0051><U0075><U006E><U0078><U0061><U0020><U0047><U0061><U0072><U0061><U0062><U006C><U0075>";/
-         "<U004B><U0075><U0064><U006F>";/
-         "<U0043><U0069><U0067><U0067><U0069><U006C><U0074><U0061><U0020><U004B><U0075><U0064><U006F>";/
-         "<U0041><U0067><U0064><U0061><U0020><U0042><U0061><U0078><U0069><U0073><U0073><U006F>";/
-         "<U0043><U0061><U0078><U0061><U0068><U0020><U0041><U006C><U0073><U0061>";/
-         "<U0051><U0061><U0073><U0061><U0020><U0044><U0069><U0072><U0072><U0069>";/
-         "<U0051><U0061><U0064><U006F><U0020><U0044><U0069><U0072><U0072><U0069>";/
-         "<U004C><U0069><U0069><U0071><U0065><U006E>";/
-         "<U0057><U0061><U0079><U0073><U0075>";/
-         "<U0044><U0069><U0074><U0065><U006C><U0069>";/
-         "<U0058><U0069><U006D><U006F><U006C><U0069>";/
-         "<U004B><U0061><U0078><U0078><U0061><U0020><U0047><U0061><U0072><U0061><U0062><U006C><U0075>"
+mon      "Waysu";/
+         "Diteli";/
+         "Ximoli";/
+         "Kaxxa<U002D>Garablu";/
+         "Qunxa<U002D>Garablu";/
+         "Naharsi<U002D>kudo";/
+         "Ciggilta<U002D>kudo";/
+         "Agda<U002D>baxisso";/
+         "Caxah<U002D>alsa";/
+         "Qado<U002D>Dirri";/
+         "Qasa<U002D>Dirri";/
+         "Laqeeni";/
+         "Paguume"
 %
 % Equivalent of AM PM
 %