From patchwork Mon Aug 7 15:05:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 21949 Received: (qmail 8534 invoked by alias); 7 Aug 2017 15:05:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 8513 invoked by uid 89); 7 Aug 2017 15:05:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=(unknown) X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-oi0-f65.google.com Received: from mail-oi0-f65.google.com (HELO mail-oi0-f65.google.com) (209.85.218.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Aug 2017 15:05:46 +0000 Received: by mail-oi0-f65.google.com with SMTP id j194so648673oib.4; Mon, 07 Aug 2017 08:05:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6sUMrTSIJxgdAOC0fUjCJnhPiEq4We0lLtZZYgjG2Zs=; b=q0WEczqavQ6lCut/iw17O0yQa5vUKZ0fyzHw4192+tX+qH24MrNSActhQOxkApda2e HM5XIJRkZnF3KQsdGKe70I0zOzBLorMKfBuYy08KcwInN75rCR4RbS5kM49dX61j735Y a30qTE8d7EzBsL6JKKd9w8M5GAfTy+lDuHlKULoDyacOf366dGSgXWy2SoK+245MYwQa /1gf8w0Ubh4Z/hrfvkKbC8cUh6X70nJ7zGxb2Qqax+1xF+cmtJATnO33nu6NEhbJpPT2 sBSvysP7bckzYekmPQsa1Ce3XD1wOYO9cyy3vHkSOgGm52ERmwaAnifWZJsl2IgDoO// X57g== X-Gm-Message-State: AHYfb5jNFmaZmgccfHMyiZSjytStR8PP+bcMZaTTNuIPn7zM8pzq1VJV jSZMs051PI+1sC4+smirfqvzHPq7nA== X-Received: by 10.202.179.85 with SMTP id c82mr491522oif.5.1502118344417; Mon, 07 Aug 2017 08:05:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.136.75 with HTTP; Mon, 7 Aug 2017 08:05:43 -0700 (PDT) In-Reply-To: References: <20170807132424.GF3406@bubble.grove.modra.org> From: "H.J. Lu" Date: Mon, 7 Aug 2017 08:05:43 -0700 Message-ID: Subject: Re: [PATCH] GDB/opcodes: Remove arch/mach/endian disassembler assertions To: "Maciej W. Rozycki" Cc: Alan Modra , Binutils , GDB , Yao Qi X-IsSubscribed: yes On Mon, Aug 7, 2017 at 7:56 AM, Maciej W. Rozycki wrote: > On Mon, 7 Aug 2017, Alan Modra wrote: > >> > gdb/ >> > * arch-utils.c (default_print_insn): Remove arch/mach/endian >> > assertions. >> > >> > opcodes/ >> > * disassemble.c (disassembler): Remove arch/mach/endian >> > assertions. >> >> This is OK, obvious really. > > Applied now, thanks for your review. > > Maciej I am checking in: to fix /export/gnu/import/git/sources/binutils-gdb/opcodes/disassemble.c: In function ‘disassembler’: /export/gnu/import/git/sources/binutils-gdb/opcodes/disassemble.c:113:52: error: unused parameter ‘big’ [-Werror=unused-parameter] disassembler (enum bfd_architecture a, bfd_boolean big, unsigned long mach, ^~~ /export/gnu/import/git/sources/binutils-gdb/opcodes/disassemble.c:113:71: error: unused parameter ‘mach’ [-Werror=unused-parameter] disassembler (enum bfd_architecture a, bfd_boolean big, unsigned long mach, ^~~~ cc1: all warnings being treated as errors make[6]: *** [Makefile:1313: disassemble.lo] Error 1 on x86. diff --git a/opcodes/disassemble.c b/opcodes/disassemble.c index 0058354265..11206c67a5 100644 --- a/opcodes/disassemble.c +++ b/opcodes/disassemble.c @@ -110,7 +110,9 @@ #endif disassembler_ftype -disassembler (enum bfd_architecture a, bfd_boolean big, unsigned long mach, +disassembler (enum bfd_architecture a, + bfd_boolean big ATTRIBUTE_UNUSED, + unsigned long mach ATTRIBUTE_UNUSED, bfd *abfd ATTRIBUTE_UNUSED) { disassembler_ftype disassemble;