Patchwork [v2] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode

login
register
mail settings
Submitter Ruslan Kabatsayev
Date Aug. 4, 2017, 7:27 p.m.
Message ID <1501874838-3067-1-git-send-email-b7.10110111@gmail.com>
Download mbox | patch
Permalink /patch/21924/
State New
Headers show

Comments

Ruslan Kabatsayev - Aug. 4, 2017, 7:27 p.m.
From: Ruslan Kabatsayev <b7.10110111@gmail.com>

Currently, "layout asm" is not so useful as "layout src" with Single-Key mode:
you have to use multi-key commands like "ni" and "si" to do single-stepping.
This patch adds, in addition to "next" and "step" commands, corresponding
assembly-level ones - "nexti" and "stepi" - to Single-Key mode, with the
shortcuts of "o" (from "step Over") and "i" (from "Step Into") respectively.

gdb/ChangeLog:

	* tui/tui.c: Add "nexti" and "stepi" to the tui_commands list
	* doc/gdb.texinfo: Document the new shortcuts in Single-Key mode
---
 gdb/doc/gdb.texinfo |    8 ++++++++
 gdb/tui/tui.c       |    2 ++
 2 files changed, 10 insertions(+)
Eli Zaretskii - Aug. 5, 2017, 6:29 a.m.
> From: b7.10110111@gmail.com
> Cc: Ruslan Kabatsayev <b7.10110111@gmail.com>
> Date: Fri,  4 Aug 2017 22:27:18 +0300
> 
> From: Ruslan Kabatsayev <b7.10110111@gmail.com>
> 
> Currently, "layout asm" is not so useful as "layout src" with Single-Key mode:
> you have to use multi-key commands like "ni" and "si" to do single-stepping.
> This patch adds, in addition to "next" and "step" commands, corresponding
> assembly-level ones - "nexti" and "stepi" - to Single-Key mode, with the
> shortcuts of "o" (from "step Over") and "i" (from "Step Into") respectively.

The "i" in "nexti" and "ni" stands for "instruction", not "into".

Personally, I'm not sure this is worth it, but then I don't use TUI
frequently enough to have my opinion count.

If the code change is accepted, the documentation review is below.

> gdb/ChangeLog:
> 
> 	* tui/tui.c: Add "nexti" and "stepi" to the tui_commands list
> 	* doc/gdb.texinfo: Document the new shortcuts in Single-Key mode

The ChangeLog entries need to state the function/data structure in
which the change is made (node name for the manual).  Also,
gdb.texinfo has a separate ChangeLog in gdb/doc/.

> +@kindex o @r{(SingleKey TUI key)}
> +@item o
> +nexti. The letter @samp{o} stands for ``step Over''.
        ^^
We leave two spaces between sentences.

Thanks.
Ruslan Kabatsayev - Aug. 5, 2017, 6:38 a.m.
On 5 August 2017 at 09:29, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: b7.10110111@gmail.com
>> Cc: Ruslan Kabatsayev <b7.10110111@gmail.com>
>> Date: Fri,  4 Aug 2017 22:27:18 +0300
>>
>> From: Ruslan Kabatsayev <b7.10110111@gmail.com>
>>
>> Currently, "layout asm" is not so useful as "layout src" with Single-Key mode:
>> you have to use multi-key commands like "ni" and "si" to do single-stepping.
>> This patch adds, in addition to "next" and "step" commands, corresponding
>> assembly-level ones - "nexti" and "stepi" - to Single-Key mode, with the
>> shortcuts of "o" (from "step Over") and "i" (from "Step Into") respectively.
>
> The "i" in "nexti" and "ni" stands for "instruction", not "into".
Here I refer to the "i" the shortcut, not "i" in the "nexti" command.
We do need some way of memorizing the shortcut key, don't we? See the
discussion in the thread of the previous version of the patch. I may
have to make the wording clearer in the documentation though.
>
> Personally, I'm not sure this is worth it, but then I don't use TUI
> frequently enough to have my opinion count.
>
> If the code change is accepted, the documentation review is below.
>
>> gdb/ChangeLog:
>>
>>       * tui/tui.c: Add "nexti" and "stepi" to the tui_commands list
>>       * doc/gdb.texinfo: Document the new shortcuts in Single-Key mode
>
> The ChangeLog entries need to state the function/data structure in
> which the change is made (node name for the manual).  Also,
> gdb.texinfo has a separate ChangeLog in gdb/doc/.
>
>> +@kindex o @r{(SingleKey TUI key)}
>> +@item o
>> +nexti. The letter @samp{o} stands for ``step Over''.
>         ^^
> We leave two spaces between sentences.
>
> Thanks.

Patch

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 17b4c69..2bb794a 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -25415,6 +25415,10 @@  finish
 @item n
 next
 
+@kindex o @r{(SingleKey TUI key)}
+@item o
+nexti. The letter @samp{o} stands for ``step Over''.
+
 @kindex q @r{(SingleKey TUI key)}
 @item q
 exit the SingleKey mode.
@@ -25427,6 +25431,10 @@  run
 @item s
 step
 
+@kindex i @r{(SingleKey TUI key)}
+@item i
+stepi. The letter @samp{i} stands for ``step Into''.
+
 @kindex u @r{(SingleKey TUI key)}
 @item u
 up
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index c918f3e..b77a885 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -75,8 +75,10 @@  static const struct tui_char_command tui_commands[] = {
   { 'd', "down" },
   { 'f', "finish" },
   { 'n', "next" },
+  { 'o', "nexti" },
   { 'r', "run" },
   { 's', "step" },
+  { 'i', "stepi" },
   { 'u', "up" },
   { 'v', "info locals" },
   { 'w', "where" },