From patchwork Fri Aug 4 13:32:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 21918 Received: (qmail 52557 invoked by alias); 4 Aug 2017 13:32:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 52532 invoked by uid 89); 4 Aug 2017 13:32:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-io0-f194.google.com Received: from mail-io0-f194.google.com (HELO mail-io0-f194.google.com) (209.85.223.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 Aug 2017 13:32:34 +0000 Received: by mail-io0-f194.google.com with SMTP id m88so1092596iod.1 for ; Fri, 04 Aug 2017 06:32:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=8PxqltH/IjjhEPXydA23BS+OdJYarEUZ9UXxERbr36k=; b=HLfIk71GdCxXsibyC2czdI1yNs8vxaC1S57xuwz/ob6PMHSMFJo8S7w5RBknKuS/Do zoKow/WYqzXsF87V2oOvCZ7keA3P9kTwyrib3fc6+UKckTWHAhed5Kv6np4RhRxhi0p5 PAnQPnSbf+09ExUndAoOR0o9SNiQvyz+c7639nZ9Pb9SoEfQOB0GNB+3gXGsegbtJbDO SVplMfOmiAqdNAOuScJDTDHygAr0d7bXX8G5xgBi7x0tz9urjnCAHJmW3up0y8FRgzwI n8VnrQZTZAWaRN79vKHr51h0KEfHczfE/lZW0aX0diA/xbwK38PyXS6DWuhsyuf75Drd H3sQ== X-Gm-Message-State: AIVw1105TwNpn3XDurY9YHLGE0ehLY8xzHslmjtenmSA+e0lJXp2nTEE eXAXM27Q3eNKuyxg X-Received: by 10.107.12.70 with SMTP id w67mr2755413ioi.298.1501853552995; Fri, 04 Aug 2017 06:32:32 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id d201sm698669itb.0.2017.08.04.06.32.31 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 04 Aug 2017 06:32:32 -0700 (PDT) From: Yao Qi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA v3 21/23] Introduce gdb_argv, a class wrapper for buildargv References: <20170802150227.24460-1-tom@tromey.com> <20170802150227.24460-22-tom@tromey.com> Date: Fri, 04 Aug 2017 14:32:28 +0100 In-Reply-To: <20170802150227.24460-22-tom@tromey.com> (Tom Tromey's message of "Wed, 2 Aug 2017 09:02:25 -0600") Message-ID: <86vam31ms3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes Tom Tromey writes: > + bool operator!= (nullptr_t) > + { > + return m_argv != NULL; > + } > + > + bool operator== (nullptr_t) > + { > + return m_argv == NULL; > + } nullptr_t breaks the build for mingw target, and I pushed the following patch to fix it. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 7f16f86..d286f51 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-08-04 Yao Qi + + * utils.h (gdb_argv): Add namespace std for nullptr_t. + 2017-08-03 Ruslan Kabatsayev * MAINTAINERS (Write After Approval): Add Ruslan Kabatsayev. diff --git a/gdb/utils.h b/gdb/utils.h index c922a22..bb5fadc 100644 --- a/gdb/utils.h +++ b/gdb/utils.h @@ -185,12 +185,12 @@ public: return m_argv + count (); } - bool operator!= (nullptr_t) + bool operator!= (std::nullptr_t) { return m_argv != NULL; } - bool operator== (nullptr_t) + bool operator== (std::nullptr_t) { return m_argv == NULL; }