Message ID | 872a159d-95a0-f2e1-6100-24d681ff348e@ericsson.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 6381 invoked by alias); 25 Jul 2017 10:19:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 1134 invoked by uid 89); 25 Jul 2017 10:19:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Jul 2017 10:19:31 +0000 Received: from ESESSHC022.ericsson.se (Unknown_Domain [153.88.183.84]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id B4.C6.24422.F2B17795; Tue, 25 Jul 2017 12:19:28 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.84) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 25 Jul 2017 12:19:27 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [147.214.129.241] (192.176.1.81) by AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1304.10; Tue, 25 Jul 2017 10:19:25 +0000 Subject: Re: [PATCH 2/3] gdbserver lwp_info: Initialize fields, use new/delete To: Yao Qi <qiyaoltc@gmail.com> CC: <gdb-patches@sourceware.org> References: <1500892797-7523-1-git-send-email-simon.marchi@ericsson.com> <1500892797-7523-3-git-send-email-simon.marchi@ericsson.com> <861sp4rg6i.fsf@gmail.com> From: Simon Marchi <simon.marchi@ericsson.com> Message-ID: <872a159d-95a0-f2e1-6100-24d681ff348e@ericsson.com> Date: Tue, 25 Jul 2017 12:19:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <861sp4rg6i.fsf@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM3PR07CA0071.eurprd07.prod.outlook.com (2603:10a6:207:4::29) To AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dda0fb54-5029-42fa-a220-08d4d346a08d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AMSPR07MB310; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 3:NZUbRQyKRqvbuwrzgzTva1haUUxPkONBdOWYhQKXe1k1XzZ8sDPdmdNvyjAdYPryONf/gjcyPiMQ/+h6YuWpUzOfmZCoBFIaErCaLsM5wNx+F7V0TUlECde2a+aq3carojTcdy1BotY0KM3hmK5p4B7SCs23uAt8i0ZDJLeRwKr2xEOKFrTFueNqiHJiiFyoZxgc8gAd8ZWA7ZlBqoBCFX+uFgWw6BxbmOWpW18iD3O/iInsCFiUROJOvjv6VB9gOnPCYcixfMmITO23S2cBIMf0baX2F5Xrr+LQKQ4C0h9WH3xICA3Z8mdUZk5RSjXsbgaycdZ/YykWwykISnM5+1MHgNdWzEPt5d4tT/Uj10VXljhTTyRfF2+MAelviEwYMF7s12JWTbdBQOJJesoDMXHoFgnEDpd+1oN0ZKTUQsPvU2eq0m44T98Y8icd1Vn7/cb/zmDzf19fb/abNq0kZhf3+MFNF8TeBTRIOd/kV1YzG50RPObKbzyzNX/Gha4UnsoI+kVdD6o+hMDyRMi5ZB09OsF+49g+2t8TqvdN8B5LLBPvvWZUJsMAqzm0Z35RDdVyDJ+0biutQQv1uah44Sh+IwXsCko0pKobSic3EYse4m2gvkCz+Whm+6N75Pm+gL1lTW1MinGujvKR9S+H6Id6ZLbgfi4FrJiM8z4iOLJ32FGiKrrEJUbQicozAUHOxCXDHE8MDt5w3OSUraUrsZILDr26eo1HCncX6LXnHOw= X-MS-TrafficTypeDiagnostic: AMSPR07MB310: X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 25:Jwq+TpYjQEH43iYHC0W0y3EZphhqV2Y9LoD2nW6UB4iVxMsNHSQSM4iDz9LmgHO1O6bALNER/OW2o8xg3l5cLNKNv2rli9Xf0p5qgMMeGr76jXUVrEmEya5k98NzvvzRJvSqeOUQ75Em9KKqRziqiqtKZzG+QtOnt17MWy3ruvrslCWufnu/g5u+As0ccNbc7czaSlIS9DVuNUQVlt9CzDnOPgOARJuajiOxbxmFK3CwHjs3rVJ2cV1NkxDlGSyZEZ85AWq8vGMeXapvxkQynm5YHkN4abDTUU8fzgthmRtZhXcoP2HxBVu3Nz/0vne+yEwAJjr5lC3Ohzy3k2+K0Uhylmu4guXY5UXpn0h2mWleGFNEIFXaB5oJ1rVvQJ3rwF+m0/Kgt321wE6j4RlE7+/jWf7mwuN5o6QUFaeG9UScWeER1oEtoQbTqRILQvCZP07Pu3RZi0f4QTqMRH/6T7JC4/bVxjbzMFAavJUjP01dD7hgs1Yo0pXhMrU6TVpyuOFB+9yGCCKRqYw1UxT2SzFdrBXrXc71iNY6yZ1pAQyH8JulzBrkbM7a1YIuCx7TJT5lIClVvMeErI2aIVLqNj4CmtybKE9w76wtVINzPHDbU1q5f+HBENpERe30Qk1snuGwpQUF1Qn9WFQhhm9XV1WZSkw1JAOKnmw/3bKX1hpaNtahYDCla+z0Z+r8NwucUTGY7xFsctYuFzjM7hfNO5LeilD6raPJ9yhDePZv90MGqG0Kh/LjyhCA/+kzwS5VlNfi6TaZMwexdzbtJZW9oSOc0yKTY8nmyRCizppY822Dcst2jPhbsFKQ8T8BrRP1wOf3nEHDvoe46M6GkpI3iicZS2Q/MuZ2AVLe/1oa2LVZybMLjdedjVHSKr7DbbD0YOPZ/KC4w0ROgHPmvCZv6749iVAyp7LbgKx797WICM0= X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 31:Wmj5Ic8VbzQB3WnzgzDBko7+aozyWWKFrOHtPjdWsWBksbmfTF9T1UG+leoIZrAexXBsfa1cuRX86skJjXTgnUvDDaAYSv2Os2HOatHDsgv81lkxyG7i3nfJM1cWR7PxPIyvSo0ZD/Z6m8ggejHeMhYFC3H9jhmIJeZELYqCh1A+oF65Bp2RMsuEYsPA4mpUBtpMCCgPi3gLCaSnoLCd2sosWrR6eLPGaoyql1lO2Fbtt3/EXiuQHwjXF+NkvptvvItkeUS2I4eKPZsAAk0dwZxutmvCd2jqqKrmEAQTkYFElbpma6YReGX9oRMFKChLDvVdjv58w4k6CUmY5XtZt1LIOck7ZjVLN86c3pox5dRmTURFuabH1k3js+VXF5udYdWQSBd0dbwYMmKjuVOY3LLkbNZIkAcfRJ2bFtDKCiXrR5ylqiJX1TC6LiayGcnwuUqTrX8haKh3R6IxoWDo3tqNceeTqGfn7RoiNFkIGrYyLOZ5b2Qt0UytRp6WfCb7T0zeSHvVePl96HPyUXbInwW/FDbfZ3iXkUwBEyBf15Tu9uxqzFjRzb1aIgP+h5nxIJSpDc2pB4A4X6/anoxYbMqrDj/EuIVzuMs++YM3DSayI8Jjl5EZi4ZiTJsAnBxgeJLtpzPoxKYZKcik0Or/CKRUu2BejKVmH+WJHD2LQmOYb/fbfrBki7SV25/XUa42 X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 20:9xo62NgOJTFymIj8nKn9w2RSeIv250GD7y2tNOvPdxRVV6Bx44A6JDve/xzfLNpJUuSQo61x9G2NNu6/Tyzjs8XCWIBbhlLS1z2itXHb2lwC3PN/f4/eZDtWEYTYQ+8ehbRWt8Trrx8+9lFuF1FhF1iPTrjqW/a4DInwoPnkOZDjp+L9d9AJRT/O7sh3BDhSyzY1r23M9emC0nPIuKBTsEk+NKrULVfm1LjRuBUFoICW/TuTqY95ttfMBUWNfPlDZKBxqPYzRbpe3kQapeYPYXJ9nOqQ+DeCfAqUBpUcozL0kaXvFQru4YbvOaY1NKNJhH/hYwGQ3qrHjtR75/D3ds0qAfKs5LYGRvY5xEmtVfVloOVv+Gj5lzWrovr8DhU3A+rKBbgQW5G8EfVR47uFMcPWu+FewQfv/Xpktc3v8gieEQl0QPaw6jDq3I7A1sj7zTCyChoN2Qo6P2smVnmrIIpTziQWNA2Mv00dVf4tBfCRo4JSJiHU9wBwmKGSVX3k X-Exchange-Antispam-Report-Test: UriScan:(37575265505322)(211171220733660); X-Microsoft-Antispam-PRVS: <AMSPR07MB3106840B6C677E424CF594DEDB80@AMSPR07MB310.eurprd07.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6041248)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AMSPR07MB310; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AMSPR07MB310; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTA7NDoranpTbWQ2ZVFYNGdSUm41UFNMUGNvZ3NaaFNI?= =?utf-8?B?cjNiMjBjRUsrdjFYbEpLdXhPSnlFUi9wS0cvaUIyaXVDM1QvUmVpS090MmFl?= =?utf-8?B?Mnd2anJlZUNpYldpSVg0ODZ1YkJ1cjJBRDUxT3JQUnZNNytGaHhZNUgrY0cr?= =?utf-8?B?RjhYekZJNXpvQk43NVhsZ29VNWQzWjhqYUFubGR1aUhZNkpNQW40ek5sQVlH?= =?utf-8?B?MVNzc2NlUXRGMHJWUVMvNlpXQ3M4VDJNWWdld3RiUFEvSGhVcDVOY1dxckVw?= =?utf-8?B?WmFBMUpKMmN0a3hRUVBkcHlXMm1NbnZtRFdZNi9ESnpFTG5UamFiZ1cxSzQ0?= =?utf-8?B?Q2NTcVI0QWZlbXd5Sm1kWDNmVHNIMGJLaVNpdWFsYVEvZ2RNeE9GQkJaak9U?= =?utf-8?B?R3BMTVRxQXQ5WE9Zbk0xcVhlVERZVEhRaTZ5VUZINDZyK09OWFpYa2NLR3RD?= =?utf-8?B?dE85ajB0czgzYVNOaXp0elovSHpta2d5Y0xaSERHb2FkaTRhV2hyNlZBeEdy?= =?utf-8?B?SU9aVUNyOVBVMjJHWDRqZUVsR28rM2kwaHAwMUMrWDlLVHVuZEVnNTFMM1Nx?= =?utf-8?B?WUkwSStQUWsrZ21zVnBPMFFFSUlrTW5jc1NTRnQrSGNqNGlpQUdCSzNmb0g4?= =?utf-8?B?N2IzbFBMZ1ZENFN6TENsTTVhLytVZk42RVJiTEJOMXJnSUh4eW80WU56N3Y5?= =?utf-8?B?c1ZCTE1tQXFpWHlPUzNXYVh4MU1HZmNvZlFOUUhtY0l3ZUNpanJ3d0pxNUxT?= =?utf-8?B?cVltbmcreURxK2NXUnM3QXg2ZGlOdytqQXZ4QkRVVlpZaGhrdmQyYjdmWGZ6?= =?utf-8?B?SWFnM1dRSmVFR3NUblgvTjNGaHJCNlRFeHMzTm9LdU05bjBSYkh0dVI2Y3Uw?= =?utf-8?B?bm13QjNUOXhMcUwxd0hCS2dqaHB0YlljVURQUjlPNWNjdkpSQlAwYkx0ZDVZ?= =?utf-8?B?YnNlSGpqRG1aVGQ3ZE96VGxWSFRvaFZZckhqRk5FZ25XTk5LaUU2UDNEL0Nl?= =?utf-8?B?Um1DcEtvN1hqdXZ3WlFwMmZEOXR1ZHJadmZMcXJYRlBPOXFoRXBvMnZjT1Zs?= =?utf-8?B?WWpPN0FEKzkwL2NqOHVJN3hlU01MZzVYaFplb3RXRjFyNzhFcXJ6dGFFckdM?= =?utf-8?B?OFAraTcxT1R0WWhIdytJYmcwd0ZEQzdGQWtaUzVDb2ExV1JKUFhIZCt4QWE1?= =?utf-8?B?S1dCZmM0THl5akIrWkpodEp6RzduWDNWVGFmRHREMTdEUitsZlRVVURwZ0ZX?= =?utf-8?B?R3c2SWVPNlJJd1pOUGlabnNPdXBaZjkvOU1sRVN3SGZLNjl5L2MvNmtzOWp1?= =?utf-8?B?OXNvQVJnYkxDczl3R0xvUW1YSTJidFJxVCtvRHJzc2N3UW5OVXdtTXBYVk9h?= =?utf-8?B?U2lha0xlSnovYkxKUXpEeFo4VGswV3Ixbm1vUkRzK1k3cEtUNjZjUzVjSEJ1?= =?utf-8?B?d05ldHZ3QndqcmVwNDM2cU9SajFFWjRxeUwrMFBLUllmbVpZalRLMGgvOW1C?= =?utf-8?B?RTVTaUwvSEVod0ZNVnFtYy9DdXdta2FzS3pKUGdmbE9oS2xWTmt4Nnd1RGRs?= =?utf-8?B?QUFFWmdoTnFHTVdoYkJHWnZ2K01KemVqc3Fsekh4UTRzSllqQVo2V0pVZkpx?= =?utf-8?B?eG5pcFkyL2krQWFJK3dZMldQQkgzZE8zRHRYbzhwTzI5SmNnd1FJUT09?= X-Forefront-PRVS: 03793408BA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(6049001)(39850400002)(39400400002)(39410400002)(39860400002)(39840400002)(39450400003)(377454003)(199003)(377424004)(189002)(24454002)(229853002)(110136004)(81166006)(68736007)(76176999)(81156014)(8676002)(50986999)(38730400002)(54356999)(6246003)(33646002)(64126003)(1411001)(50466002)(106356001)(478600001)(189998001)(53936002)(97736004)(4001350100001)(101416001)(6486002)(83506001)(4326008)(7350300001)(25786009)(49976008)(5660300001)(2906002)(6916009)(6666003)(2950100002)(575784001)(86362001)(65826007)(31696002)(305945005)(65806001)(230700001)(47776003)(65956001)(66066001)(36756003)(7736002)(23676002)(31686004)(105586002)(3846002)(6116002)(53546010)(42186005)(78286005); DIR:OUT; SFP:1101; SCL:1; SRVR:AMSPR07MB310; H:[147.214.129.241]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTA7MjM6d1oyWlVkZWM5VUxiSVRSQTQ5Q1J3WVAveWV1?= =?utf-8?B?eGhrZ204L01vUEhkSnBFZHZkS1cyT0ROQTNBRVZWT1RpZlNNTHhHU01IK250?= =?utf-8?B?d0dsVGxsaTA5Uk1YSzkzRk8wVUIrZ3F4dGpvcjZjV1k3STNualdiUnEzRmNw?= =?utf-8?B?YkpwS255WGZDZStDTWttSjV5Q2dWY0VUVXBYN242bnN5N1pWL1lKRWcvZUpk?= =?utf-8?B?WHg0Q09VZ21IWXR1bk8vMnoxdDc0T21Vb0p5Q0phR1g1UlNRWWoyaTAybmo5?= =?utf-8?B?elZBdWN6aEhRNVZpY1pFQmdaazByRGZPWVhtaDRDUEJuOFgxWkpUUHJZN05p?= =?utf-8?B?MFArWkxyaTVDcENYOFFFbUh1WVI4ZWRKbm1ucGtlV21RK2FHZ25SNVhCSWtF?= =?utf-8?B?d2syYWsxajlRQnE0NDRQTy90eGhBRmgwS0FFUjVpMHBWcWNmYXdId3gzTngx?= =?utf-8?B?S0RiTENlSlVVbkk2dy9jMkJwQi9VU1JLV0NLd3NnK2s1UTl3cXJSY2ROS05M?= =?utf-8?B?M0ViR1N3RUJoeFJzczVSU1lHa0MrS1ZiTWV4OEdIWFBRWG1DbUUwZjJVeW1q?= =?utf-8?B?bFgvenpweTl3dkNFOUV4WUh1OFNRS05ZMm5ZejNjOTd0RlQzTFJKNHNRT0FU?= =?utf-8?B?Wms3ZFdLd1hZMUhMZWV1UEgydm91RGQ5a1dKcWZRSFhreEtnYjdsNEtNK3VG?= =?utf-8?B?RlZOY3BYS3VmcGhqWms5cFFvc3A0NWMycUNCeUVWcFA0RDRONm0rOC9wcnV5?= =?utf-8?B?SW85UWU3Wklka1lCYjFBZ01IRkxHSTJibUNiZHlENEo4Ti9ya3ZSR1NBSWds?= =?utf-8?B?d0RVM3pkWXJyUHFHemJjTzZwVmJEaHdsSjhSbnA4bzZuZXlsb1ljaUpyZ0Nk?= =?utf-8?B?NmpIaERBeTBNQmpLUkt0ZFJvZnBBYjEvR05UNHRIam9CZ1RsZ1RwK1NhRHQ3?= =?utf-8?B?SUVVdWJyeG9kSGJZV2ZhZnVXUTZkTk9pU2RMMWJ0TFVYYTA4TEw4NXYzZWla?= =?utf-8?B?T3pVQVR5cVoyTjNKRTVSOXdTY21qQ3pxL1RRM2lNdWhzaGdhS3MxNG5iNkhS?= =?utf-8?B?Z3ZMN2QrZDBtOHdUcUZKUy9FUWpHdTJTYlpYc0hrMWNCQTR1YU1XVXVWZ3Ux?= =?utf-8?B?amFZTkNpeU1IL0o4dWRvM1J4ajlFWWZraEFjaklQUDdBTzB4YmRFWXNRTzBy?= =?utf-8?B?RGtMdXpIYU0vRXhGaFlvTUVLQzF1cUhFak01aURNR0h4NjIxcE9yVVV5cjdm?= =?utf-8?B?YjVYZTNwNkVIbjBpZ244VnNwbytqRmZqTkJXQ1Q3QjIxWHRQV2VySi9WaWhk?= =?utf-8?B?cm55dVZ6RTJjZVhRTjVGQmRpa3h6MWpuUzI5bUZXNjZ0dUVNTG1GK29UV0dp?= =?utf-8?B?OVFnWGRNVzNHN2NxT21pYk9jV3ZMTVdwbHpxdGNPRHBmNDdqQVVSNHo1T09y?= =?utf-8?B?RzNtL2FFL094Sm5nTFBjRkFlSWs3Ui94bEpnbWljZFYxdERtS05md1p1ZTBp?= =?utf-8?B?L2tiRFpZOFE5RGFNdEtMMERmMnhtN29wd05BZTlHRkJoTnVmckFYdUxJNmhY?= =?utf-8?B?TEtDcExrWVg4WE93N29Na1dSdkpsakxiekVTN0pjd0h4b3FFSDcxQXJDNXFI?= =?utf-8?B?L3M1a1lIQkZmUHFNT0VzUHh4aUl1d005OHpPMStqQlBFdW5zU2pPcmpYZ1Bh?= =?utf-8?B?L09rdUYyeHdiZG5Ld3Q2S1pJSSs3Yi8xcjdEcnB0eDRuTThka2FDc1oza0NC?= =?utf-8?B?b3hMK0xKNkxaRW5FTkJmOEVBMkl4YzB4QndHMUczMll1ank0RGRhRW1QUnFv?= =?utf-8?B?b2Z2K1RKTURic2RDQitWL20xN3ltUkpnNGpMZWUxYTcyaGI4WjZiOWlveXZF?= =?utf-8?B?cHlPTGNTZ1I0R1lpYmdvdTEzRXdIRUlyTHcyWjZTemU2MW1YRFppODNTdUZZ?= =?utf-8?B?aUMrcCtKYU5OcFpiaE5haExMY1lPaER0SVpLL3ZKS2pVNWVtUVdTakNKcEZo?= =?utf-8?B?NlUzZEcwUFgrbXVYZzdSOStINEE1SzZPaGN3K3YvOWRBeTExQ3lnMjJPc1NH?= =?utf-8?B?T0hNenRqaEJkYXpmM2YwcU4zUjhNU1krOFdYTFN4Q2tMR0EvcFVJTWtPWlY3?= =?utf-8?B?MXQwdEk0b2dQT014U0ZEdzkrNGsrNy85Yk55S0NmT2tQTEIxaUFNdzFiWnJL?= =?utf-8?Q?YlxHf3tClMT8CTzGS2wjczo9pcbQmIbo5evBy6+f4=3D?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTA7NjpmUUtuM1FzakNSbVNqWkNWenJIRlNKZ0ovV1N2?= =?utf-8?B?c3lQTUc4clVkVEpJS0pNYk92MFZsYXI5dmt1aGlsb29YMU4zYk5qU2ZQUDhH?= =?utf-8?B?NXRVeFVvaDI3SXU4YVQ2dlNuNU1mbE8xYmNmcWlxQ2lvYmVGRnRoSkZrNTRD?= =?utf-8?B?ZFNRZFArQ2NlaUdNaFlQYXdqU3BwUy9seUpKU0k4M2hCc0svdXVFcEhhNlQ5?= =?utf-8?B?RXdicVlPUUZERDVYOWMxNHB3WHE1MzJmWnY1UTZsdVpORHJ1UDBmVGZiQUhr?= =?utf-8?B?VktvcndoVnNUMjZpOFZJbzZ6Q2g1UWFQa00xak1iKzRGUFpienFNZ3hHaEE2?= =?utf-8?B?WVVycHE5dXJSS2hiMUVFR2g1STZlTGw0amd0aXFzQm9vUEF4WjFOQlkzSFoy?= =?utf-8?B?R0JzbGxpd1BTaWtvR0JKRUZXSGRjd1NlTHdXbW5hUFJUalhvZnhhWGc2UjBT?= =?utf-8?B?ZGt5RUVMcnFrbTVMYXl5M2JnTm5vcmN5K1JNTTRETW5oTWIyelBqNW1KcHNW?= =?utf-8?B?ZFRDeUxRUU1HTEkyN2I3dkoxZWVacldSRnFObG5sU3BqRnN4Q1drK0JOcGl4?= =?utf-8?B?SUNCS0NhMVplV1ZqZGJnK2x4S24ybFk4M2VHNmhhRytGM3I5cGpaTE9iRHl5?= =?utf-8?B?ZjBnRzQyOU8zTDdBUWUxN015SDFZR2w2bERwVS9qRUNXRFVxWTB2MmdjeE8z?= =?utf-8?B?THViWis0SUc2QWd3MndScmNFNmd4ek1RWWpTRThHWE1BWFZtd1F6WWl1QTda?= =?utf-8?B?SHIxMjFGRm9YL3lpeEltUkdZUS95Z2M5Z1dTMUQ5L1pHSWdxcTJKQkRGOEVa?= =?utf-8?B?akFyYkFWWXRoUlhDNE9SWXRia3ZMYUZJRE1yZmllRkNXT3hIWmtDa2ljQzJE?= =?utf-8?B?WHkwMkY4Z0JWMVBHam9GWHVIUFplVUh5ZTJZajVHMis0Z0dweHRDYUMxNTYz?= =?utf-8?B?WUZJMmIxalRhcHpudUNGelFvSzJESWpuczA1Q1FKYkVkNjNwK2R4cTdrZ3Nx?= =?utf-8?B?cWlqdDdYcDBlMHNVMTl4WndxbVA4WVhETGRjeDRUYlJqTkJSdkxHK21ZbHFz?= =?utf-8?B?WTM1anZNZzE1Vk95dDZEQzdjZXY5VEdlRXJWdVNteVZWUkkyclNzYVE0SHIw?= =?utf-8?B?YVdjNGo0TDlEd0tlcVgzM3VCL1p5ZVFkRXVqQXBoYXdId2J6NkNPYnVZL0ZW?= =?utf-8?B?NUwwdTEwejhVQktiTmg2ejF2cDIwdXgxOUZRV0tKU0xYcEN4VmtISTBacjh4?= =?utf-8?B?Z2E2S01MT1lMRTQrdy9WUTV6WVdRU0I0TDhnd3F3QVhHVkZFZklCS3BXVUw3?= =?utf-8?Q?ZhHSNc7EYswJu8gDFSjnQL4NvzJ1vM=3D?= X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 5:HvmiiN8J4PvoEFIz76l7PEiQr8Lvu6TwevLOee5TkbRNbt1QRgIM6ql6dd8DxbFQ1xAgskAA1OsgR3BmDib3so2BjOqcecbnqoD4dkQKkttuZ+eGfoXJY3ZgDaB5ixDiS8Rfuwta5K7rldHxrW13DWjSDL/H+lp//xMtrmpXpt1zOos2cbKf6dSBhI55aTtGofiPCNoOHknkm4wssEAANV7tVaPN9IJEqv2kBcdKCH3WjZ5RpKq6possJnylu569FF3SxDQsWaSKsSy6L7tC7MFZ409zLzjYPVqlBbdKDD6bYOAvv6WxhOwqnbQe0WlVNoZwX9+SrHvN6k/T7KQvU0EuxGdCV7/0GGnrpGEqKFskSNWOAnfLmO+/KS0esWs8BrniZoJumnfkXKfkGSrrmIoTjHwzCOLYATMqRVsW2l6B5TnKtaoZRNydFZCqMkS/jB0pnp2AlGmS/IvMZBGrVRbhvAh4Brv77tvREGG4wIabaSRpxsRzogY4igsNgy1F; 24:T3v44A9ShGB8s5eXLLU5YqkDOfd0tbnoE9vspavHGyVDMvaYjh6VgpDT08NxBmSyLRQeNkZUjreH5s7+hhtSxupuHBausmm+rxsFaHWj7uM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 7:3ow4Uisq8z+dChAtVh2+vt0DpvmdU2xHPE4Qw6KWLhl/n+aUpNIAxSZCm0Aht+sLSHV40HCWpsn2BHR2gNCjyDihy6jX8n0OQahhCBAaLi65g4oy/mv8UVM8hC3Gi4JyXzFUYH9Q9ee+/aoboCqJp4FgtsU8+eoT5X6iluHfNaFp5iYQRaDtoHZXgOavjUdVTdhfiGDbyNcvOMQhm2HSAzacypArJ+E1z98nRgUqxtsWHBweXXikR7RgPHNkOYQm1FloywJcO7H2v+hJ2a9Ld4TK8HIUh/EUCWP7pUVZUwIJRaaQcsQpsA/QoHPRDdpEhm/kD6SL3NsNXoWkAEVORhobud/gghWUmvIslzIS4iSpI9F9zO1l1jD3W40u1pN4NgJh5m26i8ub8APRs2RBbCXm+wRdgFG+03nObcuoJBxhBnpRn+9A1OOBjhlRehrufbaWTTBYEFNdx68hSxtohPpZpvU+RMXqmr4wuEKR+ZjqKUXIZgd683joBINCh9V3bewQQzClhsSoUzsRgzXhRLWUSiwYRYt16wXonjkeLF5jI4hIQqdflFOwnaw1Uv7YxMhbc/BaQKt+SSEJSQ7jOzeGCs4mEs74KHVeGzv7ILs/UUXa8cC0sw6SoJfp9wAWjD1q2sdy5cOvlS0UfcMAhxa2OQYoXbmMgcqkyp0bRLpcsyzYDBdE9eiQKfg+ETl3ItLJfMiy06M/VW5NCP1Hc3vWkuZDf3rTCHbG6LxZ8NtT6k/oY4GGHiZ6EjkektUwXyudkYGIYyz9yeK2iVqYPx/xFrpaceWlXjBGLlTUVLo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2017 10:19:25.9484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB310 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes |
Commit Message
Simon Marchi
July 25, 2017, 10:19 a.m. UTC
On 2017-07-25 11:58 AM, Yao Qi wrote: > Simon Marchi <simon.marchi@ericsson.com> writes: > >> @@ -3480,7 +3476,7 @@ linux_wait_1 (ptid_t ptid, >> event_child->collecting_fast_tracepoint >> = linux_fast_tracepoint_collecting (event_child, NULL); >> >> - if (event_child->collecting_fast_tracepoint != 1) >> + if (!event_child->collecting_fast_tracepoint) >> { >> /* No longer need this breakpoint. */ >> if (event_child->exit_jump_pad_bkpt != NULL) > > linux_fast_tracepoint_collecting doesn't return boolean, it returns 0, 1 > and 2. See comments in tracepoint.c:fast_tracepoint_collecting. Oh, thanks for noticing this! I think I've been misguided be the comment on linux_fast_tracepoint_collecting that says "true": /* Convenience wrapper. Returns true if LWP is presently collecting a fast tracepoint. */ static int linux_fast_tracepoint_collecting (struct lwp_info *lwp, struct fast_tpoint_collect_status *status) Maybe we should make it return an enum so it's clear, because the function name really sounds like it would return a bool. Here's the a fixup to this patch that restores the original code: From 61b9c0b842ef8ecddd0ef8a1be12676d6f9e61ba Mon Sep 17 00:00:00 2001 From: Simon Marchi <simon.marchi@ericsson.com> Date: Tue, 25 Jul 2017 12:15:33 +0200 Subject: [PATCH] fixup fast_tracepoint_collecting does not return bool --- gdb/gdbserver/linux-low.c | 8 ++++---- gdb/gdbserver/linux-low.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)
Comments
Simon Marchi <simon.marchi@ericsson.com> writes: > Oh, thanks for noticing this! I think I've been misguided be the comment on > linux_fast_tracepoint_collecting that says "true": > > /* Convenience wrapper. Returns true if LWP is presently collecting a > fast tracepoint. */ > > static int > linux_fast_tracepoint_collecting (struct lwp_info *lwp, > struct fast_tpoint_collect_status *status) > > Maybe we should make it return an enum so it's clear, because the function name > really sounds like it would return a bool. > Agreed. The comments to lwp_info.collecting_fast_tracepoint should be updated as well. > > Here's the a fixup to this patch that restores the original code: The patch this fixup is good to me.
diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index e650b0d..ab3e860 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -2177,7 +2177,7 @@ maybe_move_out_of_jump_pad (struct lwp_info *lwp, int *wstat) reporting to GDB. Otherwise, it's an IPA lib bug: just report the signal to GDB, and pray for the best. */ - lwp->collecting_fast_tracepoint = false; + lwp->collecting_fast_tracepoint = 0; if (r != 0 && (status.adjusted_insn_addr <= lwp->stop_pc @@ -3476,7 +3476,7 @@ linux_wait_1 (ptid_t ptid, event_child->collecting_fast_tracepoint = linux_fast_tracepoint_collecting (event_child, NULL); - if (!event_child->collecting_fast_tracepoint) + if (event_child->collecting_fast_tracepoint != 1) { /* No longer need this breakpoint. */ if (event_child->exit_jump_pad_bkpt != NULL) @@ -3503,7 +3503,7 @@ linux_wait_1 (ptid_t ptid, } } - if (!event_child->collecting_fast_tracepoint) + if (event_child->collecting_fast_tracepoint == 0) { if (debug_threads) debug_printf ("fast tracepoint finished " @@ -5290,7 +5290,7 @@ proceed_one_lwp (struct inferior_list_entry *entry, void *except) if (thread->last_resume_kind == resume_stop && lwp->pending_signals_to_report == NULL - && !lwp->collecting_fast_tracepoint) + && lwp->collecting_fast_tracepoint == 0) { /* We haven't reported this LWP as stopped yet (otherwise, the last_status.kind check above would catch it, and we wouldn't diff --git a/gdb/gdbserver/linux-low.h b/gdb/gdbserver/linux-low.h index dcc9315..f93aefb 100644 --- a/gdb/gdbserver/linux-low.h +++ b/gdb/gdbserver/linux-low.h @@ -358,7 +358,7 @@ struct lwp_info return to the jump pad. Normally, we won't care about this, but we will if a signal arrives to this lwp while it is collecting. */ - bool collecting_fast_tracepoint = false; + int collecting_fast_tracepoint = 0; /* If this is non-zero, it points to a chain of signals which need to be reported to GDB. These were deferred because the thread