From patchwork Wed Jul 19 20:14:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 21690 Received: (qmail 105264 invoked by alias); 19 Jul 2017 20:14:19 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 105144 invoked by uid 89); 19 Jul 2017 20:14:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: camailhost.cavium.com Date: Wed, 19 Jul 2017 13:14:06 -0700 From: Steve Ellcey Message-Id: <201707192014.v6JKE6JV001711@sellcey-dt.caveonetworks.com> To: libc-alpha@sourceware.org Subject: [Patch] Fix localedata test builds with latest GCC Cc: zackw@panix.com Reply-To: sellcey@cavium.com While testing the latest glibc sources with the latest (ToT) GCC, I ran into some build failures (during testing, not during the glibc build). This patch fixes the build failures in the localedata subdirectory. I believe these started failing with this GCC patch: https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00537.html It does not look like older GCC's complain about not understanding this option so there does not seem to be any need to conditionalize its usage. Ok to checkin? Steve Ellcey sellcey@cavium.com 2017-07-19 Steve Ellcey * localedata/Makefile (CFLAGS-tst_iswalnum.c, CFLAGS-tst_iswalpha.c CFLAGS-tst_iswcntrl.c, CFLAGS-tst_iswdigit.c, CFLAGS-tst_iswgraph.c, CFLAGS-tst_iswlower.c, CFLAGS-tst_iswprint.c, CFLAGS-tst_iswpunct.c, CFLAGS-tst_iswspace.c, CFLAGS-tst_iswupper.c, CFLAGS-tst_iswxdigit.c, CFLAGS-tst_towlower.c, CFLAGS-tst_towupper.c): New macros. diff --git a/localedata/Makefile b/localedata/Makefile index 47ca39d..20c5921 100644 --- a/localedata/Makefile +++ b/localedata/Makefile @@ -122,6 +122,21 @@ $(inst_i18ndir)/charmaps/%.gz: charmaps/% $(+force) # Install the locale source files in the appropriate directory. $(inst_i18ndir)/locales/%: locales/% $(+force); $(do-install) +# These tests use multistatement macros from tests-mbwc/tst_funcs.h +# and will not compile with GCC 8.1 without the warning turned off. +CFLAGS-tst_iswalnum.c = -Wno-multistatement-macros +CFLAGS-tst_iswalpha.c = -Wno-multistatement-macros +CFLAGS-tst_iswcntrl.c = -Wno-multistatement-macros +CFLAGS-tst_iswdigit.c = -Wno-multistatement-macros +CFLAGS-tst_iswgraph.c = -Wno-multistatement-macros +CFLAGS-tst_iswlower.c = -Wno-multistatement-macros +CFLAGS-tst_iswprint.c = -Wno-multistatement-macros +CFLAGS-tst_iswpunct.c = -Wno-multistatement-macros +CFLAGS-tst_iswspace.c = -Wno-multistatement-macros +CFLAGS-tst_iswupper.c = -Wno-multistatement-macros +CFLAGS-tst_iswxdigit.c = -Wno-multistatement-macros +CFLAGS-tst_towlower.c = -Wno-multistatement-macros +CFLAGS-tst_towupper.c = -Wno-multistatement-macros ifeq ($(run-built-tests),yes) generated-dirs += $(LOCALES)