Message ID | 59662DA4.1000702@arm.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 12235 invoked by alias); 12 Jul 2017 14:09:48 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 12184 invoked by uid 89); 12 Jul 2017 14:09:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:104.47.1, 989 X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none; linaro.org; dmarc=none action=none header.from=arm.com; Message-ID: <59662DA4.1000702@arm.com> Date: Wed, 12 Jul 2017 15:09:40 +0100 From: Szabolcs Nagy <szabolcs.nagy@arm.com> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: GNU C Library <libc-alpha@sourceware.org> CC: nd@arm.com, Florian Weimer <fweimer@redhat.com>, Adhemerval Zanella <adhemerval.zanella@linaro.org> Subject: [PATCH] Disable single thread optimization for open_memstream Content-Type: multipart/mixed; boundary="------------070703090909070205010503" X-ClientProxiedBy: AM5PR06CA0017.eurprd06.prod.outlook.com (2603:10a6:206:2::30) To DB6PR0802MB2486.eurprd08.prod.outlook.com (2603:10a6:4:a0::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 91487125-bd39-4603-ee04-08d4c92fa48f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(48565401081)(49563074)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB6PR0802MB2486; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0802MB2486; 3:NA3vWKd7FKbg4tFe3JvN5tPJy4psQEGy+yLdxyelhsAqDbxYzjo3L2ddLJmdDVlOPHSD2xXBv8/LxFfghCAm2ejqeoWfyn8GF0gP0hjJ4X0pFrOO2WBOyqq+ucmrcSimnMi5R/+Ilm9pci8zmIjxpnLtAXn6BnC7ueu6yLaUPXgQv6mymHjj4Fl6WIIui/AOT8WavhOnIF+1YsMrNC8B2DyHm5paGn7mBdJbEPWNXpEtmwGPajlYoSdlOOvopgJfcNMGV3ciVRAnH8dnJi/lNHeZatpvyV/AN7C8fM+E7HRzq/ntY5GuQhueA0PsmP9z5qxnKyv/lY2kZp50BHGLD2GvasMUjQQq3Vq/LKvCiSf0052fefto3GSEgVu/W/gGUK/HgNHBBIxgsI8MGqS/18CFK+91V4ok+MThml5k57XcT+4Vz9gvlCsMZp85LSDREB/3F7nXbpydQgjJpWHlTJtcflCFOSHl1t8AQ3hwz10bbaL2sPKVFN/Ky1Se0LX+oxinBo/wDHyyfknMiSNAA7iBUwdTxn5OPhqmcUPmFHW6G7ooNjZ7bSMZg74anrFvCb44iZ+DQv9MB7BdTozke3cLGy4lWoPpINx8XpHVRvYDn8mJ6KAnlh8s3L3pP845KG6pXiyh6TwPsH+HQEBWo9etXhl+ILSaW6In+2ThHSQ3VXGB0Ljit7pmwWhI1AZpx6reC78QCUROo1S1GpzN6hJyYozBfHxoJAIHfYFhnvQvKRyodju+kE39ffdMIqR76PLq7vWtDpmOh2r3lQTvcwkc/hp/CZ6uARp6gNv5rY0= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2486: X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0802MB2486; 25:LHvBGh/8DByoQ4IzS/dkqS18gpy+KCvNBPuC2zB?= =?us-ascii?Q?LJ/9Uuqsth6j2zqc6ilqXs5B8/vH9NwmXWish69wVdpI9/gyEKx4dy114Wyf?= =?us-ascii?Q?Rxl/rVVc2GD+7ChCflOV6dLzhqMQQgN9ShY9n4Uz281yx94kGJNPEC3mMl8c?= =?us-ascii?Q?//5flAW/muXIVzgEEG1xiOyZdB7rY0u47Kyvdeh1Cgrl3dXcXktdWgdy47MO?= =?us-ascii?Q?3n6jNkWeIW/4q0rkD7vErw1A3tCzlQmuK/s8/pr01oUgSY24ig/ji6hgD3Pu?= =?us-ascii?Q?lWHm4l4DRGefFYV1yZysgd19ItyykZHib4tekyznwW1xIZM/9u+b6JbzfxlC?= =?us-ascii?Q?uBMJgWJ+vlBXmY/X7yrYZGdq8AGnWNwzmYL30dbamXQ/XNcy84QeT9F1zwkW?= =?us-ascii?Q?Azek5HnmmaW6N/rwda6HsBkOt9VsXaExuVQ861WZklAUyz0Sbowoj5JDrEpY?= =?us-ascii?Q?iSZYbUXbmljrmizIJhyObv1WD+2+t10OwNnztBO+NK1d80wTjXo5i64bMdUU?= =?us-ascii?Q?IzNhxMdvcOT6MzaPXtxZj0vRpk9GGPCTdCCOPs0eENFJx08j+8eraJ7fKczw?= =?us-ascii?Q?RErP43Z9CQHG0D3gw99n9Ia5tH78FzCXk5tiuu02lY3+Z0O8IZHzyihBByab?= =?us-ascii?Q?/CNmDeuQ2V4Kzn3MO+sEocH2Zu0YDHQ3g7unKr/71PFM3+8rjxG7abSWlwNZ?= =?us-ascii?Q?7TeoUK8IQJbkD/IXM5iDwl5mqXwn3Y7mtTP2qg8PwUvpzI8rj4NdOdzNYpPt?= =?us-ascii?Q?P+WgKj4TcpGZVpCKB8CUwsjtNHgk/galWeFnJqJKRBQt9Ys7zXghWq5Rm+cA?= =?us-ascii?Q?plPf7Z4LV0rxBU2Qg7g4Tl7ganHXT6tgQQRGpLZhl9IsE4cn9oYIeXg1enM9?= =?us-ascii?Q?WYhowY6bmISKkgTsglslQu+97GcGPOnt/NDS5K1yczUT3vPJHeD+FAoR9vRv?= =?us-ascii?Q?V4AWLMMustZWv4CmVOgXDmg5b9E9f8R+b1iiBAsxcpg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0802MB2486; 31:oYmsF82eEaclX/4yTeLh0vPxUSMu7TilUq0hfwS+qQ+5a/bBuTLjeSdTxbfCsvif8BVaWhGHzel0LXf8GKGlb3gzPfpe2eY+pTnomEiWLNx22l2sU3Cuk32ylNRPlzntCeC3gr2wUGxF9FIqzD4hd2P7rdkuMC/OAlY1DRRPrEZcB3kS2+T/kIU17x5QvrJFqvhjYvWP2150RMLZATw0qbpEaEPxXA7UW+oZOJCOBJQwSrTRcicpTHwXsVHZ1YqQw3FJ9WV5bd12AQnRVgItPAq+hk/dZJLpTTsg/b1eRzyQ70Tao1sId0MdDZe4yRqLGiroF6XEkTQT6Hz74aB5Hf7bb6BEI5fSuPg0KVIZgNwGXbv9NjyTU0i53h0yrpq/xS+XbWir3/12hNmbUGdeuDmStHHvN6EX2G6ei6hoI0voCRD1n9I8nh4PHfb/5JqQSBrBHGSoHu3knfrA2AVWaaJwLpY55cmST8JW81SluGWeVdU0sfd93AM9+zYHDfSEYsIpGtbTQ7WGQnoLhurKLNw0J7KulAKbxTZZ0wMypmOWK7mTr3Yc6OkY1P8LfrkDIdkj4rVITFc9F4IqmukrPxT1oLr139TFHfhpl5qioqHXVlMZF+1w59K4IMKvt3zAJRt/3SABzMwZP6goyKLYDzNxWyy0Esnm7zxgAIsHNXTI7HtLNJMxqcmm5JwnPG62gE4j4p6PInJUa3x/g8kSww==; 20:0EncJe8vIT1IRCWjzUewjkrG6GZrK67Kt35bak69luds9jI6MZotYsDlNjvLlI4UWpZxxUrq1trEG9C7IQvpShrW2S3bVTvG5YnAYPECMQDi1R7RdRF+7KlVp+RwPneZkQj0+6Wzhx5tAdMgSU110hAst/KaaxaRWN7qHYr2TdA= NoDisclaimer: True X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(236129657087228); X-Microsoft-Antispam-PRVS: <DB6PR0802MB24865E1A7443915B65B9D9D2EDAF0@DB6PR0802MB2486.eurprd08.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(102415395)(6040450)(601004)(2401047)(2017060910075)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0802MB2486; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0802MB2486; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0802MB2486; 4:G/xvFOLo302FIRdqc4vi2Rz8iXakw7aw5sFkBdKa?= =?us-ascii?Q?G9xbxhr0dxCUiZnE/Io9l8hQM280aMbRRBFMV01pSwIlVPmKDNiX04r3V93y?= =?us-ascii?Q?T98i9NjgogdqptBr8M2JRnA7lBsVlp92j6cOPKiLoRV0ntqzLy/Nqjv6mro2?= =?us-ascii?Q?M9RJ5V2WlhF3w403vcbnqL5A1tdBYM2edu7PFJ8NoE+SW5N9Vu+iP+PgyD6d?= =?us-ascii?Q?gPdOFJlAIHdOcwjq8FZ/FwsWtQBx2PHt5kPt0Nmkf2XqLu4qQSGtQqMmm4fp?= =?us-ascii?Q?QKDP/c6sisyXXCQ6j3mAJv5LVDGybs7qZkrwcxeiJCS2xAnqPHAlw2RQouym?= =?us-ascii?Q?h1fSiXQhksrYs4Gfisvbb52RWm7OIuERAJj09xSPJblAHyySNTdDUAjA08xG?= =?us-ascii?Q?rL+VNFSoguikksrDECsMNjgtUrEKAG8UUn/R7DvXpCPPe0o/yQbydb/yS+UP?= =?us-ascii?Q?rRqT1TgEbGApFYHVweCyOhXVtru04KpMIh7/Fj1S/XnpJccuiAakk7RaqlyJ?= =?us-ascii?Q?771dHbz/zQvHHeByxEwg8oC2cU+fmp5CWWluG3FcFm5I4EqutWAeMFmIafIc?= =?us-ascii?Q?vSOoUsUTrRbMnJYb4fVqetmVbSwXLTkDNlCAoNy2ii7l32RnHj2DGEspgLFr?= =?us-ascii?Q?ninls7JSqPf4jO+a6rivxIITv0geLTbiYFCTzSuN5tP7kTqX0DJor5TFlJn+?= =?us-ascii?Q?mmBL/8AtaE3Hj6iUEjuqwJpDVb0kdSTrG3t6YYz5PsKRHMKsxupMAkNJFCU+?= =?us-ascii?Q?SyOonuyyAzqMrLzUeGKmwS6v7vLP0+buaHnhPY6ZxY1CswapaujhFjJoCe4r?= =?us-ascii?Q?IsKO/OKYgKBYjIR1Y7sc5BYgeO2SkTaACwYDsSlqwJ1pYuNMa7SIY6WCRAE3?= =?us-ascii?Q?/YSPTykIrqJZJOul3iSc5wbqG3Gm1T4i7uWEj3ngR7taFHg5MJZXW9qUjeAd?= =?us-ascii?Q?NnXXVPPDj6pwPSu7o8tGp0IIj5mwKYf2uOJk9fQGdyysozba72S5euEgFDwX?= =?us-ascii?Q?nb3QiI875hZR8AOracs5PO3JIk8eMlkSO+pLSdWOaTJixaJsogAdHMOJaImx?= =?us-ascii?Q?/NO7KFxrYiM1FZp4yI67ANaj3wT9YlQvCzvnpvhbVpRgPuh24cXsCcK7bACP?= =?us-ascii?Q?C59kQf95dR80hrd1zzQwORUvgEonSHx4D834OJZlJi9yVQ/ewBw/noMoFUVK?= =?us-ascii?Q?NePZS+UVVGhHZETI8cSmqRWuuPiqxaoq8ihikSazCXFaES49SI3/SPRBlSDD?= =?us-ascii?Q?9EA6M2USJU7cDBNCpA47EeWwYOYNxCNjl+Yxmcz8QC/R1K5V7gmsuhIYUzgp?= =?us-ascii?Q?Ow=3D=3D?= X-Forefront-PRVS: 036614DD9C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6049001)(6009001)(39860400002)(39450400003)(39410400002)(39400400002)(39850400002)(39840400002)(377424004)(5660300001)(478600001)(6916009)(72206003)(4610100001)(21490400002)(83506001)(4001350100001)(6486002)(77096006)(86362001)(7350300001)(5000100001)(7736002)(80316001)(84326002)(305945005)(36756003)(3846002)(6116002)(110136004)(2476003)(53936002)(38730400002)(42186005)(81166006)(4326008)(5890100001)(8676002)(568964002)(270700001)(189998001)(66066001)(33656002)(99136001)(64126003)(2906002)(25786009)(50986999)(54906002)(65816999)(54356999)(87266999); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0802MB2486; H:[10.2.206.69]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0802MB2486; 23:+GIyirnPGn8x1Oz+oQ8OCPuO2+BNnRWd1F5JEuj?= =?us-ascii?Q?zv37BRCog+4DOt4s+dhSef1lvSwSg9mVWJeTQcEtnBfu1VQCI8X8Ahb+AnXe?= =?us-ascii?Q?jZD3XNujJotiQRaz5nDKhkfwjFdJMIRVxurukftFVUg09DPR/p0WT+o1V7H6?= =?us-ascii?Q?rEHd5dS+kvq8zWwYsFHTKQQ6OF9GZuwl0wDBXxi81Ei24g6nGprN1jV8CHaA?= =?us-ascii?Q?7yaEr0kBdiJjLb6maauLmq+BfcMlDGrs/d9hVhVB8mt6+PzXCh1jGzU66M8/?= =?us-ascii?Q?AmtOyanLi7RXBJ+4zZCrWTD25+ex0ddsuBw1dvqXPLHatJBMm+dElnfPuICB?= =?us-ascii?Q?rMrrlqx1UMwwtwRgeNSsbw0VQo5LkSaaOupB9pq8tUNQAIwkMCDlLiyIT6BF?= =?us-ascii?Q?KW3gE4v6+2e02y3ZGAM5VoTmL2OwCwtbtjFsI61QtiXwk4bvzz95Nu6BFcw0?= =?us-ascii?Q?pGpFRhFISxPHzuFTed5zeZEzYYaCP56iponbQa/dngMnOg3WaNA6LklnlpuI?= =?us-ascii?Q?4ceizHEtJwmJxeYgIA+Kz/t5n95RwiXOSFb3K6fzYx/P24icBGueGpIfJ/QH?= =?us-ascii?Q?pRAl3xeON0Jxjvqq4ybiWaKTlT0ArGu786hevMqg3dcFzmbqg89a8f8Dm0QM?= =?us-ascii?Q?YJvP+JZ1etnaU/KyJkXdHUdJ2Y3D1joKfLdHgBw+Dguv2M9DvKUot05hlEgk?= =?us-ascii?Q?xvLK3PZ13MNDTvZnb9ZRDO1gAy46SlHlIJX4XkulXS17v5l2LoTdZxrQTsfN?= =?us-ascii?Q?n1XWrYmf6QWKesvYKRmKHkSbuCRJUMq7abAKSVEsgIxdvmXey0UFTZ/Nu/f4?= =?us-ascii?Q?w514SVWamdHVhrn9VzgGXXgCOAkP+xcywizaiCVI6J86bG13q1rSXNroK1WN?= =?us-ascii?Q?LG6CHXwk0cfN8uA97QE0BXSJnYdx4dTzdcgG4UjFByyoKNNRpsFXNuJXwG+x?= =?us-ascii?Q?O0b7T7R14aROe42Iy2zvxGiOQjWChoMoIvcb5sG+Grl8paayuHaw9toJi3Ac?= =?us-ascii?Q?txi9DpO2BJhycbQu9s+C4i4RwmDCTTngAnCz3Hbuj45b6gcfz25lvcyNN3FP?= =?us-ascii?Q?u/R9dpjearG/ylxd9WhAfjWzRNpDMQ58H84emqqkxoat4vr0s6M06CsALS+C?= =?us-ascii?Q?yDrxHm/reeawgg0LbCol94Jqo8i6CwE0IKXVTZnt6WJ53tjc1g4IQb1f3UFP?= =?us-ascii?Q?vvdIq2GuhS+KUZ2OQ42EU/jVC/sV8/36rHR/xlEs94pN9Q/c2imSA3nSQ11l?= =?us-ascii?Q?btbgCqw/nI3k4W6JsB5HYGJhU5lBgAB1R6M38Bqpeo/sNVe/K6G+O5/AuDO4?= =?us-ascii?Q?qOpVmYDFIxhaCMZfY7/WO532SXyPLP3VMlFy8I2x8atkKnpFzEeDFX7EEuvk?= =?us-ascii?Q?u2qoswjeS6iUbmDt4CfkRDdBFuSE=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0802MB2486; 6:tTU3wbeKRdYBu0yfXHeJlWirnCETYOCbuUiKAbeU?= =?us-ascii?Q?jKODyHdNT8fQH4TUDnoPGid9MZPzetjZSPLO/OFlCzeWCSLILxb39nEF2h+Q?= =?us-ascii?Q?DaLVrrYLUZujSBYmheNibanXIc8alRXmJ03dyCJmUxAq5INe2u9RhG4mJpxf?= =?us-ascii?Q?z6t6o8oWVOz+rucjCOB04ap61EJwUMFeAHZaQsDCBnjkAUsmncKf5XIrH61S?= =?us-ascii?Q?gXHmKyaI5qiu95LIiLYd7SDEywBbUI7OpZ3tqWRDINathyT8uaJ501SjjHb5?= =?us-ascii?Q?FJANZggEhzSUFFh5B+bq6iL3E1O15uN4V6/NLB7vu1UypES625jmeqFgKdZC?= =?us-ascii?Q?pYpBSzLYo4caNmIF+QMsde+QmnwV4kavXx6MqMpo8/yNvy6RZAJt5jGqQQfu?= =?us-ascii?Q?3CyCiM3yAoY7EufWJuEYhWvHBLHRwhP8j1BRzyTz6YK7OOGWJsZcCW3Nvxep?= =?us-ascii?Q?DGufOcW3rkMnuOPAMBoimVaiBPAUCpFwqHCqv+R3nKpyKuQX9aXzF+pxRUaH?= =?us-ascii?Q?trG5ubXQgWx/ECgeE2+KV1Dbq2nSHEgWRMlA2hT3iSm087QZAxJ/Lgl0AL4f?= =?us-ascii?Q?oBIV0tykK/03qI339kyW5rRHoD1HYkDFKKrtUpl+jgEaKyTRhb8BhUzl4Avc?= =?us-ascii?Q?g+q8Y+182FfnxBix1GJ0VLfo3ynO7KX3DOgc7Dv/m0zDtUw3YHdhPkm2QjYr?= =?us-ascii?Q?D4NfArUb7Rk0/sCjo1N9V/0b/Jx1bx0VsIhGSlOfdoZktUU5E+Hw+03Tw3Po?= =?us-ascii?Q?bCxZGLZrhhSZUdCNvOXA8CXH3oRnV5VKQPKtH63m9Uk8nkH/7mZus+DoxETN?= =?us-ascii?Q?hzjVJ5ChglHPCmTvKT7L9fnq5Qk9FaAQDpTcZsisT2ufBORbQps7fgaEJp3x?= =?us-ascii?Q?knjzSBtOPuMAUhlea42rEUQb1J/oigdhCa+nJW2irDnrOur451FqIzNbrFl5?= =?us-ascii?Q?d+WRgEO4q5TStWiiLv3CdoD5xdpHUTJmDTL1DZkp9Jr4Ew6+w9osd8E2W/DF?= =?us-ascii?Q?dwnPtMxHd8DMjgy0Qyt0C1Gu?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0802MB2486; 5:ynMQiOnO0KHnl3lxwf4IuACTNa9bAUc8aFFvQLRhleAWjtYCa1MPwjbiWUsU/xw51d6rUqCeJQrpYW63v0WZInWNjaDYB+HZMKrUzrFBc1L+LiqMhB+e/dqIx1VQk2L39usB9xxwcMC28HRuQwg1rlhxZKTDP0Z8V531vzqwzNLFDgtMXJdkQv8qyP0rthEXTEx9a7oCEmv1NcuK7YxS2ikcBQuzsmhQGXMqCJHuefCL2TRvitMOAz8WYos1fF7uJzZCvCDQZuG7l4N+/R6bm4fkCZbtAKYm9qLcfEXgMdDnbau498hRP36Iu1+gYiIzGhE1QeXdhjE1AFU4ObH/ij3g1Vsl7sbOrQAsFz3C26VXOCvEBypUQlLRQggh2dGDXv8J3UMAl5U7thLWDSOnzJpBhQLtsCJynl4DpmjU3aHhKzNigeFUEQ2G3nOXafKIaqG/q/0edWu8bfg/oUdK0wlNfnGH5L6pfLqcMRdKZCnMneba4nGDWhLPZ7yxLydi; 24:L+cIhFSd91P7n13ruE6wkOV45eK0FYwav+zCRB2K6OVypqrXYkzTwqogMi2uauHFX+h24IkQIeUZu4AMiJcUXnIiNGEyjE8Xer4Qm8Knwrg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB6PR0802MB2486; 7:HIEfr3+8bc5gTV5bYsfbQRRrCU9baDrWvy/wl+7D94n1M7UDss/rj2AvP1zpBHWZ4fGd6Lt3n67ebWfGHTcATcVj2I179an4M/qPcU/rPkYW6aHappVQQFWSD/HBY++XGwTTsdPiYZE2PcwTm9E26Dnpt6r7gpdKrTPzzcZ6DJkVbWAgzi5N/qDKEg5KeSnz694el9dNvcjxesbDO6KOaTeHM8msnJW08Q3RjN1ifWsyLwpMUzNzleWFo1J0Qa8a4KUxq9bNF36wscrIn0bdelm2/8km2RjSH2Q16AQ07x8PXlwygihDbXYQkDrFKVfKOLshGBaZH/vNQ9a3lXB14Cw79bijuBet09VA2pVlVbdU2nrL6iQKaJdfEhltCEwzt5IGnWgjEq9kWqJYtAlhaa2qorccm3+SOzu/gl1W/toSfFlS71NLkXsHehjTazdZt9AKvREcI8oj8iGlEQ5201P489av+je/EnMg+HAkYWN8aWBEZSjt9j+4ZZfkWz2EpzE9MFkZ6TMPIEGhTKBEuX6Wgj/mi2gYnQObV7LnbKSB3vQDfhbQAGX3yAjg0WUJEXf8Tkapu4cPE3VMUGJYNSqhUBaKmN4XD0VIuneLTfHd07QYUHmMnrpcHjlZdmCGqfvlqrFb6+3JA1XslYlFdh9wHqwDizL91nA4A7m4KMj9ysZSBRBARJOscvXvRZ42drKlPL4S/pMY4ai4sDv375KI3ta+xStYJWeV0/ZVvmYFwvomfnPrYnP4ZFXRSlkRu6B91vOa/9vuraQC9k6g7JP4nD3B2jSyXqswCQKtNn8= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2017 14:09:42.4186 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2486 |
Commit Message
Szabolcs Nagy
July 12, 2017, 2:09 p.m. UTC
Single thread optimization is valid if at thread creation time the optimization can be disabled. This is in principle true for all stream objects that user code can access (and thus needs locking), using the same internal list as fflush(0) uses. However in glibc open_memstream is not on that list (BZ 21735) so the optimization has to be disabled. 2017-07-12 Szabolcs Nagy <szabolcs.nagy@arm.com> * libio/memstream.c (__open_memstream): Set _IO_FLAGS2_NEED_LOCK. * libio/wmemstream.c (open_wmemstream): Likewise.
Comments
On 07/12/2017 04:09 PM, Szabolcs Nagy wrote: > Single thread optimization is valid if at thread creation time the > optimization can be disabled. This is in principle true for all > stream objects that user code can access (and thus needs locking), > using the same internal list as fflush(0) uses. However in glibc > open_memstream is not on that list (BZ 21735) so the optimization > has to be disabled. > > 2017-07-12 Szabolcs Nagy <szabolcs.nagy@arm.com> > > * libio/memstream.c (__open_memstream): Set _IO_FLAGS2_NEED_LOCK. > * libio/wmemstream.c (open_wmemstream): Likewise. What about the test case I posted? Florian
On 12/07/2017 11:10, Florian Weimer wrote: > On 07/12/2017 04:09 PM, Szabolcs Nagy wrote: >> Single thread optimization is valid if at thread creation time the >> optimization can be disabled. This is in principle true for all >> stream objects that user code can access (and thus needs locking), >> using the same internal list as fflush(0) uses. However in glibc >> open_memstream is not on that list (BZ 21735) so the optimization >> has to be disabled. >> >> 2017-07-12 Szabolcs Nagy <szabolcs.nagy@arm.com> >> >> * libio/memstream.c (__open_memstream): Set _IO_FLAGS2_NEED_LOCK. >> * libio/wmemstream.c (open_wmemstream): Likewise. > > What about the test case I posted? > > Florian > I am about to update my BZ#21735 fix based on Florian's comment, as for this workaround it should touch only memstream implementation.
On 07/12/2017 10:09 AM, Szabolcs Nagy wrote: > Single thread optimization is valid if at thread creation time the > optimization can be disabled. This is in principle true for all > stream objects that user code can access (and thus needs locking), > using the same internal list as fflush(0) uses. However in glibc > open_memstream is not on that list (BZ 21735) so the optimization > has to be disabled. > > 2017-07-12 Szabolcs Nagy <szabolcs.nagy@arm.com> > > * libio/memstream.c (__open_memstream): Set _IO_FLAGS2_NEED_LOCK. > * libio/wmemstream.c (open_wmemstream): Likewise. > IIUC we can avoid this patch if we fix BZ #21735?
On 12/07/17 15:15, Carlos O'Donell wrote: > On 07/12/2017 10:09 AM, Szabolcs Nagy wrote: >> Single thread optimization is valid if at thread creation time the >> optimization can be disabled. This is in principle true for all >> stream objects that user code can access (and thus needs locking), >> using the same internal list as fflush(0) uses. However in glibc >> open_memstream is not on that list (BZ 21735) so the optimization >> has to be disabled. >> >> 2017-07-12 Szabolcs Nagy <szabolcs.nagy@arm.com> >> >> * libio/memstream.c (__open_memstream): Set _IO_FLAGS2_NEED_LOCK. >> * libio/wmemstream.c (open_wmemstream): Likewise. >> > > IIUC we can avoid this patch if we fix BZ #21735? > yes, this is an alternative workaround that's less intrusive.
On 12/07/17 15:10, Florian Weimer wrote: > On 07/12/2017 04:09 PM, Szabolcs Nagy wrote: >> Single thread optimization is valid if at thread creation time the >> optimization can be disabled. This is in principle true for all >> stream objects that user code can access (and thus needs locking), >> using the same internal list as fflush(0) uses. However in glibc >> open_memstream is not on that list (BZ 21735) so the optimization >> has to be disabled. >> >> 2017-07-12 Szabolcs Nagy <szabolcs.nagy@arm.com> >> >> * libio/memstream.c (__open_memstream): Set _IO_FLAGS2_NEED_LOCK. >> * libio/wmemstream.c (open_wmemstream): Likewise. > > What about the test case I posted? > it passes now, but i did not add it to glibc.. may be i should have. but now i'll wait for Adhemerval updating his patch.
diff --git a/libio/memstream.c b/libio/memstream.c index f83d4a5213..e391efd48a 100644 --- a/libio/memstream.c +++ b/libio/memstream.c @@ -96,6 +96,9 @@ __open_memstream (char **bufloc, _IO_size_t *sizeloc) new_f->fp.bufloc = bufloc; new_f->fp.sizeloc = sizeloc; + /* Disable single thread optimization. BZ 21735. */ + new_f->fp._sf._sbf._f._flags2 |= _IO_FLAGS2_NEED_LOCK; + return (_IO_FILE *) &new_f->fp._sf._sbf; } libc_hidden_def (__open_memstream) diff --git a/libio/wmemstream.c b/libio/wmemstream.c index 5bc77f52ee..103a760bf5 100644 --- a/libio/wmemstream.c +++ b/libio/wmemstream.c @@ -98,6 +98,9 @@ open_wmemstream (wchar_t **bufloc, _IO_size_t *sizeloc) new_f->fp.bufloc = bufloc; new_f->fp.sizeloc = sizeloc; + /* Disable single thread optimization. BZ 21735. */ + new_f->fp._sf._sbf._f._flags2 |= _IO_FLAGS2_NEED_LOCK; + return (_IO_FILE *) &new_f->fp._sf._sbf; }