Message ID | 042b06ef-92f4-11c3-d789-cb211412ef10@redhat.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 69530 invoked by alias); 27 Jun 2017 15:46:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 69502 invoked by uid 89); 27 Jun 2017 15:46:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 15:46:14 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8358680F96; Tue, 27 Jun 2017 15:46:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8358680F96 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8358680F96 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id DB6C65B80C; Tue, 27 Jun 2017 15:46:12 +0000 (UTC) Subject: Re: [PATCH 05/40] command.h: Include common/scoped_restore.h To: Yao Qi <qiyaoltc@gmail.com> References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-6-git-send-email-palves@redhat.com> <86bmp9fz0z.fsf@gmail.com> <684b5ca4-590b-d375-93f5-b66e86ec33a1@redhat.com> <6314192d-2f8e-cfd1-18ea-362cf2b59374@redhat.com> <5e659d80-8e34-5733-5a15-3b683c0c1906@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves <palves@redhat.com> Message-ID: <042b06ef-92f4-11c3-d789-cb211412ef10@redhat.com> Date: Tue, 27 Jun 2017 16:46:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <5e659d80-8e34-5733-5a15-3b683c0c1906@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit |
Commit Message
Pedro Alves
June 27, 2017, 3:46 p.m. UTC
On 06/27/2017 01:02 PM, Pedro Alves wrote: > I should have included this info in the original submission. > Sorry about that. > Here's the same patch with commit log updated to include the missing info, and also fix the silly typo in the filename in the subject/ChangeLog. From 63aba45330a791ab60a79acbe90344c9deb260e9 Mon Sep 17 00:00:00 2001 From: Pedro Alves <palves@redhat.com> Date: Thu, 1 Jun 2017 17:03:11 +0100 Subject: [PATCH 05/40] gdb/command.h: Include common/scoped_restore.h MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit command.h depends on scoped_restore: extern scoped_restore_tmpl<int> prevent_dont_repeat (void); But doesn't include the corresponding header ("common/scoped_restore.h"). We haven't noticed a problem because utils.h includes scoped_restore.h, and defs.h includes utils.h. However, a patch that makes "symtab.h" include "completer.h", exposed the issue: https://sourceware.org/ml/gdb-patches/2017-06/msg00023.html. Without this fix that would break building all .o files like this: In file included from src/gdb/completer.h:21:0, from src/gdb/symtab.h:28, from src/gdb/language.h:26, from src/gdb/frame.h:72, from src/gdb/gdbarch.h:39, from src/gdb/defs.h:636, from src/gdb/top.c:20: src/gdb/command.h:434:8: error: ‘scoped_restore_tmpl’ does not name a type extern scoped_restore_tmpl<int> prevent_dont_repeat (void); ^ Makefile:1911: recipe for target 'top.o' failed because defs.h includes gdbarch.h before it includes utils.h. gdb/ChangeLog: yyyy-mm-dd Pedro Alves <palves@redhat.com> * command.h: Include "common/scoped_restore.h". --- gdb/command.h | 1 + 1 file changed, 1 insertion(+)
Comments
Pedro Alves <palves@redhat.com> writes: > Here's the same patch with commit log updated to include the missing > info, and also fix the silly typo in the filename in the > subject/ChangeLog. That is clear. Patch is good to me.
On 06/28/2017 08:54 AM, Yao Qi wrote: > Pedro Alves <palves@redhat.com> writes: > >> Here's the same patch with commit log updated to include the missing >> info, and also fix the silly typo in the filename in the >> subject/ChangeLog. > > That is clear. Patch is good to me. Patch is pushed, then. Thanks, Pedro Alves
diff --git a/gdb/command.h b/gdb/command.h index aa179e9..4a56a51 100644 --- a/gdb/command.h +++ b/gdb/command.h @@ -19,6 +19,7 @@ #define COMMAND_H 1 #include "gdb_vecs.h" +#include "common/scoped_restore.h" /* This file defines the public interface for any code wanting to create commands. */