[v2] manual: Update @standards for [__]va_copy.

Message ID 20170620110341.28382-1-ricaljasan@pacific.net
State Committed
Headers

Commit Message

Rical Jasan June 20, 2017, 11:03 a.m. UTC
  The ISO version in which va_copy was introduced is made explicit, and
__va_copy is given @standards.  The description is updated to be more
clear about the origins of each macro, and the reader is informed
these macros are now provided by the compiler (information previously
embedded in a Texinfo @comment).

	* lang.texi (va_copy): Change standard from ISO to C99.
	(__va_copy): Add standard and header annotation.
	Update description for clarity of origins and current use.
---
 manual/lang.texi | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
  

Comments

Rical Jasan July 27, 2017, 10:06 a.m. UTC | #1
Ping

The review of v1 had some difference of opinion [1] regarding the
mention of GCC 3.0.  I left it in, but addressed the other comments [2].

Rical

[1] https://sourceware.org/ml/libc-alpha/2017-06/msg00768.html
[2] https://sourceware.org/ml/libc-alpha/2017-06/msg00765.html

On 06/20/2017 04:03 AM, Rical Jasan wrote:
> The ISO version in which va_copy was introduced is made explicit, and
> __va_copy is given @standards.  The description is updated to be more
> clear about the origins of each macro, and the reader is informed
> these macros are now provided by the compiler (information previously
> embedded in a Texinfo @comment).
> 
> 	* lang.texi (va_copy): Change standard from ISO to C99.
> 	(__va_copy): Add standard and header annotation.
> 	Update description for clarity of origins and current use.
> ---
>  manual/lang.texi | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/manual/lang.texi b/manual/lang.texi
> index cacbdfb7c5..0ba002a396 100644
> --- a/manual/lang.texi
> +++ b/manual/lang.texi
> @@ -471,18 +471,21 @@ of the same type.
>  
>  @deftypefn {Macro} void va_copy (va_list @var{dest}, va_list @var{src})
>  @deftypefnx {Macro} void __va_copy (va_list @var{dest}, va_list @var{src})
> -@standardsx{va_copy, ISO, stdarg.h}
> +@standardsx{va_copy, C99, stdarg.h}
> +@standardsx{__va_copy, GNU, stdarg.h}
>  @safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
> -@c This is no longer provided by glibc, but rather by the compiler.
>  The @code{va_copy} macro allows copying of objects of type
>  @code{va_list} even if this is not an integral type.  The argument pointer
>  in @var{dest} is initialized to point to the same argument as the
>  pointer in @var{src}.
>  
> -This macro was added in ISO C99.  When building for strict conformance
> -to ISO C90 (@samp{gcc -ansi}), it is not available.  The macro
> -@code{__va_copy} is available as a GNU extension in any standards
> -mode; before GCC 3.0, it was the only macro for this functionality.
> +@code{va_copy} was added in ISO C99.  When building for strict
> +conformance to ISO C90 (@samp{gcc -std=c90}), it is not available.
> +GCC provides @code{__va_copy}, as an extension, in any standards mode;
> +before GCC 3.0, it was the only macro for this functionality.
> +
> +These macros are no longer provided by @theglibc{}, but rather by the
> +compiler.
>  @end deftypefn
>  
>  If you want to use @code{va_copy} and be portable to pre-C99 systems,
>
  
Rical Jasan Aug. 10, 2017, 12:11 p.m. UTC | #2
Ping^2

On 06/20/2017 04:03 AM, Rical Jasan wrote:
> The ISO version in which va_copy was introduced is made explicit, and
> __va_copy is given @standards.  The description is updated to be more
> clear about the origins of each macro, and the reader is informed
> these macros are now provided by the compiler (information previously
> embedded in a Texinfo @comment).
> 
> 	* lang.texi (va_copy): Change standard from ISO to C99.
> 	(__va_copy): Add standard and header annotation.
> 	Update description for clarity of origins and current use.
> ---
>  manual/lang.texi | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/manual/lang.texi b/manual/lang.texi
> index cacbdfb7c5..0ba002a396 100644
> --- a/manual/lang.texi
> +++ b/manual/lang.texi
> @@ -471,18 +471,21 @@ of the same type.
>  
>  @deftypefn {Macro} void va_copy (va_list @var{dest}, va_list @var{src})
>  @deftypefnx {Macro} void __va_copy (va_list @var{dest}, va_list @var{src})
> -@standardsx{va_copy, ISO, stdarg.h}
> +@standardsx{va_copy, C99, stdarg.h}
> +@standardsx{__va_copy, GNU, stdarg.h}
>  @safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
> -@c This is no longer provided by glibc, but rather by the compiler.
>  The @code{va_copy} macro allows copying of objects of type
>  @code{va_list} even if this is not an integral type.  The argument pointer
>  in @var{dest} is initialized to point to the same argument as the
>  pointer in @var{src}.
>  
> -This macro was added in ISO C99.  When building for strict conformance
> -to ISO C90 (@samp{gcc -ansi}), it is not available.  The macro
> -@code{__va_copy} is available as a GNU extension in any standards
> -mode; before GCC 3.0, it was the only macro for this functionality.
> +@code{va_copy} was added in ISO C99.  When building for strict
> +conformance to ISO C90 (@samp{gcc -std=c90}), it is not available.
> +GCC provides @code{__va_copy}, as an extension, in any standards mode;
> +before GCC 3.0, it was the only macro for this functionality.
> +
> +These macros are no longer provided by @theglibc{}, but rather by the
> +compiler.
>  @end deftypefn
>  
>  If you want to use @code{va_copy} and be portable to pre-C99 systems,
  
Florian Weimer Aug. 10, 2017, 4:34 p.m. UTC | #3
On 06/20/2017 01:03 PM, Rical Jasan wrote:
> The ISO version in which va_copy was introduced is made explicit, and
> __va_copy is given @standards.  The description is updated to be more
> clear about the origins of each macro, and the reader is informed
> these macros are now provided by the compiler (information previously
> embedded in a Texinfo @comment).
> 
> 	* lang.texi (va_copy): Change standard from ISO to C99.
> 	(__va_copy): Add standard and header annotation.
> 	Update description for clarity of origins and current use.

Looks good to me.

Thanks,
Florian
  
Rical Jasan Aug. 11, 2017, 3 a.m. UTC | #4
On 08/10/2017 09:34 AM, Florian Weimer wrote:
> On 06/20/2017 01:03 PM, Rical Jasan wrote:
>> The ISO version in which va_copy was introduced is made explicit, and
>> __va_copy is given @standards.  The description is updated to be more
>> clear about the origins of each macro, and the reader is informed
>> these macros are now provided by the compiler (information previously
>> embedded in a Texinfo @comment).
>>
>> 	* lang.texi (va_copy): Change standard from ISO to C99.
>> 	(__va_copy): Add standard and header annotation.
>> 	Update description for clarity of origins and current use.
> 
> Looks good to me.

Thank you.  Committed.

Rical
  

Patch

diff --git a/manual/lang.texi b/manual/lang.texi
index cacbdfb7c5..0ba002a396 100644
--- a/manual/lang.texi
+++ b/manual/lang.texi
@@ -471,18 +471,21 @@  of the same type.
 
 @deftypefn {Macro} void va_copy (va_list @var{dest}, va_list @var{src})
 @deftypefnx {Macro} void __va_copy (va_list @var{dest}, va_list @var{src})
-@standardsx{va_copy, ISO, stdarg.h}
+@standardsx{va_copy, C99, stdarg.h}
+@standardsx{__va_copy, GNU, stdarg.h}
 @safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
-@c This is no longer provided by glibc, but rather by the compiler.
 The @code{va_copy} macro allows copying of objects of type
 @code{va_list} even if this is not an integral type.  The argument pointer
 in @var{dest} is initialized to point to the same argument as the
 pointer in @var{src}.
 
-This macro was added in ISO C99.  When building for strict conformance
-to ISO C90 (@samp{gcc -ansi}), it is not available.  The macro
-@code{__va_copy} is available as a GNU extension in any standards
-mode; before GCC 3.0, it was the only macro for this functionality.
+@code{va_copy} was added in ISO C99.  When building for strict
+conformance to ISO C90 (@samp{gcc -std=c90}), it is not available.
+GCC provides @code{__va_copy}, as an extension, in any standards mode;
+before GCC 3.0, it was the only macro for this functionality.
+
+These macros are no longer provided by @theglibc{}, but rather by the
+compiler.
 @end deftypefn
 
 If you want to use @code{va_copy} and be portable to pre-C99 systems,