Patchwork Automatically set the comment style to what we use

login
register
mail settings
Submitter Eli Zaretskii
Date June 16, 2017, 1:38 p.m.
Message ID <83bmpo128p.fsf@gnu.org>
Download mbox | patch
Permalink /patch/21049/
State New
Headers show

Comments

Eli Zaretskii - June 16, 2017, 1:38 p.m.
The development version of Emacs has a new feature, whereby one can
toggle the comment style and get the C style in C++ sources, the style
we use.  (I got annoyed by having to manually type the comment
starting and ending sequences, so I asked the CC mode maintainer to
add this, and he just did.)

So what do people think about the following addition to our
.dir-locals.el?  I verified that it's a no-op in versions of Emacs
which don't support this functionality.
Yao Qi - June 22, 2017, 9:45 a.m.
On Fri, Jun 16, 2017 at 2:38 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> The development version of Emacs has a new feature, whereby one can
> toggle the comment style and get the C style in C++ sources, the style
> we use.  (I got annoyed by having to manually type the comment
> starting and ending sequences, so I asked the CC mode maintainer to
> add this, and he just did.)
>

Hi Eli,
How does this change affect the people writing code
using new emacs?  I still manually type comment
starting and ending sequences every day.
Eli Zaretskii - June 22, 2017, 3:03 p.m.
> From: Yao Qi <qiyaoltc@gmail.com>
> Date: Thu, 22 Jun 2017 10:45:45 +0100
> Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> 
> On Fri, Jun 16, 2017 at 2:38 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > The development version of Emacs has a new feature, whereby one can
> > toggle the comment style and get the C style in C++ sources, the style
> > we use.  (I got annoyed by having to manually type the comment
> > starting and ending sequences, so I asked the CC mode maintainer to
> > add this, and he just did.)
> 
> How does this change affect the people writing code
> using new emacs?  I still manually type comment
> starting and ending sequences every day.

Emacs has a command to open a comment: 'M-;' (without the quotes).
When you type this in C mode, Emacs inserts "/* */" and puts the
cursor inside the comment, so you could type the text.  In C++ mode,
'M-;' inserts "// " and puts the cursor after it.  With the above new
feature, you can now get "/* */" in C++ mode if you toggle the style.

Does that answer your question?  (I've stopped typing the comment
starting and ending sequences long ago, I always use 'M-;'.)
Eli Zaretskii - June 22, 2017, 3:04 p.m.
And btw, what about the patch I suggested?  Is it OK to push it?
Yao Qi - June 22, 2017, 3:14 p.m.
On Thu, Jun 22, 2017 at 4:04 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> And btw, what about the patch I suggested?  Is it OK to push it?

Yes, please.
Eli Zaretskii - July 1, 2017, 3:48 p.m.
> From: Yao Qi <qiyaoltc@gmail.com>
> Date: Thu, 22 Jun 2017 16:14:04 +0100
> Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> 
> On Thu, Jun 22, 2017 at 4:04 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > And btw, what about the patch I suggested?  Is it OK to push it?
> 
> Yes, please.

Thanks, pushed to master.

Patch

diff --git a/gdb/.dir-locals.el b/gdb/.dir-locals.el
index a2aa196..48325b1 100644
--- a/gdb/.dir-locals.el
+++ b/gdb/.dir-locals.el
@@ -26,4 +26,6 @@  (
 	    (c-basic-offset . 2)
 	    (eval . (c-set-offset 'innamespace 0))
 	    ))
+ (c++-mode . ((eval . (when (fboundp 'c-toggle-comment-style)
+			(c-toggle-comment-style 1)))))
 )