Patchwork PR gdb/21574: Mention $SHELL and startup-with-shell on "help run"

login
register
mail settings
Submitter Sergio Durigan Junior
Date June 14, 2017, 8:48 p.m.
Message ID <20170614204836.15123-1-sergiodj@redhat.com>
Download mbox | patch
Permalink /patch/21028/
State New
Headers show

Comments

Sergio Durigan Junior - June 14, 2017, 8:48 p.m.
This simple patch updates the documentation of "help run" in order to
mention that the shell used to start the inferior comes from the
$SHELL environment variable.  It also mentions that this behaviour can
be disabled by using the "set startup-with-shell off" command.

OK?

gdb/ChangeLog:
yyyy-mm-dd  Sergio Durigan Junior  <sergiodj@redhat.com>

	PR gdb/21574
	* infcmd.c (_initialize_infcmd): Expand "help run" documentation
	to mention $SHELL and startup-with-shell.
---
 gdb/infcmd.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Eli Zaretskii - June 15, 2017, 2:34 a.m.
> From: Sergio Durigan Junior <sergiodj@redhat.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,
> 	Sergio Durigan Junior <sergiodj@redhat.com>
> Date: Wed, 14 Jun 2017 16:48:36 -0400
> 
> This simple patch updates the documentation of "help run" in order to
> mention that the shell used to start the inferior comes from the
> $SHELL environment variable.  It also mentions that this behaviour can
> be disabled by using the "set startup-with-shell off" command.
> 
> OK?

Yes, but instead of 'see the "$SHELL" environment variable', I'd
suggest to say 'specified by the "$SHELL" environment variable'.

Thanks.
Sergio Durigan Junior - June 15, 2017, 2:46 a.m.
On Wednesday, June 14 2017, Eli Zaretskii wrote:

>> From: Sergio Durigan Junior <sergiodj@redhat.com>
>> Cc: Eli Zaretskii <eliz@gnu.org>,
>> 	Sergio Durigan Junior <sergiodj@redhat.com>
>> Date: Wed, 14 Jun 2017 16:48:36 -0400
>> 
>> This simple patch updates the documentation of "help run" in order to
>> mention that the shell used to start the inferior comes from the
>> $SHELL environment variable.  It also mentions that this behaviour can
>> be disabled by using the "set startup-with-shell off" command.
>> 
>> OK?
>
> Yes, but instead of 'see the "$SHELL" environment variable', I'd
> suggest to say 'specified by the "$SHELL" environment variable'.

That's better indeed.

Pushed with this change.

45159d6ad394fe7db840b2b92eaa69508b8a8fe7

Thanks,

Patch

diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index db09f19..0b2d96c 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -3400,13 +3400,16 @@  Specifying -a and an ignore count simultaneously is an error."));
 
   c = add_com ("run", class_run, run_command, _("\
 Start debugged program.  You may specify arguments to give it.\n\
-Args may include \"*\", or \"[...]\"; they are expanded using \"sh\".\n\
-Input and output redirection with \">\", \"<\", or \">>\" are also \
-allowed.\n\n\
+Args may include \"*\", or \"[...]\"; they are expanded using the\n\
+shell that will start the program (see the \"$SHELL\"\
+environment\nvariable).  Input and output redirection with \">\",\
+\"<\", or \">>\"\nare also allowed.\n\n\
 With no arguments, uses arguments last specified (with \"run\" \
 or \"set args\").\n\
 To cancel previous arguments and run with no arguments,\n\
-use \"set args\" without arguments."));
+use \"set args\" without arguments.\n\
+To start the inferior without using a shell, use \"set \
+startup-with-shell off\"."));
   set_cmd_completer (c, filename_completer);
   add_com_alias ("r", "run", class_run, 1);