From patchwork Wed Jun 14 18:57:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 21024 Received: (qmail 84071 invoked by alias); 14 Jun 2017 18:58:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 83946 invoked by uid 89); 14 Jun 2017 18:57:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=1679, disp, del X-HELO: mail-wr0-f173.google.com Received: from mail-wr0-f173.google.com (HELO mail-wr0-f173.google.com) (209.85.128.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Jun 2017 18:57:58 +0000 Received: by mail-wr0-f173.google.com with SMTP id r103so10977156wrb.0 for ; Wed, 14 Jun 2017 11:58:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=bOhswnz1L03hMpCHV7dPPB/hMBRg3j29pypqTtqsHbE=; b=KmNPSGsUNcLDYnTVtPVURdrR8djkbvMy47631G1jKyjQRjkFSFgKPgdoG4ZEfS9Sdk rue7rBGjiy62gZliUgxVIqbNo+6S88FfT7aCFlQVbKUvso2i3Nmd60GpL0MQ1tjfwUVP svLCezQ0dYaWq8H010KsSYIFYUBMS9AxHiS0K2baFYJweVDe0eFlhnXYxJcfUJqp8rLK BjdRB9lv3y3691XevXfX8QGLT6UMWJavv+spBl/ccKAJcG1t5bXOcdDvLMKFQTZzMRYU Wf4u9B5lvwfkWPKMST0gHM51+DqKjXnGQlSkqDAjBWVcUOvDODU2SHI6T0W+I/9phXXJ jzXA== X-Gm-Message-State: AKS2vOzo8XblGngzhpKwdPTwdjKYq5Th+VGz8JntgWsvPMcjMXyHqQ9f e4WJ6bevOJ9MLPYuPNk= X-Received: by 10.223.144.4 with SMTP id h4mr969324wrh.182.1497466680404; Wed, 14 Jun 2017 11:58:00 -0700 (PDT) Received: from localhost (cust64-dsl91-135-5.idnet.net. [91.135.5.64]) by smtp.gmail.com with ESMTPSA id y89sm960285wmh.13.2017.06.14.11.57.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Jun 2017 11:57:59 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 1/2] gdb: Fix parameter passing to mi_create_breakpoint Date: Wed, 14 Jun 2017 19:57:38 +0100 Message-Id: In-Reply-To: References: In-Reply-To: References: X-IsSubscribed: yes In the test gdb.mi/mi-vla-fortran.exp the parameters passed to mi_create_breakpoint are passed in the wrong order. By good luck the tests still passes, however the wrong test name is used. All fixed in this commit. gdb/testsuite/ChangeLog: * gdb.mi/mi-vla-fortran.exp: Correct parameter passing to mi_create_breakpoint. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.mi/mi-vla-fortran.exp | 36 +++++++++++++++++++-------------- 2 files changed, 26 insertions(+), 15 deletions(-) diff --git a/gdb/testsuite/gdb.mi/mi-vla-fortran.exp b/gdb/testsuite/gdb.mi/mi-vla-fortran.exp index b81165e..7b40aba 100644 --- a/gdb/testsuite/gdb.mi/mi-vla-fortran.exp +++ b/gdb/testsuite/gdb.mi/mi-vla-fortran.exp @@ -37,9 +37,9 @@ mi_gdb_reinitialize_dir $srcdir/$subdir mi_gdb_load ${binfile} set bp_lineno [gdb_get_line_number "vla1-not-allocated"] -mi_create_breakpoint "-t vla.f90:$bp_lineno" 1 "del" "vla" \ - ".*vla.f90" $bp_lineno $hex \ - "insert breakpoint at line $bp_lineno (vla not allocated)" +mi_create_breakpoint "-t vla.f90:$bp_lineno" \ + "insert breakpoint at line $bp_lineno (vla not allocated)" \ + -number 1 -disp del -func vla ".*vla.f90" $bp_lineno $hex mi_run_cmd mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \ { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno" @@ -63,8 +63,9 @@ mi_list_array_varobj_children_with_index "vla1_not_allocated" "0" "1" \ set bp_lineno [gdb_get_line_number "vla1-allocated"] -mi_create_breakpoint "-t vla.f90:$bp_lineno" 2 "del" "vla" ".*vla.f90" \ - $bp_lineno $hex "insert breakpoint at line $bp_lineno (vla allocated)" +mi_create_breakpoint "-t vla.f90:$bp_lineno" \ + "insert breakpoint at line $bp_lineno (vla allocated)" \ + -number 2 -disp del -func vla ".*vla.f90" $bp_lineno $hex mi_run_cmd mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \ { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno" @@ -87,8 +88,9 @@ mi_list_array_varobj_children_with_index "vla1_allocated" "5" "1" \ set bp_lineno [gdb_get_line_number "vla1-filled"] -mi_create_breakpoint "-t vla.f90:$bp_lineno" 3 "del" "vla" ".*vla.f90" \ - $bp_lineno $hex "insert breakpoint at line $bp_lineno" +mi_create_breakpoint "-t vla.f90:$bp_lineno" \ + "insert breakpoint at line $bp_lineno" \ + -number 3 -disp del -func vla ".*vla.f90" $bp_lineno $hex mi_run_cmd mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \ { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno" @@ -97,8 +99,9 @@ mi_gdb_test "520-data-evaluate-expression vla1" \ set bp_lineno [gdb_get_line_number "vla1-modified"] -mi_create_breakpoint "-t vla.f90:$bp_lineno" 4 "del" "vla" ".*vla.f90" \ - $bp_lineno $hex "insert breakpoint at line $bp_lineno" +mi_create_breakpoint "-t vla.f90:$bp_lineno" \ + "insert breakpoint at line $bp_lineno" \ + -number 4 -disp del -func vla ".*vla.f90" $bp_lineno $hex mi_run_cmd mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \ { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno" @@ -113,8 +116,9 @@ mi_gdb_test "560-data-evaluate-expression vla1(4)" \ set bp_lineno [gdb_get_line_number "vla1-deallocated"] -mi_create_breakpoint "-t vla.f90:$bp_lineno" 5 "del" "vla" ".*vla.f90" \ - $bp_lineno $hex "insert breakpoint at line $bp_lineno" +mi_create_breakpoint "-t vla.f90:$bp_lineno" \ + "insert breakpoint at line $bp_lineno" \ + -number 5 -disp del -func vla ".*vla.f90" $bp_lineno $hex mi_run_cmd mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \ { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno" @@ -163,8 +167,9 @@ gdb_expect { } set bp_lineno [gdb_get_line_number "pvla2-associated"] -mi_create_breakpoint "-t vla.f90:$bp_lineno" 7 "del" "vla" ".*vla.f90" \ - $bp_lineno $hex "insert breakpoint at line $bp_lineno" +mi_create_breakpoint "-t vla.f90:$bp_lineno" \ + "insert breakpoint at line $bp_lineno" \ + -number 7 -disp del -func vla ".*vla.f90" $bp_lineno $hex mi_run_cmd mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \ { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno" @@ -186,8 +191,9 @@ mi_gdb_test "593-var-evaluate-expression pvla2_associated" \ set bp_lineno [gdb_get_line_number "pvla2-set-to-null"] -mi_create_breakpoint "-t vla.f90:$bp_lineno" 8 "del" "vla" ".*vla.f90" \ - $bp_lineno $hex "insert breakpoint at line $bp_lineno" +mi_create_breakpoint "-t vla.f90:$bp_lineno" \ + "insert breakpoint at line $bp_lineno" \ + -number 8 -disp del -func vla ".*vla.f90" $bp_lineno $hex mi_run_cmd mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \ { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno"