Patchwork Patch 2 of 2 for ILP32 aarch64

login
register
mail settings
Submitter Steve Ellcey
Date June 13, 2017, 7:06 p.m.
Message ID <1497380813.13346.115.camel@cavium.com>
Download mbox | patch
Permalink /patch/20995/
State New
Headers show

Comments

Steve Ellcey - June 13, 2017, 7:06 p.m.
On Tue, 2017-06-13 at 10:09 +0100, Szabolcs Nagy wrote:

> FAIL: nptl/tst-initializers1
> FAIL: nptl/tst-initializers1-c11
> FAIL: nptl/tst-initializers1-c89
> FAIL: nptl/tst-initializers1-c99
> FAIL: nptl/tst-initializers1-gnu11
> FAIL: nptl/tst-initializers1-gnu89
> FAIL: nptl/tst-initializers1-gnu99

I took a look at these failures and saw that
__PTHREAD_RWLOCK_INT_FLAGS_SHARED is only being set when in 64 bit
mode.  I updated sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h to
define this macro and that fixed these failures.  I will include that
change in my next patch submission (currently waiting on the kernel
patches).

Steve Ellcey
sellcey@cavium.com



% git diff sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h

Patch

diff --git a/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h
b/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h
index d13a75d..9aa9f04 100644
--- a/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h
+++ b/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h
@@ -65,5 +65,6 @@  struct __pthread_rwlock_arch_t
 };
 
 #define __PTHREAD_RWLOCK_ELISION_EXTRA 0
+#define __PTHREAD_RWLOCK_INT_FLAGS_SHARED 1
 
 #endif /* bits/pthreadtypes.h */