Patch 2 of 2 for ILP32 aarch64

Message ID	1497380813.13346.115.camel@cavium.com
State	New, archived
Headers	Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk Sender: libc-alpha-owner@sourceware.org Message-ID: <1497380813.13346.115.camel@cavium.com> Subject: Re: [PATCH] Patch 2 of 2 for ILP32 aarch64 From: Steve Ellcey <sellcey@cavium.com> Reply-To: sellcey@cavium.com To: Szabolcs Nagy <szabolcs.nagy@arm.com>, Steve Ellcey <sellcey@caviumnetworks.com>, Joseph Myers <joseph@codesourcery.com> Cc: nd@arm.com, libc-alpha <libc-alpha@sourceware.org> Date: Tue, 13 Jun 2017 12:06:53 -0700 In-Reply-To: <593FABC2.7020108@arm.com> References: <1487781046.2866.153.camel@caviumnetworks.com> <alpine.DEB.2.20.1702221702490.8704@digraph.polyomino.org.uk> <1487879964.2866.181.camel@caviumnetworks.com> <alpine.DEB.2.20.1702240033550.6066@digraph.polyomino.org.uk> <1487980010.2866.198.camel@caviumnetworks.com> <593A60B1.6090100@arm.com> <593A7CEC.2040001@arm.com> <593E6999.6050405@arm.com> <1497284101.13346.104.camel@cavium.com> <593EC0AE.8070906@arm.com> <593FABC2.7020108@arm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjA3TUIzNDY1OzIzOmFiR1V3Ym1vWUNZOUVRR1Nob0VWOU16OG81?= =?utf-8?B?QUtxeEN4Y2V0Y0VMR21sODZGMmZtMXVlSGtmdUJvdWNNbXdNWmdxWnRGa2M1?= =?utf-8?B?czJVbUVJRXl4M1Yvb2owNFo5SXhTaHJ4eVZ3NjNRRXR2TmtGT0pHL0lJR0pB?= =?utf-8?B?ZCtpazJyRzZMWjdkYkc1WjJGY2lZWld2b21OSUhiTDdWdjF5ZTNjYXNrODA1?= =?utf-8?B?WXlVaTJEbnFlSmUxKzBpMWZqK2twYmt3YmdkdGhPVUtaOEp0cGp2b2d0L3RW?= =?utf-8?B?NWUxdU92WlNUU3VGTEg3Nkw0Q0ErR1JlY2Q1dXFXUno1bTBENHpraGZqMzJw?= =?utf-8?B?UmRrK2hXeks4ZlRpUzc4L3NxQ1VyT3ZoQWVneDduRkxmWGhGa3V0dy9LMlhN?= =?utf-8?B?Vk1UZmJWVndVeXJmcFgrcm02SURZWmZONUE5S2cxS0FvUXRHL3hqUGxNMUx2?= =?utf-8?B?S0ZTc2F6b0VQMlYxS2p6bmU5eVhINXZqdVpobjlDL25TMnQ0TEdRNjArSUg3?= =?utf-8?B?MklyTzc1Q3JyK1NkTFUxT2M2NUdJengrVisvRW0yVGtwZTZGR3FXMjdua3Rs?= =?utf-8?B?OFVyYnFvck5VYld5OTE0cXJLc1dyRnF1R0F5ZnpTMkRLZS9hREhhZWZadERD?= =?utf-8?B?WWJBUi9BZzVSSCtZY1ZNSElqREYvVDd0bm5HOVdhTFBHRzFoRjdTeEVrc0cy?= =?utf-8?B?K0krVUtJTHN2SXlvaWdOVGU0SWFVK3hERi9rNnY1ekZHVk9qM0NhbkltZFFY?= =?utf-8?B?ZkR4LzgybjRjT0RCamtaMU0xSW9tM25FRUJxL1Q0QlFRMnpHc1BWNjZKaW5T?= =?utf-8?B?YXhtOC8vSkx5Sm1VNmg3YmV5ZlViQXgwVEVSMjB0aHQ0YXhnWGF4bGk3ME5D?= =?utf-8?B?aDdGY20xUXB0ZDNQVHhwQTF6b0RJMlFKbzFHVW5lK1JPdUZRRUxxdEMxSVdv?= =?utf-8?B?WUcyK0tSdE9BZnFxNDBpU0hGWUxvUk5vLzA4cUM4WFNNaFkvUzJoZG1XVWYr?= =?utf-8?B?TzZEZkY2N3c1Zk9IOWhjMmFrZDE4SDF4WDVQZXBXTk1tS1hESXB5NUVNZTFF?= =?utf-8?B?RUtlajNtYndzcnZHUWhWNVBVM3NITGgya1hSek5OeUcxUjVJMFZnQlprT0Zq?= =?utf-8?B?MHpHdmRNWVgwNTBmRVBWTUJjR284Sk0vWWlWSnlkYnoxNmhqSmh4NjM5cjFs?= =?utf-8?B?UzlrTUdsdmswWENSNFNhYy92WmZudkVIVjR1b2Z6a2VkcWc4OFIzNDZ5ZUNU?= =?utf-8?B?aXB6RFVlYmFXUjVHRk90L0xxZExNVXpHc2M0NFJET2h5TGJRV0x1N1poNGRE?= =?utf-8?B?OTl2VGNGTk9vbTltbUp1SE50QkJQbnJCWVBFVjRCNXdsWnY2R0JRVWRKd2Fl?= =?utf-8?B?cTZ2QmEyNHhSRkVGV1NQSGoxR1hIajRhYVJMeTM2NmRKbjUyMWZHSkNDVEdk?= =?utf-8?B?Z3YxSjN4czROK29VeE5odXRCbXRuNEtKTklCYUpuSUhDNFE5T094WXVkWlMx?= =?utf-8?B?ZGoxMk0wRmtqZlI0ZEdrZGJWMHNTR3gwODloeGVIZ01kTkJsZDFRY2hlbWdr?= =?utf-8?B?dmxmSkVTNVd5TS9hRmxWM2FRY1NDUWtNbXNjQ2ZjM3R6SmNMbEZUSElDb05w?= =?utf-8?B?NUliWjduUXpnSFMrRXJzTjhZVEFEV1NvcUdBQXYvNTRNUVRueWp2d2trYVpX?= =?utf-8?B?QWxBbjIvRXhuUFpMVlNrYkNSQXFoZTIzNEZyY1JOUm5VSW43REVPY205TTF4?= =?utf-8?B?WkowSHd0N1ZIZjhjOGtrWG5NZVN5UWZtaHFqU0x6WG5UaXNKNGVJU0Y1U2ow?= =?utf-8?B?RHFzeHdTRHR3UjREbU9QOWU4RGcwVDJSbDA1VHhabE82cVcxbkowZGhjRVY4?= =?utf-8?Q?mCYDz9alYGfILsDoiERfKVm6K4zwcziw?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 6:x8xCDDi67X9unKpWdjXkXadPm98n8/O6Ym+qJJO189JCznYra5zcXd/XZYS7Zi9R8pBzeVX6mLB6z7DhIXY5YkR7vlODorYEDEQ9iPjThaFu5uOrBo89/hjrltVxKqcrMKc4+i4WM0QLp4U0PcBTaxcMre8u8po6gvzYIxe6omlced2W83ic6U9jM7AnzpHzPuXLgswpspf5VCkCfJgvhHc3aYVgR6nJj1TUlYA6szKcVpXfqjR1O3wBr57o58NdXoqb+ejVbX/TueB7o6MrW+8Jtcex2+y3aKy3od3snY4LLLVTa8usbErDqX9sQwb7RCTpdeubRngfBsRq9JjmbZWTcQIMI/Ven7Zb8Rw5oLx5hxdwu5OHpmejZWC39Zg7oDALMW+pCCTy1kvR4WQDYixsRBAQkrc3/svlYYTJYU/rg6UXyJyP0U5cceKDd8Rchq1qhcL5VGwDC/MidQYil77kwgsoo4AJyVZYQfKG70hQM6+PAmWLhXftKYrmvmyBHhagVsRHl7PCUvrxsvKtvg== X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 5:uGZ6dDfsOuHm2AXRckfCXx26tZAg3zg8mChY/mc4SU9LRrZM+VCvF94YZt55hmmpkMgpr4el9qcM4Pa4iPCouezQEo6eoLKeZabX3Z/pqp6Z3drvZ9PJh78O0tijuR3vHqf9mXUE98cp0MnaYLKDErorG7fH521lfWw04tVSwCtN99GrXMFdp4BT2Wup/FAFWwGoh/HdAzqCdHOQB0lb4Q79pyOU2c2bY6EynpJgwQBpEVfvRvjj9XiQ5+0z9AZgxc5oUttYLft91ltZ/CZFTPaK277/mS+VN92A8OxGEolpfvFDhLXdmrTVQTeE0khwcKrbMBpW6w0fNeeMTnEGJI7dNVMx6ZLPx2IMFlKBWhMDwn0Pb6xTr8rBgvKm5OhV+jfC15Kg5zgQwAM5VRdN/W5mQR7tsVDRI2Ftj8lfW+Wa9IRHVoTeJUPXaaFx4a15oc3ekmsLs9ZaywaoKvv1YkDCReDX9mXKKQBugnQO0W0q0MqHXlds2RWYZF0iT5QU; 24:Fhlj9fYJvwC03m7a6EQdWqHUmQL82ed2JiAyGNJ46EqulcVTyHpPbpH1swlSsRTbMM5tL4rai1uLC7oDd3P7XkhgRRpd+fdW1S1B5KMFEcU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 7:twJos63jHQLdN637rqK1C9V9i/ZDuWL6yR3dAnsv6C15qqsw87BZOoPJ0oll1rGyEQavuVfFRbA2D0XHx7jACAqy7mISz9dkUalgoILSII0gmDSwWTK2vPbg/aJm2lM6uLg0E64T2RFVNpN2+d0RGvj38PJm7oFq8ARpbbLK1UuNC5t2tkSe9mdZMcI5Z94p+m91t6/cGV5UqsjCDIAr5rLIW1jZrFCmvN64Rh8ImNIwQQNLIMsPLw04Pc85OYWoFsCt5o9ItIXKms2VRX+ZhgcoJpXtul6x7pBiYNFCRFnYEfTPq+JMNLn5zWkj+Bd+akbwzq6cJMIWNuLe/nVAGg==

Message ID

1497380813.13346.115.camel@cavium.com

State

New, archived

Headers

Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
Sender: libc-alpha-owner@sourceware.org
Message-ID: <1497380813.13346.115.camel@cavium.com>
Subject: Re: [PATCH] Patch 2 of 2 for ILP32 aarch64
From: Steve Ellcey <sellcey@cavium.com>
Reply-To: sellcey@cavium.com
To: Szabolcs Nagy <szabolcs.nagy@arm.com>, Steve Ellcey
	<sellcey@caviumnetworks.com>, Joseph Myers <joseph@codesourcery.com>
Cc: nd@arm.com, libc-alpha <libc-alpha@sourceware.org>
Date: Tue, 13 Jun 2017 12:06:53 -0700
In-Reply-To: <593FABC2.7020108@arm.com>
References: <1487781046.2866.153.camel@caviumnetworks.com>
	<alpine.DEB.2.20.1702221702490.8704@digraph.polyomino.org.uk>
	<1487879964.2866.181.camel@caviumnetworks.com>
	<alpine.DEB.2.20.1702240033550.6066@digraph.polyomino.org.uk>
	<1487980010.2866.198.camel@caviumnetworks.com>
	<593A60B1.6090100@arm.com>
	<593A7CEC.2040001@arm.com> <593E6999.6050405@arm.com>
	<1497284101.13346.104.camel@cavium.com> <593EC0AE.8070906@arm.com>
	<593FABC2.7020108@arm.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: None (protection.outlook.com: cavium.com does not designate
	permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2017 19:06:56.2440
	(UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3465

Commit Message

Steve Ellcey June 13, 2017, 7:06 p.m. UTC

  On Tue, 2017-06-13 at 10:09 +0100, Szabolcs Nagy wrote:
> 
> FAIL: nptl/tst-initializers1
> FAIL: nptl/tst-initializers1-c11
> FAIL: nptl/tst-initializers1-c89
> FAIL: nptl/tst-initializers1-c99
> FAIL: nptl/tst-initializers1-gnu11
> FAIL: nptl/tst-initializers1-gnu89
> FAIL: nptl/tst-initializers1-gnu99

I took a look at these failures and saw that
__PTHREAD_RWLOCK_INT_FLAGS_SHARED is only being set when in 64 bit
mode.  I updated sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h to
define this macro and that fixed these failures.  I will include that
change in my next patch submission (currently waiting on the kernel
patches).

Steve Ellcey
sellcey@cavium.com

% git diff sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h

diff mbox

Patch

diff --git a/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h
b/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h
index d13a75d..9aa9f04 100644
--- a/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h
+++ b/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h
@@ -65,5 +65,6 @@  struct __pthread_rwlock_arch_t
Â };
Â 
Â #define __PTHREAD_RWLOCK_ELISION_EXTRA 0
+#define __PTHREAD_RWLOCK_INT_FLAGS_SHARED 1
Â 
Â #endif /* bits/pthreadtypes.h */