From patchwork Sat Jun 10 19:58:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 20909 Received: (qmail 37818 invoked by alias); 10 Jun 2017 19:58:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 37482 invoked by uid 89); 10 Jun 2017 19:58:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 10 Jun 2017 19:58:29 +0000 Received: from ESESSHC010.ericsson.se (Unknown_Domain [153.88.183.48]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id C1.76.02061.46F4C395; Sat, 10 Jun 2017 21:58:28 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.48) with Microsoft SMTP Server (TLS) id 14.3.339.0; Sat, 10 Jun 2017 21:58:32 +0200 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from elxacz23q12.localdomain (80.216.243.234) by DBXPR07MB318.eurprd07.prod.outlook.com (2a01:111:e400:941d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.5; Sat, 10 Jun 2017 19:58:26 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 5/5] Add ATTRIBUTE_PRINTF to trace_start_error Date: Sat, 10 Jun 2017 21:58:09 +0200 Message-ID: <1497124689-11842-6-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1497124689-11842-1-git-send-email-simon.marchi@ericsson.com> References: <1497124689-11842-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: DB6PR1001CA0008.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::18) To DBXPR07MB318.eurprd07.prod.outlook.com (2a01:111:e400:941d::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ce0cb252-53a5-4129-c3ce-08d4b03b0f2f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:DBXPR07MB318; X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 3:u3Rt56lQhK2oYs4wBzoOfrqO1+C8qzvf6VZ79D2fi0hutu/85fcu6aV8vEhJyofr6GMd51aIe35PIuGQLfROVUgXBeb7KvBtZ9mfyAl563/HFfTZFsyjlv89se4HPwmTrJ2uP/n993++k+YTBTTr9Xpsb3EqA+T15shY+2eZyA0PWoSaThsVPJlpBKrKVWifGX/ytbEWPckUbln6+x4cPnxu1+zGgF40fz51yaYHDpvQlGcktzDn/mbTeJQe2La166/JRD49f8aA8UIE3ENpIPyRVD1/2jYGZrAp+T0v9mL/cuenoZnLyNEkimIuKP2/QMFfr4uE0nNMhLpyxFPsLg==; 25:GcnOBzE7gBClr+eZdCoTnOtkwHpk3aYyIXJEaqXxV2rUyv9h/5rky0iYhjlQAD/86CgOkzM8BXQVAfRiyQzU2WaSRJB+wgoqsWHOVnTSeIOiTJGOMEPPd6MUHGhcZzs5ys1KEh+1/Xa7T8knLgC4UnKkcrlQXZEtcGXE/ydOp2ORDamKZk8qjX49Ntn8gF2klVMZlLfLnryeSrLxQ0TZLhKi92f74NHh1bG1ZOWh3EAYJw6Yqp7PgOk9nuLGmTy8aW8ntddJlqcUnNX2wFJyy6wH07FaoBj5ZlqyyMypFT/7SpKfwhN0Gp280Mqd9nulZJCCiATYOsGa6+/eyDdyjUA+rTsoklyR2mqJ0XNf8jyuTEqSMtWssOKY5hTfKJ5GY3/IFaq4cwvd9YsmDfbU80AoXv5vRTdwSANywjQMPVNDBcuphvqryV2BipFP3S8rO4EA59V/hARde72Fsqd3ZMkWXmgv19MzIvlIjthnZ4Y= X-MS-TrafficTypeDiagnostic: DBXPR07MB318: X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 31:sj0RMSU6FArWvyFXLYBi4NO98BBWq1PeaF6XIFAsSDigHij1aPP66eU3ZZD0m+BYDVQ0SDV3KOg4wW6iygLgtwH11NDMObnSRP7N/fznRwE4mA7nKe46Krv+Jy7HfHoyXSs9us0ooL5ON8s+0J657ej2eJPyMjB2c2dPd7oE8FF+fk5jnaVFpyhkm9SvI/HJQfwet5tFvoSDLvNlO5ycr8kiyTYsYXaQvddxdzIEEok=; 20:peVRlo2wFbBokb2dZtjhkPeyhzgXKWykdZwH1v+4S9MRkul/W2L4G+bv9mBWcCzoNsBslGy+7gUibvKRND3iwgmKiJP8IyogBkGWHfmzGBpQSJm7jU1JfXpybuTBh6gxZTHk7ksz1QqgYkBvY/e7UVJ8a4JKpOBHrGkxdn4xFWaXbUr9TTw7nh/YndQ7EinB+cEO4bGLh2QDrXVKz46WUV+LZ6WfadNDUK6bK2i0rHyqy3yjYC1rAXXpHIf4u5rOWqRMRKfF+jRxs1mnqkqMFt5gXXGVeD5UbFFJ70gbKJc78t3xAV+wT3nM5WrHU5e0WoMo9aXunLDlcMyNMryYXcrsjnUlO9kauQe7Y6neLjShGGcJDk5QpSO3FuD5yCZkV/C7xWxrpqX+u5VLG8xk4GN2ssocVXrfKvzxJYZIhqJfdT9jOxs8EtF1qBhNU7qKvqb6WOMoDyoNX5pfqssHw9DM4cRA0tlb2Vz3TpngilMFqMBzSUy8tb1XqJAMmmvI X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123560025)(20161123562025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DBXPR07MB318; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DBXPR07MB318; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB318; 4:BpuusNBkPu39otDDjoGwiol6wEOkGymrZF4vE4w+n4w?= =?us-ascii?Q?K4Gcwpn6GHxztvMcPzYlgNGxeaCgytYwvAoi5695SqrHVXD3mfL5eSI25ihp?= =?us-ascii?Q?quRtBPVvd8ELF42/NwV/wJ5J4CF3YNGHQDXGDiSZu8tYziIRYpu+NOr+UBUg?= =?us-ascii?Q?V+ewD/3CMKAjjWoaZoBNcGwr+VLfQG+hNnUKNH9ujtJWbgeyeWAE6ylncF1E?= =?us-ascii?Q?RKjgExyknuCJSc+LJDC1jOi/5lYIDUF0cD+SojaJwmBF9FUy9+bjELaeKVuB?= =?us-ascii?Q?+RsSepjymYUH1T88B7ePgy6Y3G2xv+MssodgfTtSTpJpYf6WijZ/fRr2GsAT?= =?us-ascii?Q?HsUQjyuq0wD5iB+DMJb5Fzhq/Ohr5EWIMN7CsTyh8SpK0ZUcEl3ABJcBd5GY?= =?us-ascii?Q?GS8jj5xTEj31nWC0FJrGmPv3XlXcJMVLyilF7g0UnKiefmPeDasY3WElcnTb?= =?us-ascii?Q?F0WLyrQKedYZ41rfUD0cahq0BjftXb0+UKGB4buUvPdXY0tL6GoDTvklg+oo?= =?us-ascii?Q?uMQLJH/ea9RBbi0qo8fU+tt0eu27Z4KCocqLLUroIOqDO1Ob6HaHUKU4mFT+?= =?us-ascii?Q?TO42xhAFobz8I7wQ2FEbxZ3Ck8ZguflWDHk3yGIasnGIafi2r2xvbIvSbIdH?= =?us-ascii?Q?nuPXWrwFGiwkkizuOhQ7UNQA4V9EOiqVJBuszhHIYMi1cu1vdss1SIFLVlAb?= =?us-ascii?Q?xRM7v4rig7H18DGJ5kux5JqxJRSNQHa5DeVPLgIW1YbXtC2bcBJt+AXKqjoW?= =?us-ascii?Q?fUQPmfdmEqqA9F+b/rE0WF8P7/j8kBnu3k5hshlxW5Rs20ZXKk8GmSGuKrTo?= =?us-ascii?Q?ysArmENFqM7ADCcJrKDUl9PWNNi+CDGuTlzvhZOJH8DGxQy70wz9PJkUlKws?= =?us-ascii?Q?GxfRXWzqBi3Ei84dnB+CSd0PhTfOMl2FoQkHqzdK/ahLIBluXHdzsT9wvbBv?= =?us-ascii?Q?6hyv+8tIpEcqHl7rpe0lX98rxCBUZPkXVS3oFSS5uGLuXGlunzMxJRR9XdEU?= =?us-ascii?Q?by1hhd6mz4kVxXRF0TWUq1/wZPfXHoWmeqQTlesi1GWNJ6/Q9nt5ws8DMIyO?= =?us-ascii?Q?itTkTcBMHI6uSBDpEANpUPUQQFBd1MUJjAAfGxcEaRKjaM1UGgJwK8EdGtNH?= =?us-ascii?Q?IsZJJ8Ba0PFxzRBYLWhyyDmX4bQFH?= X-Forefront-PRVS: 0334223192 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39450400003)(39850400002)(39400400002)(39410400002)(39840400002)(54534003)(66066001)(81166006)(478600001)(50226002)(47776003)(189998001)(38730400002)(107886003)(6506006)(5003940100001)(50986999)(53936002)(6512007)(2950100002)(6916009)(76176999)(8676002)(110136004)(86362001)(305945005)(7736002)(2351001)(3846002)(2361001)(2906002)(6666003)(33646002)(25786009)(36756003)(48376002)(42186005)(4326008)(6486002)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:DBXPR07MB318; H:elxacz23q12.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB318; 23:UC4GHaOY4Plsj1QbmoOGTotz9F5SmP33tqG/wdMsl8?= =?us-ascii?Q?VHywmaaBkr3El55kOXVS9BPMhc9GNvSfymXIBT8kkTdSb1HRWkmpbVXBe+LS?= =?us-ascii?Q?t9NYXMDhZZP4kiPjVwPwidgp1sXcc+6Ed58VuzzrkGE8eJg1/DJcJIXeZ7pR?= =?us-ascii?Q?4ICUCcy1sigfg+ihtlo++p4+VID9X0RRuTG3hp6Wan1yUmpq7/pE9dT82kCN?= =?us-ascii?Q?1lvU0r8lSezWpMjtHDm9EYTci/rcluur4ktHBqKmCvCfvG86iiHr/hEFJqCX?= =?us-ascii?Q?f8psNbUwMabwce/oiqX1/8gJ++1hCwbbjRpytAoTzWsEB0/FJar2/5mVhkue?= =?us-ascii?Q?sLPoGbEVrWk4Ymp7F+ltvsViVd+whzTfBxqVzBhmDWEydNyAF2ZsAO2lXnDb?= =?us-ascii?Q?ALAgpRipA73+++nwGbO8uCtVaSo6R93fpHYklSIJ52MUegrDonmHJdTOczD+?= =?us-ascii?Q?qZYyXulstXTkHxaDFytJphug7FJv5EvBVSH5eKPBMTtdsHVD3tbphCZ+Ntt2?= =?us-ascii?Q?pEzDzwdB/hXRlSMechpUcioVGvD5epQEK94ram+6eLBPTaWh2rw/WGLk6N6G?= =?us-ascii?Q?HMRwnZ8CwrFCtz8tGIl4kcv6ctRC7wz+HPqp6XobYuAjt/5b6qVRJF+dVek3?= =?us-ascii?Q?/jZnmP+Edj7Y3NN9D1Lg7b4jlTOdU7Vxykypi6+PqfILjMY2yj2ZyE3HJF63?= =?us-ascii?Q?R7GMgx62S9U5sEzUL1DowDfnCfTrCgSSq6+zm+lDUzn5SodQ8urf+D6aa8R0?= =?us-ascii?Q?Gq0UekVk5ZMj+Jl8WcHVT0R2tCPOyjZKG7l+CA37sUPRhsHqBx7s2FDHvMFZ?= =?us-ascii?Q?bR2Yn7gsFrIkksgXiwXSKUGhl6g75JA9tPmxk0cN788xYSKizYIADJn0DUuF?= =?us-ascii?Q?3OCOZZj7HxOqrAbe/4drYOs96QQCLMh5jkniCKRAr00GC1xA/5gtqIZ5inbB?= =?us-ascii?Q?LcoYNqwtLqxT/wd72C2q0VdAGFkE5yQ7lUPW9rlxh65EIIStmPI55hCidwrk?= =?us-ascii?Q?hiCLit/wZ9N0J8pYNzdixk7+PB7sfSbBhi5hHGvpS62iE5Naj2PL1PpXG/OS?= =?us-ascii?Q?UqJ1XWx0K/3/+DGuL+OqeVtXG0?= X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 6:X+zDvO/2gxyS41sCEMzLFYdGxC4sVlkPiEcEsFRTKkfL7DOlebQo6PXzwuQf9wzpmHml3x5V+j2bAZPdRxnp2LFs0RxSv3h9x3BXON6OoaHLhtPcHbw3w9OHf8NwnGGEcHe1SN4gWpOC8fu9eI6uSoAurOTmXLaQXjzTF3LFOYIqEvVMDpXAYnVpB2ui1WZNqwZhSE7xA1rqJlDJVx6KmeqUe/3U08G+T5tXZJT/Hm7eoGPwOg9Y4xB5gX8OzZKPlo0ngj5WBV0KswJmAspy7ozLl+5xmhH/25h3l5n6OIeVkYuuOOZ8HGhV2STbfet7ORaZWlaTZAogo1YGIWjUVPZ66OwxpD7bFcHP9EJ9MBMrpXEKK4F3UbNPe5EE3/LDdKO38La15r6o8E4eqCD5hKhnN7czU6WLWLhB2K8Bi9io4m8c80A2u55LYI5SCgNsHUM6Djq6oWh9nGtnFS0clHefn19JYWVb/KUIr8m5L+Xd95O7ZKWklLpVkfv60PJmBLKypaFWNHpjDrq4HrIzVg== X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 5:loGYFYYOIJHc4GUXq8z14Dhf0bkT4gkhDoEAf5ZmbViB+QM1d4Q7wcTcNXpuP5MQ3gtg0x2Mf/3CJ6Pj/ayQ6rBK6vefq7lWjzu7WWe97uENa6KB8d1XkrP5zWGZyzwsPXWGQBs2x91sabe5cKiUqUcUhW2o47soAwFzTEwahdzUfeSDYSL68IR9l1piICCORQYbzhvluEBroDdUPsLDhAYr2AmBkKXQhtwZ0UaEwmIdV8h46XvPZQV0msTIvy5ghIvZ9KcA6FRD+CzuUdqPINip10170LCdultrYeUVhv0EsB6Sd2HKshNLY8zvsG80gy8nkrqnm9OOc0RFJSCzJAx+3mTLYNLlm0IcgV0eiM/WwL1AGLink+rgyGMjUVys+uk7IxX+9nbYi3vvm/MXEbxCCdzkia4TPlAaj7Lac6lcd4+tjtpAyw43bl9SNwb3x6r/9fwrI+g8NwSqAscOu3PmhZBY4F01fIJeCBRhjMcAD7QfeZEbOcaVpVibUb0v; 24:/4IOTbP/E147qovhE51alWs12XnSboDcD7w4k3ACdIYMHxqZaM5SVoih1VmIKOwas61Eb0vJarLitWF68V7suFNIP4fAYZ2Hc1AI98Zf8kg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 7:RVX4HnpYb0LA3EhOBsbzH5y559ze0stx4zW+Sxybg9iOw4hZQAjxuqoeVIMmU+hihlZ9Gph1+10Jf0EZWQHNwLSbwt+yFNd6mpnAk2ZT5wJAeU1J+Twk8yfjDrkPXWwNw9zPENHHo20E1rvN+W/6o2S7QB7wN8NWDv6xLla6vhKwLhu889GTb30G1fNpPwihN+BuFWz9B6Yv+reHpSI8KKFrhuKHFE/qvbqIerZGoCuiRsCbE21IwXWTYkx7SgXtVEHDVFP60+EqH2h6n07OmlsWwIyAXq2CihFETr+utnX4cYKMzdzOyIJi9cs6csYYTinXgI8EXgvWiZX2w3CAjA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2017 19:58:26.8086 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB318 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes clang complains that the fmt passed to vwarning in trace_start_error is not a literal. This looks like a fair warning, which can be removed by adding ATTRIBUTE_PRINTF to the declaration of trace_start_error. gdb/ChangeLog: * nat/fork-inferior.h (trace_start_error): Add ATTRIBUTE_PRINTF. --- gdb/nat/fork-inferior.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/nat/fork-inferior.h b/gdb/nat/fork-inferior.h index 10e3832..d369cff 100644 --- a/gdb/nat/fork-inferior.h +++ b/gdb/nat/fork-inferior.h @@ -95,7 +95,7 @@ extern void gdb_flush_out_err (); (i.e., when the "traceme_fun" callback is called on fork_inferior) and bail out. This function does not return. */ extern void trace_start_error (const char *fmt, ...) - ATTRIBUTE_NORETURN; + ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2); /* Like "trace_start_error", but the error message is constructed by combining STRING with the system error message for errno. This