From patchwork Sat Jun 10 19:58:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 20907 Received: (qmail 36647 invoked by alias); 10 Jun 2017 19:58:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 35713 invoked by uid 89); 10 Jun 2017 19:58:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=(unknown) X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 10 Jun 2017 19:58:25 +0000 Received: from ESESSHC020.ericsson.se (Unknown_Domain [153.88.183.78]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 41.76.02061.26F4C395; Sat, 10 Jun 2017 21:58:26 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.78) with Microsoft SMTP Server (TLS) id 14.3.339.0; Sat, 10 Jun 2017 21:58:30 +0200 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from elxacz23q12.localdomain (80.216.243.234) by DBXPR07MB318.eurprd07.prod.outlook.com (2a01:111:e400:941d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.5; Sat, 10 Jun 2017 19:58:25 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 4/5] linux-low: Remove usage of "register" keyword Date: Sat, 10 Jun 2017 21:58:08 +0200 Message-ID: <1497124689-11842-5-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1497124689-11842-1-git-send-email-simon.marchi@ericsson.com> References: <1497124689-11842-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: DB6PR1001CA0008.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::18) To DBXPR07MB318.eurprd07.prod.outlook.com (2a01:111:e400:941d::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8434ad83-02eb-4930-f5fb-08d4b03b0e1f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:DBXPR07MB318; X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 3:huQG4IHtS+xJQ8Rt0iPTR61jEJVRhHiWwckroPPCjiipCddogLBhXofOLltJR9dtJ34oNFQrb1urJGJuAe5yuEHGy3AHwcdyNIX2SuqwkG4bSUQ/QtjIVsAu45xaYHfMCGK9yBf/5dT9nN0uH6DYyjGGsTxSBfIcceNqnwp72QFZzfStivKTF2TeKeyoLIe6acAUqt4Ed6+LU9ByXoDVdtJD+iv5WyTX6iDJS/CErs5kCVIUnfggUiv7KOlVuCJdqP9cVAVS1jvxWXJ3uJs3BTB93Zkv9UnMa64WqNC6oW/SFi6e+KG9jT2UIrAbsvFf65Q8CfA61oeSZ4ttII/DXQ==; 25:ZDurvT/A4wTbOFD31WhWw/DfXHa4RWugkbPa2O+gDNBj69Gen8psYz7343A1YM9rxWC5ASKdQ3svYWcYlImAf943+x+Nxk5SppiY6f8pLL8di9ONj+NThrMEc/13IEqR6D2KslkMZOFuG1pRU6FRbuYiZMFy84hB0vr01fDSA2CowzvBdgmRQ1sHPb3o/52tl51sidrcj1brxA0H/XXi17rt4rav6QSf3Ua78yrBe1hDAqQnqhjMtvK/n/e081b0OiHWSUHyuX1KpcGlxC9vjpxIpmuOYShMRUx5zWA5UZZEVDfMthyax+S0BrcCXaV7f5iHmcVgarkvI8e+1RiCwuAgTKIOSK2kXLGJnaNXRBSXjsSleid9v90GP5kB9fcitCOaBaVTdBsMHKH+Qz+JvLHZBt327al/+WwEPhWoDP6zZRaXrFPibNj5fc97+fmdBrJbyzTMSoCH/mribDddmxJOaNO5H+WTxP26zsUGPYw= X-MS-TrafficTypeDiagnostic: DBXPR07MB318: X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 31:hN2GkVwIPoX8wnEacnLspY4AAaBkqPPwG0hAgwYdnS31zgeXYFGav62FWJd9UFP6JsDOZnCgUw4Nyqu/kpVBNUoZM2cwZw2hxMLPtZTXt79uxfG/GVP6OZWhOz2/+x3Yv594c+ubVv3DE2o+kQegYUf4MyjfeilWBAEZxPdoCImGqBuY3PN73f8ZdBAxIUg97aVK5+npQCYU45UA39ArV1vNq1IrmQ4ZAJH7L5JV2VM=; 20:3XQgtjysZ9Wx7qr6GxdJ4jmwQ4L3KB8mjRDWnTqm5kN20zPlhv41RRNUeZIB6f0R9fvyVsbaRfmfL1FIR095G2HC7YW2Gtw3j78NhBNjvKHNrF9WG5O9Wj09CamuUcrx5KzqxgVNu4ysRxOBWhAxo2JdI4U3NYRbX1dH7XsJBMcLjbgdnwqEBVCsUCjGYiK8uuznh4vaethJNW0Ik56GPn/8Cf7Ec8dPZQhpWBxmokr68KTk8pX2lPWOzD1105jVjHzCx9FqNEpMtJ4lIxeA+eSYOzSVMpV/Y3vI2/Xhn+8hniMtOVuzKNSa1b8rlvsJSUV3/4T9VuXhF9CC7jNcWJbW8S1SYyy70JLMICSmk7uGLikhMpXmszOQMHy9QNrjlurT0bwlEKndR8Lwb9Dsby3eVUq2VqfzVpFf+Od8mLvVTu8v420pbaehHatEQwRIr/gJ5ayHHFIyGxkEKZGZlLzC+NyBNC7C/vNvvhbtTT12Uv51QYSIZ7EmCLUvsLSA X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123560025)(20161123562025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DBXPR07MB318; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DBXPR07MB318; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB318; 4:ufmJJ+OwKAeNvJJMx4+KIDJ1oLgwFhdTYGiQKsuyYEK?= =?us-ascii?Q?bxXmBYcX8CeptMkYJQLuXC1cqgy8oiFrJzV7chHJVdtek5ZLcKi8I4RUC9mz?= =?us-ascii?Q?PQubQWuh1O3uaBt4gon1g8o1Dg+np7UESpblEy3ZUi8bZc8v1vQz+mej219U?= =?us-ascii?Q?K6/skuKv3SFSbBZ7hC0HFCdNNrqZvon6ve9Or49gABCQclW1m/14RCsTA8N0?= =?us-ascii?Q?s59tAYpcEVhlMrw5CnsmZgb2vywHFlBKoKXUdFfspf4Hy8COSUABlEOZGyF0?= =?us-ascii?Q?gsOpdCPdw48oDqI6dEoiKNubU8Ez/ljpgOrduqiaHxh0F8CLP3hpy8HDCqJu?= =?us-ascii?Q?DwM/J+82xP5ZVYONZI/TD70FLR7IvIH1ary4NQsdpOVHK0+iuULoTuxXoQuD?= =?us-ascii?Q?8AMFRvmNd1X0bIKrZ9/Peeq0tU02WlidgMIybagpaB2O7wpEYe6vQw6e3aGf?= =?us-ascii?Q?LETg6MS7db+9Q1YIjr/L27xFvinoQTzBlqmzSLd7Le7pUsFcn6/IfsYOpljD?= =?us-ascii?Q?38TTfWmrMSOE44Kyv6EpJlPH1vGEWZvq0VnkhzNg1qNV1qoYtVhS52qrX8OL?= =?us-ascii?Q?dH0iHiWXLFs6RKhU7R5O16umGzYhXUS8cuapbFr8g1Ur6LrjzpVLWjdWpwJQ?= =?us-ascii?Q?Hl/RLybvVSvAjgnxpHYVl65rJ2Y/Jc7e6MIOUwk61VNoqddxlEf8rxqwEH8f?= =?us-ascii?Q?eJ8odtAJMSMmHR0UAWvnIZj3B14NuvsiQKWgia41xRrOCdF53L66j06GAKiz?= =?us-ascii?Q?6UJumQcqLbP2ATgE/rKw0LwXvd4yfb9ekrzX74KYuoFd2hT+yUmBmhWWChrp?= =?us-ascii?Q?Zo/uOUHO0ZWMYo92aeX67uUldtWfYdxpJ5U9gyjv7ONgB5NASz5FOVOyvwZ3?= =?us-ascii?Q?0W4nxQLETbm14lZvRqJRH86PdvKGNu21ulPUJFP6+vZrKHCaQ+DXxYr1lP2/?= =?us-ascii?Q?WWFaKZWgrnOWAB68Sp6Q26wHX8+RHrOhjL+G4Mz/3a5lU+lsCCAa7j1w1sdX?= =?us-ascii?Q?7L5ComafXl7q6NEUaaaAGqfOB8U1sA8Vn72fOsDz7dOqbCy/cDiZ42wkfKT8?= =?us-ascii?Q?LdZDeM224dz1/iSKSe65CSgKkffagxscH69dHM4Z4OAIWfGAST/dsYeOoeJN?= =?us-ascii?Q?hpK3xSbts9GD0gUNpdfxTsAU3Oc3O?= X-Forefront-PRVS: 0334223192 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39450400003)(39850400002)(39400400002)(39410400002)(39840400002)(54534003)(66066001)(81166006)(478600001)(50226002)(47776003)(189998001)(38730400002)(107886003)(6506006)(5003940100001)(50986999)(53936002)(6512007)(2950100002)(6916009)(76176999)(8676002)(110136004)(86362001)(305945005)(7736002)(2351001)(3846002)(2361001)(2906002)(6666003)(33646002)(25786009)(36756003)(48376002)(42186005)(4326008)(6486002)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:DBXPR07MB318; H:elxacz23q12.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB318; 23:vJmj39bhtVqhyqSHAFuusmX+7pI/ztaIi+zeUawiGv?= =?us-ascii?Q?6ebEHWr/oAtAg9tSLNVaA6REfIjyv2VJNNWzv159GzMVI57s/6fh4kzajQ3W?= =?us-ascii?Q?eaA59BAFjWj8IzIlqGHzeSU52hzLk8HtvW0IlpSlOUfQ93Jfpz3qhEm7VbOu?= =?us-ascii?Q?5CjIDA/MpryhXv+e8CCpzSVZ3Vyb41DW6zB/Eq+/3MQJvk3eZ8Xjhkt851gY?= =?us-ascii?Q?b0rfeeKC/O5VCT/WLa1n1Jbti/E8K3zYXSEZcpJsrkjddIBS65cqzBXZd4Eb?= =?us-ascii?Q?+5sXnQ62710shOnAT6ZJWeUH3Q1wIbKMNfH5ZTTsDRZGWIQkzXNwL2m7WDAU?= =?us-ascii?Q?/tp5LZn2AIKgqUv1FMlQhwmK4hlLRNbuHev2iqaNorD1ce8VVXMX+RoOHFQl?= =?us-ascii?Q?snlAsdz3JVbJkD5DTXAp3cuQ+FaUjCrCrMwSwrLLu3uWoLpxEYu2eyKpP8i/?= =?us-ascii?Q?pgt9PHRx0EBCz9Yji8aGJfX/20pkALW2adWQqLxlceTte3QDWT54s/aTqNPQ?= =?us-ascii?Q?Mq/fowRDsUCand0U6iOzQQk/hkT6T8PKM6xb6prTcN4PyH5N4/5uqr/HaBrI?= =?us-ascii?Q?IS8zpJPyN9JgzV7WA1rC8LO8X3h7YODF2gNZEzT8gcGBiWrdVMKJ7PvEtNty?= =?us-ascii?Q?cYb+EKX9xzkBdyPyz9KSQ4++twah/wBChcIaKgsjm+Mzhrpg31HWh0Eqo/RH?= =?us-ascii?Q?bXaFBFRsCY6NtBfFOMUEkjGajsDOnP9h3X5HTZ99PlYsRrT574HJ57TJQz3a?= =?us-ascii?Q?Jb/fC8tNeU/UK/xsw4AspCWJf7M8PFhz5vtwWnSi3EpzlQhOz2X78HwvZF6q?= =?us-ascii?Q?mDGT5TNQUbKnfmNHYcD9tUqExP+SMKuu6yt36B7SYwHMSkcvTtSvPQ9e1A0h?= =?us-ascii?Q?NV/FwwKQg9rILbL56+NWWqaer0z182Q7CKw4NJhWtT8TTLZ5UYdmIlSMRILe?= =?us-ascii?Q?FbZIP3oAUnYDvMWqdUKVg/b20VeNglyt5lbDHXOFRSBlngN2A4diW/j1BFst?= =?us-ascii?Q?sGzVDoYpzDzUAU0Ru1dY0545/FlYT7So26MhO/HpKGZdKKHXdxBFrT6Gidel?= =?us-ascii?Q?h/3zs9Xxl3ATRJXLfleQmwoJn8?= X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 6:OsS2EujuL6Fn7Xe+pO298CU7xf1Lezkt5gej/T+qzJPyk9byGUWTiT4qpsr8umUZyYw3n+m2/R1PlsETCKdv1QNTJ6K3FJdX3uDHRjDy0C+UJZOTKH4+aK3TasP7s/XjKQG9DLRACZNAIYZDLZZtBZ+md3Se9hzAdRHLLMXoN57vFBVOnVDjCI6Tm6mVRE4pRJv/2To3U2tQ8UtmqTy/RknHSYYB5mgnETCJQrAH5hfnxnPcQ3+8HFeny7IZRPCRV9bM+v389A4LA45A0cBpzeDn26MLlMqikNRADR1VBdhpdht5Fvs4GBUNwgvqu3NH51201S3T4W+lqvKNPqc0cq81OWRjeazuX7pkVbY4CoalZPpiU61t8SQ3wBCOADLmKKE1vpU5kib2goIpaxCmfQFq/B2kD3GfviFbptbou3MwN5xmUMjwJxe6Me9BvqysVx9g6WAn+59jegBFXMPQ2gbV5IiEQ/TGDNtx8jYwVcvqY4NtKzTdg44G8mqLS0SD9P9nbZJIQyOaS+UGGvQhbw== X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 5:T1IcGxnU23omO9uIw63LcMFuemb7e+BhUvUR3y/NCPP3806FtqZYcf523CYft2xFPXP+3QY7BnO3jnZED3Nu8/Z1BxXNlXqi25YOqyVbSaU8nJHsFNq+nDe9qBMwl+pbt69BMYPxzZHwU4L645XgxMxdwLvWz95iYAv0wmahrIYpv92+opA+4k/0wcIn3U63zmoMb/8io3XnCQjU3cHA1SyU3PzBXINPbHdGprvpBz+SZ08PI5EoHxvs9cHv8Z5z70T6ObWOncb60HzK4SU8LiY/6zV538iCcIaCQK1O9bHvt/+ynITFGCqGZBcK2NL/3q0K3bbocO4MDBSYmhWFqQDF4JU/Gx63FNEwC8chj5kEeqHZIQw6F7Qe/JgeUP8eUrjCGN/2gzSzyPQcfUHkqaKsDJjcr8TY2qu4MF1Na1NchFOWQ7epzvAAaZKchcoQO5gcuEWXSfFvdqlmuyI7Y2vNnISHN8eunXmZwopyCmjDJCgWVUn1VtTa6isXVmoB; 24:GkrcdO1Fm/UefS15mf0y57jmm3wAiZCeorDDW9fiWCV32iu3o50YNHljj3hQnkES62jO6jEHuXj7GsxioyCeVBhTDQraqu9Ax1VCWLYtj6o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 7:uEQR00dXiD9PoihQeUbAk7x1Sgxxi3dlk3nqGnCXqxvkNPWGpS/TJr8Z1SIf3bSyIfNj5mKvFAFsGgB7OgrVU6wF9c1Ls0OSSCiIR7VUYL1UE4AzABqzUGQXQ9nKZ+Y5C7PBM1QM3vm6Aten1x4EkOLSYVf8EVvc36Iuijh9qDmz1LxuQgcaVnx9pPdQhWrXunAOYHs5LgDGEGnBg9nXMuBPB4VfsFxIe/9OI+Xj1P1EcJ6MMuVffCKBUDjGTC0mIbOKhBNHGZDloycQ5bCnxkfdlGqmYxjM+oyvP4QMu6+nDdB0Ckm87lD4/gIaYfdruCWoqPC5OqaGWfeS7wo0bg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2017 19:58:25.0117 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB318 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes AFAIK, the register keyword is not relevant today, and clang complains about it: /home/emaisin/src/binutils-gdb/gdb/gdbserver/linux-low.c:5873:3: error: 'register' storage class specifier is deprecated and incompatible with C++1z [-Werror,-Wdeprecated-register] register PTRACE_XFER_TYPE *buffer; ^~~~~~~~~ I think we can safely remove it. gdb/gdbserver/ChangeLog: * linux-low.c (linux_read_memory, linux_write_memory): Remove usage of "register" keyword. --- gdb/gdbserver/linux-low.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index 7fbf744..c8e8d08 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -5870,11 +5870,11 @@ static int linux_read_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len) { int pid = lwpid_of (current_thread); - register PTRACE_XFER_TYPE *buffer; - register CORE_ADDR addr; - register int count; + PTRACE_XFER_TYPE *buffer; + CORE_ADDR addr; + int count; char filename[64]; - register int i; + int i; int ret; int fd; @@ -5958,16 +5958,16 @@ linux_read_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len) static int linux_write_memory (CORE_ADDR memaddr, const unsigned char *myaddr, int len) { - register int i; + int i; /* Round starting address down to longword boundary. */ - register CORE_ADDR addr = memaddr & -(CORE_ADDR) sizeof (PTRACE_XFER_TYPE); + CORE_ADDR addr = memaddr & -(CORE_ADDR) sizeof (PTRACE_XFER_TYPE); /* Round ending address up; get number of longwords that makes. */ - register int count + int count = (((memaddr + len) - addr) + sizeof (PTRACE_XFER_TYPE) - 1) / sizeof (PTRACE_XFER_TYPE); /* Allocate buffer of that many longwords. */ - register PTRACE_XFER_TYPE *buffer = XALLOCAVEC (PTRACE_XFER_TYPE, count); + PTRACE_XFER_TYPE *buffer = XALLOCAVEC (PTRACE_XFER_TYPE, count); int pid = lwpid_of (current_thread);