From patchwork Sat Jun 10 19:58:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 20906 Received: (qmail 36549 invoked by alias); 10 Jun 2017 19:58:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 35398 invoked by uid 89); 10 Jun 2017 19:58:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=conclude X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 10 Jun 2017 19:58:24 +0000 Received: from ESESSHC020.ericsson.se (Unknown_Domain [153.88.183.78]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 91.28.19050.06F4C395; Sat, 10 Jun 2017 21:58:25 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.78) with Microsoft SMTP Server (TLS) id 14.3.339.0; Sat, 10 Jun 2017 21:58:28 +0200 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from elxacz23q12.localdomain (80.216.243.234) by DBXPR07MB318.eurprd07.prod.outlook.com (2a01:111:e400:941d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.5; Sat, 10 Jun 2017 19:58:22 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 2/5] gdb: Use -Werror when checking for (un)supported warning flags Date: Sat, 10 Jun 2017 21:58:06 +0200 Message-ID: <1497124689-11842-3-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1497124689-11842-1-git-send-email-simon.marchi@ericsson.com> References: <1497124689-11842-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: DB6PR1001CA0008.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::18) To DBXPR07MB318.eurprd07.prod.outlook.com (2a01:111:e400:941d::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62bb1b6a-447e-4829-b54e-08d4b03b0cbc X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:DBXPR07MB318; X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 3:lfzHGkie2AJyrKFFc8Q1uqqP5SIWvHlR/Y6X9QpAZBEWT1ahOlJxOOASaKk/shWSNW6pn6WQJEzBjS/PaAUePtU1JhietOT6UW/AfkFCs2GSlzv1YKES2QqBwcOwix/TjqXIKFsla+7vK3/mq/Bm6/2OfxzMqoKNIIvA8NFGdLfchk8JP31I30n4+uEJcxnsp+PG05ElBrpikkWGdayIc3zC0EFNvPfFbxZCOb0D42YRn4APkxIiLtTw8DUMB1nn4Lbb9Caf2s8Ikkfzk2vpNubfziN8b0drpLuSmV32ttOUd6ZwrCBr4r0j4jA913P/YAtF8lp49crnrMP7iFH7LQ==; 25:Myi/vcaDsiodZUH1zhfk9hoN2aPeQ/EqUhCvXxi8VDl6EBHp4rKu6/PQav8pr/3uOnJCRDoFyfmO22j3ZcOGR3F6ut8ul6eVmWR2Ripm2rBThevXWnUnKAHhWb+ak92TOCl4V1SD7VuWGFWaH9IIbysdOTX5yfwvMtCgrzPmvO6PhvYuyzH3MDXm9CJizZ8TEzzba0LBaBdMtyk02aeptIAR2dF/7DGeLzzWBakk6FaYYrMOa/xfNsT7N86B2gAaZYi9fEWvmuiMKMLVc0GSjdx+fsuEbCy8lycUS5Wp/L4cSMkw3u1QbEFt8V4pd4OK2vgXEzbCbeCLGKmI5uVrcZ9XO5cojpdaBc4q0kL4gCVxDoSkMA4d6oIwqqj0obQXKzrVEawlcvbQkihK9yLrljKQ3L9fPHZ1rv42sv2TadasKXDWyVi6l9PKw/pas7dJnhuTe6C+pt8gy+39WbS7nIGl6h41FJtDHLokMd1lX6s= X-MS-TrafficTypeDiagnostic: DBXPR07MB318: X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 31:r+FTgANXYmHWno6W62svHyOTeYTjwXyMDmmbBcHNGda92moHJZXvRpDojpaGO34Q89IqRn296GjBwZDs4O0UED34/gliUVHoQzEpHpoADQcRfQCmwiXVVw4Iu3Dycc8S6LTQyUJb9NwCQBVp38WInra3gvyBwNpfLt2ry8CGyybOgdSaMYfu+V6dQqywp+A6c5ha+gMwJzg5/dlRqvetXfA60GHoFNzQPJ3nJCtxDjs=; 20:sUlXxwz/C1pCubeLJbKxj4BTdV5uM1jbIM/09/bne5/Q9gFdewfXBFCsikAGfX9QdMvmHi4aZJXc8qafhnWH9k+zSLFqqPMFV+UnkU/6sP5ls2XGh07HHkEMs/1QkhdSj+IJIi4xZiI0rGpnnz0YgwK+Rg/5Vg/hb7wGh17QENJdGWSFKbxfsYBE4mfNhAxNlE1lh45lvuy1bYx1dmn8cyO9159bOAzQDfT/j33pAubdcadKgmk/Dk+I3NymSKCL9YdrGUFXGPd7DxxR+QSS4mDBsHp4czaZiixSPHwjzuFUrsjDjiSp7RNroGyfZcVIXlnp7cC11AhBKkDcHiKASRGmf6lFU1pqSUO+VRnXPZ/19kUwDsVrfoHLXai1v14PJDB+rhmw6IeOeUViHVIZWY3xHUm3jsplfx6pl5g1aowDWsM2IYXmsoBcgfADiQ0OuZt24PHemEsVuhjUks5w7F19cReevNW24u3YmGq8ycFYv0C1WE110Uo2YUQ9imVJ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123560025)(20161123562025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DBXPR07MB318; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DBXPR07MB318; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB318; 4:M8RuHTkwEPK8Xy1XwRZcCqT1PhULXJYDPmwZEBurt3X?= =?us-ascii?Q?BW44onUqFHT2aj5A89VZXzZhZGxmovSxEpmKAsEK3tMoTqV63dUUm2cCvRMX?= =?us-ascii?Q?DWR/YtvHGf/Qnfq4epzJMcPoZdXKSG+TZsVkHYMmfvNzykJ6enePIu1huT/R?= =?us-ascii?Q?8i//DWzJI451aK51assdqkWztrNr3QyGYrmqvnpTuZhOC4vrrVrlqW+IIR33?= =?us-ascii?Q?DTLoW6/tpx6WkBTnpfOZYPqYHlaW0l1mQO8HWVo24zv62EPrgwAzmm2N1apO?= =?us-ascii?Q?99iASYd1im2ejaJoq4xApl+r2PeYeAJmoAuJEdv/SZRimUYVJjm5ADCStexI?= =?us-ascii?Q?oKF09p+pkyCEJomQibx/xqgRce9tfuyH1uIoyKl/mpgiU4PAxs3XbC44vKBm?= =?us-ascii?Q?izhdzw5ZUru9MARjWZzFAMPPvC/5A2Hubv5jIhPOiCHpCgwlErmnvTk3dZqh?= =?us-ascii?Q?7u+jTw+5Qse1O3Ja2H13u9ueDKWrI3Yqmz2qZA7gAiUc95nu52ea6u1YIFBg?= =?us-ascii?Q?Ous0tZJs+TlKyTB0ltlYupVoe53wzus/ICMQax2+y2KYavj9lhqLkOT31RaU?= =?us-ascii?Q?EaIY/5cAhZ6ZXcziYQKMZ4QSICbLCzyODFvAEGVQvejPpY2hZb8jMmChoU0i?= =?us-ascii?Q?PzJt6VH2MWVohCtwHZqUG0KLn/agLTBaAQV/2I4bO0vaWk2VAmLic0yA5LZG?= =?us-ascii?Q?+ATcs4lQzVylLsI3xtjTm4NBD0t/2L7yDjekEQQlAz6xGzvtNhy0gHJsD9TD?= =?us-ascii?Q?qeRT4iBragCiwaCAX/FxdfCcIXtY7UraCwlm0bn9z8Q7gANUeLv2wZDcJe6r?= =?us-ascii?Q?KSWqjrUuGSDc3dOhzxjt+zUjs406h/HBX6+48zPJLHA22ITJXgf0pyKPlvP7?= =?us-ascii?Q?ZCUKUAJ6aVr3HAMsO3gWt0GCIO6+VvJBGUjZN7z3Jccn8UMyZlb8Eendyl5h?= =?us-ascii?Q?F1PBjTtq60rcaXjbLO13nNbow1loZPqEtYxXU51KjuftQ3jpNGrNoLnZq/qD?= =?us-ascii?Q?3unDCtwfeEB8A9XnyQYxzmiboR/RqM60aO6HvnkjlxYD1BHLCmbfEnmsFPAL?= =?us-ascii?Q?UJOhXS4BOTQL7XJZ2+L48bBM/bFV5KeMu0qXdfdoTR+HERIRJf5zQoTsjD+P?= =?us-ascii?Q?wgUoI5tKR9Qhm+/yzgk+kfJZYXhvZ?= X-Forefront-PRVS: 0334223192 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39450400003)(39850400002)(39400400002)(39410400002)(39840400002)(54534003)(66066001)(81166006)(478600001)(50226002)(47776003)(189998001)(38730400002)(107886003)(6506006)(5003940100001)(50986999)(53936002)(6512007)(2950100002)(575784001)(6916009)(76176999)(8676002)(110136004)(86362001)(305945005)(7736002)(2351001)(3846002)(2361001)(2906002)(6666003)(33646002)(25786009)(36756003)(48376002)(42186005)(4326008)(6486002)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:DBXPR07MB318; H:elxacz23q12.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB318; 23:ELNjrBitth1teW/vxOjET9Pnu61Y05dRv8gPDIf6LO?= =?us-ascii?Q?PK+A78bxYV4aixnSl10ahvXywG5j3sSjfxAziGymH+FPexVIFNMMUVnbBb9E?= =?us-ascii?Q?3oFCrjQtoqfM/c9mkFtPeDoVAWSk5Bh29Z5lzSU+85g4hjA+G//y4smrn9Oc?= =?us-ascii?Q?Ne/mwh/C1f3JUaFLFsjCdg/ohctR0UY3UnLhJO0DnNV9m+svil7nkqsqVThJ?= =?us-ascii?Q?uUPIMrWrs3HDeFUlTPrR95nO05mSNskM6FKx5dW7HgpWDjlNZKhF7mIXQAxt?= =?us-ascii?Q?/8TExrA+6UeIbDRkBp1A1/FkmjFk3gmICTRyzh1kORSnzGl/+A3FYsEjQtr6?= =?us-ascii?Q?ZlFpWi9lHCFxjY6KTEGsOHgEIvuIy16FicNhYxiJbxbiNXPUjquvDWfSdth+?= =?us-ascii?Q?nds3UCi9Kt+UwvGP8/xAa/VlV4r41lcEhRiHOkPF9bQxQoyrdAfe9pt1MUZH?= =?us-ascii?Q?0f5ZohAtQ/qW55A7WifZEIXts7FJHzt2fJY+iV/nAolNnRj8J0N20jSazZyu?= =?us-ascii?Q?eY/lEv9YzbHQCEhVju9tpM2SWrGXTQP5KuDoW6LARRDHk95Xc8BgvVKjhZYp?= =?us-ascii?Q?gky36rfn+9uk/hSpTqVOZnnzynL51i7nJqt5nx3bP8Z/JLuKUPsWLsqoLBIO?= =?us-ascii?Q?+/tuU+T1CByE5z6oF0T8VXmd7stBq77gbMZYorT8cQCHTGPKrU+ZxA6XliLd?= =?us-ascii?Q?aQicCubNckFrYQIW6RIF0Be3QC/nDA+obClonyo3r5/ZeibuHywUvUKVZwKb?= =?us-ascii?Q?hDmMGH+bcB+XawvChTm1WDPV5Lnmmlm6P1sAxQfaywHvGmydLOslDsvfF4Vs?= =?us-ascii?Q?HR8nJa66cc5LbhVAt04/fo0qlJGip01d9nuzSdgXndRkCzvub+BG/qCG05zN?= =?us-ascii?Q?Ti8X4Qg2zTUnbrNSZwswi/rZ1s1aGGzzgYUaRfX/10XR310dOWDWXRFOT9lM?= =?us-ascii?Q?UEc+2FYm2oJEAXYm222n3FQnXpuH3/7BSSZoHlN1kl0xP4ZlOiEFlX0+Jiu4?= =?us-ascii?Q?fFTZ0LX7yN7/g8K8RGdEGd0fWzHiNmsrlnwPikH1tsV+2CWR2pdedVsQi/nV?= =?us-ascii?Q?Ss9hVC33V1/eb+DQY9ZWqVWCPB2JtpYZX8tYVWg0PfQkfMEQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 6:jgl0EUWGUSTw6y6626Amab0YteT6QEDkj7sYL8uywfloyf41JzPyhwAbLUbz99ZzcPsbi6XXEa4zimPewk7c6/7IgLwAb3n60h1yRp6DTWC7lAtcKWjMBes2ZXaaSlzRNAuor1aIIDHHpMcXWDXzRJDNYEb84ASVd3sdtn1ayhpaZhL/EHqh8DOyoYBOlKJIctnbyPKESbgCyj4zh/o63/qRpJaDbr8p6WDDa7TMmyvinkM0zLnq/belHAHtlVW8vPuThWtxC3MPNMaunghV9L5DIrpKjxcgT9FVJlGQEJWuc0vFaqg++Y6ZvEV/qOSy58lIErG/8aKo1GjF5Jr3TtBUUMMhE1WYT7IJZRZBST6d42E2NCefIh9UeXCGKvfKEC8AxZrDj7swk9qqGu2GZHmn8JwkxTsCXUKcrHlRCdavfp3SoPx5wmM/9pMN1zpGcxiaSBoowvhvfyJrY90V8xmk/ONRlPqF6pkDSswI7+yhPGBeP/07awcE3RoyCrMX4HlhcwzM7BmaL7em6y2CNg== X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 5:q03FGHRtyA6NHpg2o5KCFfWXo4NsXc3N0kqdziAaLSOzJKrogZCKnlzMbjcV3dmXM7o5c4dvHc8Vs1C5KYKDyRLjdSzpNLP6gyVAie2JDgO6qMIsMTC9sCN7yoAiVeJfi5B/tnwJzIY48RU/vrDGRvmj50ii94fbpUTvJex005Kqiik8ovuRZF3dr6NL/ibwqc5h+aB/2ZLWWDkgMF+Hea0KgeD2bvqNo3vcB6ZToxnoXSITsEn8R3BvBM+lixy0KjrbVVkA0BfMGWf9DcS9ge4PoImsI5eQox56wtZrZv/2bqLECsX6dvNCY/ITxF2a36FYcaWDYx/T2bsUKLrOZGqXvkvcyfYBeY/Hb4AQnDY764awn6Pgf78pJ7GqeTDYZznET3Xl2yjHG0zc1TVOq9zHF23FENB8YE3XgchuSNV9+0w9ZH2+qKU4GbjpVGFxkSt9ypQcCBTNt8P715FPXsaif7mX7g2QF2nJ4ga+zMdXARwQ42Kgf2ouuAEDTeGi; 24:9bKACG4Lo8u59QghT3zWAyeOEGMfB0t9AZ5bzN/r6d/pTCOaagIQ9zwQTUoOf69nTR+2wzLRmPynyGdf30UD86tb5vGvh997nqLg4H5Wu1g= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 7:jZuSrVtYNP3CV66LBxul48RHkB2EiQkkj15RQbQXNBQ9H/4eAp7ERy23IjCax0u8Ft5HeSIxwf4NYY7MivXJKUU4CAB4DkqJrR8HXNN8/akDF3oHTZze3YYlfLU+VCkL//XISm9HD8oxHXXMdje80k/zN+SJ9wVeBuACz8XE8NzyBgS0L2Q2vWvpipx4kxMSirbfvc84YcTCKu+rqnmioXelTEHgpRhcuEA3o0vNj+G08imjgtRWEBMhkDbihcf+0+bZ9xcDWmyA8o/CC+05LPgpK8ZT3/kIimpfY0elCsjH5bxGtAdAB5L/ohaq20TDcVISAY750qCnQ5q5ooTeeA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2017 19:58:22.6522 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB318 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes In warning.m4, we pass all the warning flags one by one to the compiler to test if they are supported by this particular compiler. If the compiler exits with an error, we conclude that this warning flag is not supported and exclude it. This allows us to use warning flags without having to worry about which versions of which compilers support each flag. clang, by default, only emits a warning if an unknown flag is passed: warning: unknown warning option '-Wfoo' [-Wunknown-warning-option] The result is that we think that all the warning flags we use are supported by clang (they are not), and the compilation fails later when building with -Werror, since the aforementioned warning becomes an error. The fix is to also pass -Werror when probing for supported flags, then we'll correctly get an error when using an unknown warning, and we'll exclude it: error: unknown warning option '-Wfoo' [-Werror,-Wunknown-warning-option] I am not sure why there is a change in a random comment in gdbserver/configure, but I suppose it's a leftfover from a previous patch, so I included it. gdb/ChangeLog: * configure: Re-generate. * warning.m4: Pass -Werror to compiler when checking for supported warning flags. gdb/gdbserver/ChangeLog: * configure: Re-generate. --- gdb/configure | 4 ++-- gdb/gdbserver/configure | 10 +++++----- gdb/warning.m4 | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/gdb/configure b/gdb/configure index 1f15d5d3..df2747a 100755 --- a/gdb/configure +++ b/gdb/configure @@ -15222,9 +15222,9 @@ $as_echo_n "checking compiler warning flags... " >&6; } *) # Check whether GCC accepts it. saved_CFLAGS="$CFLAGS" - CFLAGS="$CFLAGS $wtest" + CFLAGS="$CFLAGS -Werror $wtest" saved_CXXFLAGS="$CXXFLAGS" - CXXFLAGS="$CXXFLAGS $wtest" + CXXFLAGS="$CXXFLAGS -Werror $wtest" cat confdefs.h - <<_ACEOF >conftest.$ac_ext /* end confdefs.h. */ diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure index b314c41..2550c7b 100755 --- a/gdb/gdbserver/configure +++ b/gdb/gdbserver/configure @@ -7219,9 +7219,9 @@ $as_echo_n "checking compiler warning flags... " >&6; } *) # Check whether GCC accepts it. saved_CFLAGS="$CFLAGS" - CFLAGS="$CFLAGS $wtest" + CFLAGS="$CFLAGS -Werror $wtest" saved_CXXFLAGS="$CXXFLAGS" - CXXFLAGS="$CXXFLAGS $wtest" + CXXFLAGS="$CXXFLAGS -Werror $wtest" cat confdefs.h - <<_ACEOF >conftest.$ac_ext /* end confdefs.h. */ @@ -7498,9 +7498,9 @@ _ACEOF fi -# See if supports the %fs_base and %gs_base amd64 segment -# registers. Older amd64 Linux's don't have the fs_base and gs_base -# members of `struct user_regs_struct'. +# See if supports the %fs_base and %gs_bas amd64 segment registers. +# Older amd64 Linux's don't have the fs_base and gs_base members of +# `struct user_regs_struct'. ac_fn_c_check_member "$LINENO" "struct user_regs_struct" "fs_base" "ac_cv_member_struct_user_regs_struct_fs_base" "#include " if test "x$ac_cv_member_struct_user_regs_struct_fs_base" = x""yes; then : diff --git a/gdb/warning.m4 b/gdb/warning.m4 index 98e7453..00e0f38 100644 --- a/gdb/warning.m4 +++ b/gdb/warning.m4 @@ -103,9 +103,9 @@ then *) # Check whether GCC accepts it. saved_CFLAGS="$CFLAGS" - CFLAGS="$CFLAGS $wtest" + CFLAGS="$CFLAGS -Werror $wtest" saved_CXXFLAGS="$CXXFLAGS" - CXXFLAGS="$CXXFLAGS $wtest" + CXXFLAGS="$CXXFLAGS -Werror $wtest" AC_TRY_COMPILE([],[],WARN_CFLAGS="${WARN_CFLAGS} $w",) CFLAGS="$saved_CFLAGS" CXXFLAGS="$saved_CXXFLAGS"