[GDB/ARM] Expect prompt after no FPU warning

Message ID c0d2b898-4fdb-8d28-e0a5-44aae541fe74@foss.arm.com
State New, archived
Headers

Commit Message

Thomas Preud'homme May 17, 2017, 9:13 a.m. UTC
  Hi,

The expected output for info float when the ARM target has no FPU does
not include the GDB prompt. This occasionally cause a test failure in
the following "finish" test when the prompt happens after the test has been
marked as PASSed, since it does not match the expected output.

This patch adds the GDB prompt to the expected output of the no FPU
regular expression.

ChangeLog entry is as follows:

*** gdb/testsuite/ChangeLog ***

2017-04-27  Thomas Preud'homme  <thomas.preudhomme@arm.com>

	* gdb.base/float.exp (info float): Expect GDB prompt for ARM
	targets without FPU.

Testing: test PASSes with that patch.

Is this ok for master branch?

Best regards,

Thomas
  

Comments

Yao Qi May 17, 2017, 12:10 p.m. UTC | #1
Thomas Preudhomme <thomas.preudhomme@foss.arm.com> writes:

> 2017-04-27  Thomas Preud'homme  <thomas.preudhomme@arm.com>
>
> 	* gdb.base/float.exp (info float): Expect GDB prompt for ARM

Remove " (info float)".

> 	targets without FPU.
>


> @@ -50,7 +50,7 @@ if { [is_aarch64_target] } then {
>  	    # if we have NEON.
>  	    pass "info float (VFP)"
>  	}
> -        -re "No floating.point info available for this processor.*" {
> +        -re "No floating.point info available for this processor.*$gdb_prompt $" {

The fix is right but it can be applied to all archs which may not have
FPU.  If you search "N floating.point info", you can find multiple hits.
$gdb_prompt is needed for all of them.
  
Thomas Preud'homme May 17, 2017, 12:20 p.m. UTC | #2
On 17/05/17 13:10, Yao Qi wrote:
> Thomas Preudhomme <thomas.preudhomme@foss.arm.com> writes:
>
>> 2017-04-27  Thomas Preud'homme  <thomas.preudhomme@arm.com>
>>
>> 	* gdb.base/float.exp (info float): Expect GDB prompt for ARM
>
> Remove " (info float)".
>
>> 	targets without FPU.
>>
>
>
>> @@ -50,7 +50,7 @@ if { [is_aarch64_target] } then {
>>  	    # if we have NEON.
>>  	    pass "info float (VFP)"
>>  	}
>> -        -re "No floating.point info available for this processor.*" {
>> +        -re "No floating.point info available for this processor.*$gdb_prompt $" {
>
> The fix is right but it can be applied to all archs which may not have
> FPU.  If you search "N floating.point info", you can find multiple hits.
> $gdb_prompt is needed for all of them.

Err yes sorry, I didn't add it because I only tested on ARM. I'll update the 
patch. Thanks!

Best regards,

Thomas
  

Patch

diff --git a/gdb/testsuite/gdb.base/float.exp b/gdb/testsuite/gdb.base/float.exp
index a4762c9742682391074f0707e56a6eae4cd70c6e..4f928c19491f55b235aaf68a4c9351531440aa4e 100644
--- a/gdb/testsuite/gdb.base/float.exp
+++ b/gdb/testsuite/gdb.base/float.exp
@@ -50,7 +50,7 @@  if { [is_aarch64_target] } then {
 	    # if we have NEON.
 	    pass "info float (VFP)"
 	}
-        -re "No floating.point info available for this processor.*" {
+        -re "No floating.point info available for this processor.*$gdb_prompt $" {
             pass "info float (without FPU)"
 	}
     }