[07/13] posix: Consolidate Linux fdatasync syscall
Commit Message
This patch consolidates the fdatasync Linux syscall generation on
sysdeps/unix/sysv/linux/fdatasync.c. It basically removes it from
architectures auto-generation list.
Checked on i686-linux-gnu, x86_64-linux-gnu, x86_64-linux-gnux32,
arch64-linux-gnu, arm-linux-gnueabihf, powerpc64le-linux-gnu,
sparc64-linux-gnu, and sparcv9-linux-gnu.
* misc/makefile (CFLAGS-datasync.c): New flag.
* nptl/makefile (CFLAGS-datasync.c): Likewise.
* sysdeps/unix/sysv/linux/syscalls.list (fdatasync): Remove from
auto-generation syscall list.
* sysdeps/unix/sysv/linux/fdatasync.c: New file.
---
ChangeLog | 6 ++++++
misc/Makefile | 1 +
nptl/Makefile | 1 +
sysdeps/unix/sysv/linux/fdatasync.c | 29 +++++++++++++++++++++++++++++
sysdeps/unix/sysv/linux/syscalls.list | 1 -
5 files changed, 37 insertions(+), 1 deletion(-)
create mode 100644 sysdeps/unix/sysv/linux/fdatasync.c
Comments
On Friday 12 May 2017 11:28 PM, Adhemerval Zanella wrote:
> This patch consolidates the fdatasync Linux syscall generation on
> sysdeps/unix/sysv/linux/fdatasync.c. It basically removes it from
> architectures auto-generation list.
>
> Checked on i686-linux-gnu, x86_64-linux-gnu, x86_64-linux-gnux32,
> arch64-linux-gnu, arm-linux-gnueabihf, powerpc64le-linux-gnu,
> sparc64-linux-gnu, and sparcv9-linux-gnu.
>
> * misc/makefile (CFLAGS-datasync.c): New flag.
> * nptl/makefile (CFLAGS-datasync.c): Likewise.
> * sysdeps/unix/sysv/linux/syscalls.list (fdatasync): Remove from
> auto-generation syscall list.
> * sysdeps/unix/sysv/linux/fdatasync.c: New file.
LGTM.
Siddhesh
@@ -109,6 +109,7 @@ CFLAGS-getusershell.c = -fexceptions
CFLAGS-err.c = -fexceptions
CFLAGS-tst-tsearch.c = $(stack-align-test-flags)
CFLAGS-msync.c = -fexceptions
+CFLAGS-fdatasync.c = -fexceptions
# Called during static library initialization, so turn stack-protection
# off for non-shared builds.
@@ -218,6 +218,7 @@ CFLAGS-read.c = -fexceptions -fasynchronous-unwind-tables
CFLAGS-write.c = -fexceptions -fasynchronous-unwind-tables
CFLAGS-nanosleep.c = -fexceptions -fasynchronous-unwind-tables
CFLAGS-msync.c = -fexceptions -fasynchronous-unwind-tables
+CFLAGS-fdatasync.c = -fexceptions -fasynchronous-unwind-tables
CFLAGS-pt-system.c = -fexceptions
new file mode 100644
@@ -0,0 +1,29 @@
+/* Synchronize a file's in-core state with storage device Linux
+ implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <unistd.h>
+#include <sysdep-cancel.h>
+
+/* Synchronize at least the data part of a file with the underlying
+ media. */
+int
+fdatasync (int fd)
+{
+ return SYSCALL_CANCEL (fdatasync, fd);
+}
@@ -13,7 +13,6 @@ epoll_create1 EXTRA epoll_create1 i:i epoll_create1
epoll_ctl EXTRA epoll_ctl i:iiip epoll_ctl
eventfd EXTRA eventfd2 i:ii eventfd
execve - execve i:spp __execve execve
-fdatasync - fdatasync Ci:i fdatasync
flock - flock i:ii __flock flock
get_kernel_syms EXTRA get_kernel_syms i:p __compat_get_kernel_syms get_kernel_syms@GLIBC_2.0:GLIBC_2.23
getpid - getpid Ei: __getpid getpid