diff mbox

gdbarch.sh: Remove commented out TARGET_CHAR_BIT definition

Message ID 20170502193240.17920-1-simon.marchi@ericsson.com
State New, archived
Headers

Commit Message

Simon Marchi May 2, 2017, 7:32 p.m. UTC 
  As Pedro commented on the patch "Change field separator in gdbarch.sh",
this commented out definition is probably not useful and should be
removed.  It has been commented out for basically forever, and it
probably serves the same intent as addressable_memory_unit_size.

gdb/ChangeLog:

	* gdbarch.sh: Remove commented out definition of
	TARGET_CHAR_BIT.
---
 gdb/gdbarch.h  | 6 +-----
 gdb/gdbarch.sh | 4 ----
 2 files changed, 1 insertion(+), 9 deletions(-)

Comments

Yao Qi May 3, 2017, 8:10 a.m. UTC | #1 
Simon Marchi <simon.marchi@ericsson.com> writes:

> gdb/ChangeLog:
>
> 	* gdbarch.sh: Remove commented out definition of
> 	TARGET_CHAR_BIT.

        * gdbarch.h: Regenerated.

Patch is good to me.
Simon Marchi May 3, 2017, 1:22 p.m. UTC | #2 
On 2017-05-03 04:10, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
> 
>> gdb/ChangeLog:
>> 
>> 	* gdbarch.sh: Remove commented out definition of
>> 	TARGET_CHAR_BIT.
> 
>         * gdbarch.h: Regenerated.
> 
> Patch is good to me.

Thanks, I pushed it after adding the missing ChangeLog entry.
diff mbox

Patch

diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h
index 442bef165a..15a81418b0 100644
--- a/gdb/gdbarch.h
+++ b/gdb/gdbarch.h
@@ -128,11 +128,7 @@  extern const struct target_desc * gdbarch_target_desc (struct gdbarch *gdbarch);
 extern int gdbarch_bits_big_endian (struct gdbarch *gdbarch);
 extern void set_gdbarch_bits_big_endian (struct gdbarch *gdbarch, int bits_big_endian);
 
-/* Number of bits in a char or unsigned char for the target machine.
-   Just like CHAR_BIT in <limits.h> but describes the target machine.
-   v;TARGET_CHAR_BIT;int;char_bit;;;;8 * sizeof (char);8;;0;
-  
-   Number of bits in a short or unsigned short for the target machine. */
+/* Number of bits in a short or unsigned short for the target machine. */
 
 extern int gdbarch_short_bit (struct gdbarch *gdbarch);
 extern void set_gdbarch_short_bit (struct gdbarch *gdbarch, int short_bit);
diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh
index 68163a1947..753819f321 100755
--- a/gdb/gdbarch.sh
+++ b/gdb/gdbarch.sh
@@ -351,10 +351,6 @@  i;const struct target_desc *;target_desc;;;;;;;host_address_to_string (gdbarch->
 # and such.  Conceptually, it's quite separate from byte/word byte order.
 v;int;bits_big_endian;;;1;(gdbarch->byte_order == BFD_ENDIAN_BIG);;0
 
-# Number of bits in a char or unsigned char for the target machine.
-# Just like CHAR_BIT in <limits.h> but describes the target machine.
-# v;TARGET_CHAR_BIT;int;char_bit;;;;8 * sizeof (char);8;;0;
-#
 # Number of bits in a short or unsigned short for the target machine.
 v;int;short_bit;;;8 * sizeof (short);2*TARGET_CHAR_BIT;;0
 # Number of bits in an int or unsigned int for the target machine.