[05/10] Fix indentation of lm_info_frv
Commit Message
This patch fixes the indentation of lm_info_frv, so that the real
changes of the following patch are not lost in the reformatting.
gdb/ChangeLog:
* solib-frv.c (struct lm_info_frv): Fix indentation.
---
gdb/solib-frv.c | 47 ++++++++++++++++++++++++-----------------------
1 file changed, 24 insertions(+), 23 deletions(-)
Comments
LGTM.
On 04/26/2017 11:51 PM, Simon Marchi wrote:
> + int dyn_reloc_count; /* Number of dynamic relocs. */
> +
> +};
You may want to remove that spurious newline while at it.
Thanks,
Pedro Alves
On 2017-04-28 11:59, Pedro Alves wrote:
> LGTM.
>
> On 04/26/2017 11:51 PM, Simon Marchi wrote:
>> + int dyn_reloc_count; /* Number of dynamic relocs. */
>> +
>> +};
>
> You may want to remove that spurious newline while at it.
Bah, it's removed in the following patch.
@@ -203,29 +203,30 @@ struct ext_link_map
/* Link map info to include in an allocated so_list entry. */
struct lm_info_frv : public lm_info_base
- {
- /* The loadmap, digested into an easier to use form. */
- struct int_elf32_fdpic_loadmap *map;
- /* The GOT address for this link map entry. */
- CORE_ADDR got_value;
- /* The link map address, needed for frv_fetch_objfile_link_map(). */
- CORE_ADDR lm_addr;
-
- /* Cached dynamic symbol table and dynamic relocs initialized and
- used only by find_canonical_descriptor_in_load_object().
-
- Note: kevinb/2004-02-26: It appears that calls to
- bfd_canonicalize_dynamic_reloc() will use the same symbols as
- those supplied to the first call to this function. Therefore,
- it's important to NOT free the asymbol ** data structure
- supplied to the first call. Thus the caching of the dynamic
- symbols (dyn_syms) is critical for correct operation. The
- caching of the dynamic relocations could be dispensed with. */
- asymbol **dyn_syms;
- arelent **dyn_relocs;
- int dyn_reloc_count; /* Number of dynamic relocs. */
-
- };
+{
+
+ /* The loadmap, digested into an easier to use form. */
+ struct int_elf32_fdpic_loadmap *map;
+ /* The GOT address for this link map entry. */
+ CORE_ADDR got_value;
+ /* The link map address, needed for frv_fetch_objfile_link_map(). */
+ CORE_ADDR lm_addr;
+
+ /* Cached dynamic symbol table and dynamic relocs initialized and
+ used only by find_canonical_descriptor_in_load_object().
+
+ Note: kevinb/2004-02-26: It appears that calls to
+ bfd_canonicalize_dynamic_reloc() will use the same symbols as
+ those supplied to the first call to this function. Therefore,
+ it's important to NOT free the asymbol ** data structure
+ supplied to the first call. Thus the caching of the dynamic
+ symbols (dyn_syms) is critical for correct operation. The
+ caching of the dynamic relocations could be dispensed with. */
+ asymbol **dyn_syms;
+ arelent **dyn_relocs;
+ int dyn_reloc_count; /* Number of dynamic relocs. */
+
+};
/* The load map, got value, etc. are not available from the chain
of loaded shared objects. ``main_executable_lm_info'' provides