diff mbox

posix: Add SIGSEGV on the trap list for globtest.sh

Message ID 1491934157-30940-1-git-send-email-adhemerval.zanella@linaro.org
State Dropped
Headers

Commit Message

Adhemerval Zanella Netto April 11, 2017, 6:09 p.m. UTC 
  This patch prevents lingering files for SIGSEGV failutes.  Checked
on x86_64.

	* posix/globtest.sh: Add SIGSEGV for the signal to act on a trap.
---
 ChangeLog         | 4 ++++
 posix/globtest.sh | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

Comments

Florian Weimer April 11, 2017, 6:22 p.m. UTC | #1 
On 04/11/2017 08:09 PM, Adhemerval Zanella wrote:
> -trap 'chmod 777 $testdir/noread; rm -fr $testdir $testout' 1 2 3 15
> +trap 'chmod 777 $testdir/noread; rm -fr $testdir $testout' HUP INT QUIT SEGV TERM

Does the shell really receive the signal?  Why not use “0”?

Thanks,
Florian
Adhemerval Zanella Netto April 11, 2017, 7:59 p.m. UTC | #2 
On 11/04/2017 15:22, Florian Weimer wrote:
> On 04/11/2017 08:09 PM, Adhemerval Zanella wrote:
>> -trap 'chmod 777 $testdir/noread; rm -fr $testdir $testout' 1 2 3 15
>> +trap 'chmod 777 $testdir/noread; rm -fr $testdir $testout' HUP INT QUIT SEGV TERM
> 
> Does the shell really receive the signal?  Why not use “0”?

It does not off course since it is not the shell that is actually generating
the segfault. I will rewrite the patch.

> 
> Thanks,
> Florian
Florian Weimer April 11, 2017, 9:12 p.m. UTC | #3 
On 04/11/2017 09:59 PM, Adhemerval Zanella wrote:
>
>
> On 11/04/2017 15:22, Florian Weimer wrote:
>> On 04/11/2017 08:09 PM, Adhemerval Zanella wrote:
>>> -trap 'chmod 777 $testdir/noread; rm -fr $testdir $testout' 1 2 3 15
>>> +trap 'chmod 777 $testdir/noread; rm -fr $testdir $testout' HUP INT QUIT SEGV TERM
>>
>> Does the shell really receive the signal?  Why not use “0”?
>
> It does not off course since it is not the shell that is actually generating
> the segfault.

Well, the shell uses globbing, too, so who knows. :)

> I will rewrite the patch.

Thanks.  Using 0 is probably the correct choice, then.

Florian
diff mbox

Patch

diff --git a/posix/globtest.sh b/posix/globtest.sh
index f9cc80b..cb7d748 100755
--- a/posix/globtest.sh
+++ b/posix/globtest.sh
@@ -47,7 +47,7 @@  testout=${common_objpfx}posix/globtest-out
 rm -rf $testdir $testout
 mkdir $testdir
 
-trap 'chmod 777 $testdir/noread; rm -fr $testdir $testout' 1 2 3 15
+trap 'chmod 777 $testdir/noread; rm -fr $testdir $testout' HUP INT QUIT SEGV TERM
 
 echo 1 > $testdir/file1
 echo 2 > $testdir/file2