Remove support for FreeBSD/alpha.

Message ID 20170404181008.6978-1-jhb@FreeBSD.org
State New, archived
Headers

Commit Message

John Baldwin April 4, 2017, 6:10 p.m. UTC
  FreeBSD last shipped a release for Alpha (6.3) in 2008.
This also removes support for GNU/kFreeBSD on Alpha.

gdb/ChangeLog:

	* Makefile.in (ALL_64_TARGET_OBS): Remove alpha-fbsd-tdep.o.
	(ALLDEPFILES): Remove alpha-fbsd-tdep.c
	* NEWS: Mention that support for FreeBSD/alpha was removed.
	* alpha-fbsd-tdep.c: Delete file.
	* config/alpha/fbsd.mh: Delete file.
	* configure.host: Delete alpha*-*-freebsd* and
	alpha*-*-kfreebsd*-gnu.
	* configure.tgt: Delete alpha*-*-freebsd* and
	alpha*-*-kfreebsd*-gnu.
---
 gdb/ChangeLog            |  12 +++++
 gdb/Makefile.in          |   2 -
 gdb/NEWS                 |   5 ++
 gdb/alpha-fbsd-tdep.c    | 132 -----------------------------------------------
 gdb/config/alpha/fbsd.mh |   6 ---
 gdb/configure.host       |   4 +-
 gdb/configure.tgt        |   7 +--
 7 files changed, 21 insertions(+), 147 deletions(-)
 delete mode 100644 gdb/alpha-fbsd-tdep.c
 delete mode 100644 gdb/config/alpha/fbsd.mh
  

Comments

John Baldwin April 4, 2017, 6:44 p.m. UTC | #1
On Tuesday, April 04, 2017 11:10:08 AM John Baldwin wrote:
> FreeBSD last shipped a release for Alpha (6.3) in 2008.
> This also removes support for GNU/kFreeBSD on Alpha.

I have not reached out to anyone at Debian about GNU/kFreeBSD on Alpha, but
I strongly doubt anyone there is actually testing/using that on Alpha since
FreeBSD removed alpha support so long ago.  The existing images for
kFreeBSD only include support for amd64 and i386.

> diff --git a/gdb/configure.host b/gdb/configure.host
> index c45f61dbba..e7b310fe62 100644
> --- a/gdb/configure.host
> +++ b/gdb/configure.host
> @@ -21,6 +21,8 @@ case $host in
>      ;;
>   *-*-irix* | \
>   alpha*-*-osf* | \
> + alpha*-*-freebsd* | \
> + alpha*-*-kfreebsd*-gnu \

I mailed this a bit early as this line is missing a | as is the same
line in configure.tgt.  Will send a fixed v2 in a second.
  
John Paul Adrian Glaubitz April 4, 2017, 6:55 p.m. UTC | #2
On 04/04/2017 08:44 PM, John Baldwin wrote:
> I have not reached out to anyone at Debian about GNU/kFreeBSD on Alpha, but
> I strongly doubt anyone there is actually testing/using that on Alpha since
> FreeBSD removed alpha support so long ago.  The existing images for
> kFreeBSD only include support for amd64 and i386.

That's correct. I don't even know whether there ever actually was a Debian
kFreeBSD/alpha port in existence. However, Debian on Linux/alpha still works
and we're still providing up-to-date packages. So, please don't drop the
Linux/alpha target from GDB.

In general, currently not bootstrapped targets can be automatically bootstrapped
in Debian with the help of the rebootstrap project [1]. So, we can potentially
support anything the toolchain/glibc/kernel supports.

Adrian

> [1] https://jenkins.debian.net/view/rebootstrap/
  
John Baldwin April 4, 2017, 7:06 p.m. UTC | #3
On Tuesday, April 04, 2017 08:55:07 PM John Paul Adrian Glaubitz wrote:
> On 04/04/2017 08:44 PM, John Baldwin wrote:
> > I have not reached out to anyone at Debian about GNU/kFreeBSD on Alpha, but
> > I strongly doubt anyone there is actually testing/using that on Alpha since
> > FreeBSD removed alpha support so long ago.  The existing images for
> > kFreeBSD only include support for amd64 and i386.
> 
> That's correct. I don't even know whether there ever actually was a Debian
> kFreeBSD/alpha port in existence. However, Debian on Linux/alpha still works
> and we're still providing up-to-date packages. So, please don't drop the
> Linux/alpha target from GDB.
> 
> In general, currently not bootstrapped targets can be automatically bootstrapped
> in Debian with the help of the rebootstrap project [1]. So, we can potentially
> support anything the toolchain/glibc/kernel supports.

To be clear, the patchset only affects kFreeBSD with Alpha, it does not
remove support for using the Linux kernel with Debian on Alpha.
  

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fc8dbe18da..7d858b997d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,15 @@ 
+2017-04-04  John Baldwin  <jhb@FreeBSD.org>
+
+	* Makefile.in (ALL_64_TARGET_OBS): Remove alpha-fbsd-tdep.o.
+	(ALLDEPFILES): Remove alpha-fbsd-tdep.c
+	* NEWS: Mention that support for FreeBSD/alpha was removed.
+	* alpha-fbsd-tdep.c: Delete file.
+	* config/alpha/fbsd.mh: Delete file.
+	* configure.host: Delete alpha*-*-freebsd* and
+	alpha*-*-kfreebsd*-gnu.
+	* configure.tgt: Delete alpha*-*-freebsd* and
+	alpha*-*-kfreebsd*-gnu.
+
 2017-04-04  Simon Marchi  <simon.marchi@polymtl.ca>
 
 	* remote.c (set_general_thread, set_continue_thread): Use ptid_t
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 08187427cd..a1c6f8a4bd 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -744,7 +744,6 @@  ALL_64_TARGET_OBS = \
 	aarch64-newlib-tdep.o \
 	aarch64-tdep.o \
 	alpha-bsd-tdep.o \
-	alpha-fbsd-tdep.o \
 	alpha-linux-tdep.o \
 	alpha-mdebug-tdep.o \
 	alpha-nbsd-tdep.o \
@@ -2458,7 +2457,6 @@  ALLDEPFILES = \
 	aix-thread.c \
 	alpha-bsd-nat.c \
 	alpha-bsd-tdep.c \
-	alpha-fbsd-tdep.c \
 	alpha-linux-nat.c \
 	alpha-linux-tdep.c \
 	alpha-mdebug-tdep.c \
diff --git a/gdb/NEWS b/gdb/NEWS
index 29ae40c9bb..5b7748631f 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -104,6 +104,11 @@  show disassembler-options
 maint print arc arc-instruction address
   Print internal disassembler information about instruction at a given address.
 
+* Removed targets and native configurations
+
+Alpha running FreeBSD         alpha*-*-freebsd*
+Alpha running GNU/kFreeBSD    alpha*-*-kfreebsd*-gnu
+
 *** Changes in GDB 7.12
 
 * GDB and GDBserver now build with a C++ compiler by default.
diff --git a/gdb/alpha-fbsd-tdep.c b/gdb/alpha-fbsd-tdep.c
deleted file mode 100644
index a6eca59c4a..0000000000
--- a/gdb/alpha-fbsd-tdep.c
+++ /dev/null
@@ -1,132 +0,0 @@ 
-/* Target-dependent code for FreeBSD/alpha.
-
-   Copyright (C) 2001-2017 Free Software Foundation, Inc.
-
-   This file is part of GDB.
-
-   This program is free software; you can redistribute it and/or modify
-   it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 3 of the License, or
-   (at your option) any later version.
-
-   This program is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-   GNU General Public License for more details.
-
-   You should have received a copy of the GNU General Public License
-   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
-
-#include "defs.h"
-#include "value.h"
-#include "osabi.h"
-
-#include "alpha-tdep.h"
-#include "solib-svr4.h"
-
-static int
-alphafbsd_return_in_memory (struct type *type)
-{
-  enum type_code code;
-  int i;
-
-  /* All aggregate types that won't fit in a register must be returned
-     in memory.  */
-  if (TYPE_LENGTH (type) > ALPHA_REGISTER_SIZE)
-    return 1;
-
-  /* The only aggregate types that can be returned in a register are
-     structs and unions.  Arrays must be returned in memory.  */
-  code = TYPE_CODE (type);
-  if (code != TYPE_CODE_STRUCT && code != TYPE_CODE_UNION)
-    return 1;
-
-  /* We need to check if this struct/union is "integer" like.  For
-     this to be true, the offset of each adressable subfield must be
-     zero.  Note that bit fields are not addressable.  */
-  for (i = 0; i < TYPE_NFIELDS (type); i++)
-    {
-      /* If the field bitsize is non-zero, it isn't adressable.  */
-      if (TYPE_FIELD_BITPOS (type, i) != 0
-	  && TYPE_FIELD_BITSIZE (type, i) == 0)
-	return 1;
-    }
-
-  return 0;
-}
-
-
-/* Support for signal handlers.  */
-
-/* Return whether PC is in a BSD sigtramp routine.  */
-
-CORE_ADDR alphafbsd_sigtramp_start = 0x11ffff68;
-CORE_ADDR alphafbsd_sigtramp_end = 0x11ffffe0;
-
-static int
-alphafbsd_pc_in_sigtramp (struct gdbarch *gdbarch,
-			  CORE_ADDR pc, const char *func_name)
-{
-  return (pc >= alphafbsd_sigtramp_start && pc < alphafbsd_sigtramp_end);
-}
-
-static LONGEST
-alphafbsd_sigtramp_offset (struct gdbarch *gdbarch, CORE_ADDR pc)
-{
-  return pc - alphafbsd_sigtramp_start;
-}
-
-/* Assuming THIS_FRAME is the frame of a BSD sigtramp routine,
-   return the address of the associated sigcontext structure.  */
-
-static CORE_ADDR
-alphafbsd_sigcontext_addr (struct frame_info *this_frame)
-{
-  return get_frame_register_unsigned (this_frame, ALPHA_SP_REGNUM) + 24;
-}
-
-/* FreeBSD 5.0-RELEASE or later.  */
-
-static void
-alphafbsd_init_abi (struct gdbarch_info info,
-                    struct gdbarch *gdbarch)
-{
-  struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
-
-  /* FIXME: Should activate generic FreeBSD support here with
-     fbsd_init_abi(), but this requires a valid
-     'iterate_over_regset_sections' gdbarch method and
-     'collect_regset' functions for each regset.  */
-
-  /* Hook into the DWARF CFI frame unwinder.  */
-  alpha_dwarf2_init_abi (info, gdbarch);
-
-  /* Hook into the MDEBUG frame unwinder.  */
-  alpha_mdebug_init_abi (info, gdbarch);
-
-  /* FreeBSD/alpha has SVR4-style shared libraries.  */
-  set_solib_svr4_fetch_link_map_offsets
-    (gdbarch, svr4_lp64_fetch_link_map_offsets);
-
-  tdep->dynamic_sigtramp_offset = alphafbsd_sigtramp_offset;
-  tdep->sigcontext_addr = alphafbsd_sigcontext_addr;
-  tdep->pc_in_sigtramp = alphafbsd_pc_in_sigtramp;
-  tdep->return_in_memory = alphafbsd_return_in_memory;
-  tdep->sc_pc_offset = 288;
-  tdep->sc_regs_offset = 24;
-  tdep->sc_fpregs_offset = 320;
-
-  tdep->jb_pc = 2;
-  tdep->jb_elt_size = 8;
-}
-
-
-/* Provide a prototype to silence -Wmissing-prototypes.  */
-void _initialize_alphafbsd_tdep (void);
-
-void
-_initialize_alphafbsd_tdep (void)
-{
-  gdbarch_register_osabi (bfd_arch_alpha, 0, GDB_OSABI_FREEBSD,
-                          alphafbsd_init_abi);
-}
diff --git a/gdb/config/alpha/fbsd.mh b/gdb/config/alpha/fbsd.mh
deleted file mode 100644
index 9cd6912716..0000000000
--- a/gdb/config/alpha/fbsd.mh
+++ /dev/null
@@ -1,6 +0,0 @@ 
-# Host: FreeBSD/alpha
-NATDEPFILES= fork-child.o inf-ptrace.o \
-	fbsd-nat.o alpha-bsd-nat.o bsd-kvm.o \
-	core-regset.o
-
-LOADLIBES= -lkvm
diff --git a/gdb/configure.host b/gdb/configure.host
index c45f61dbba..e7b310fe62 100644
--- a/gdb/configure.host
+++ b/gdb/configure.host
@@ -21,6 +21,8 @@  case $host in
     ;;
  *-*-irix* | \
  alpha*-*-osf* | \
+ alpha*-*-freebsd* | \
+ alpha*-*-kfreebsd*-gnu \
  arm*-*-netbsd* | \
  hppa*-*-hiux* | \
  i[34567]86-ncr-* | \
@@ -84,8 +86,6 @@  case "${host}" in
 aarch64*-*-linux*)	gdb_host=linux ;;
 
 alpha*-*-linux*)	gdb_host=alpha-linux ;;
-alpha*-*-freebsd* | alpha*-*-kfreebsd*-gnu)
-			gdb_host=fbsd ;;
 alpha*-*-netbsd* | alpha*-*-knetbsd*-gnu)
 			gdb_host=nbsd ;;
 alpha*-*-openbsd*)	gdb_host=nbsd ;;
diff --git a/gdb/configure.tgt b/gdb/configure.tgt
index cb909e7f5e..a49496b506 100644
--- a/gdb/configure.tgt
+++ b/gdb/configure.tgt
@@ -15,6 +15,8 @@ 
 case $targ in
  *-*-irix* | \
  alpha*-*-osf* | \
+ alpha*-*-freebsd* | \
+ alpha*-*-kfreebsd*-gnu \
  d10v-*-* | \
  hppa*-*-hiux* | \
  i[34567]86-ncr-* | \
@@ -57,11 +59,6 @@  alpha*-*-linux*)
 	gdb_target_obs="alpha-tdep.o alpha-mdebug-tdep.o alpha-linux-tdep.o \
 			linux-tdep.o solib-svr4.o"
 	;;
-alpha*-*-freebsd* | alpha*-*-kfreebsd*-gnu)
-	# Target: FreeBSD/alpha
-	gdb_target_obs="alpha-tdep.o alpha-mdebug-tdep.o alpha-bsd-tdep.o \
-			alpha-fbsd-tdep.o solib-svr4.o"
-	;;
 alpha*-*-netbsd* | alpha*-*-knetbsd*-gnu)
 	# Target: NetBSD/alpha
 	gdb_target_obs="alpha-tdep.o alpha-mdebug-tdep.o alpha-bsd-tdep.o \