Message ID | 20170313212749.9607-2-simon.marchi@ericsson.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 111861 invoked by alias); 13 Mar 2017 21:28:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 111851 invoked by uid 89); 13 Mar 2017 21:28:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.2 spammy=our X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Mar 2017 21:28:10 +0000 Received: from ESESSHC023.ericsson.se (Unknown_Domain [153.88.183.87]) by (Symantec Mail Security) with SMTP id C7.81.19629.8EE07C85; Mon, 13 Mar 2017 22:28:09 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.87) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 13 Mar 2017 22:28:07 +0100 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from elxcz23q12-y4.ca.am.ericsson.se (192.75.88.130) by AM4PR07MB1715.eurprd07.prod.outlook.com (10.166.133.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.977.5; Mon, 13 Mar 2017 21:28:06 +0000 From: Simon Marchi <simon.marchi@ericsson.com> To: <gdb-patches@sourceware.org> CC: Simon Marchi <simon.marchi@ericsson.com> Subject: [PATCH 2/2] testsuite: Disable backslash_in_multi_line_command_test for old DejaGnus Date: Mon, 13 Mar 2017 17:27:49 -0400 Message-ID: <20170313212749.9607-2-simon.marchi@ericsson.com> In-Reply-To: <20170313212749.9607-1-simon.marchi@ericsson.com> References: <20170313212749.9607-1-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: SN1PR19CA0013.namprd19.prod.outlook.com (10.163.220.23) To AM4PR07MB1715.eurprd07.prod.outlook.com (10.166.133.23) X-MS-Office365-Filtering-Correlation-Id: 4a43f351-82b9-4302-fbdb-08d46a57d715 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:AM4PR07MB1715; X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1715; 3:AfptRwkKcPd9XRMbDZGd1obarjp2VoabMcfLHesWQGWUnh44fRf1yJfTj+x055Yl/V2OonOASyPTl9ZFY4rV5YmgRs/QIXVffVWn+0VO+hYp1WlDTUzjJmTkSzxt3wdrK/XTtBMpg5rY3CgrabVvUE1CDmu7ygtwUykRN/xrH7XTrHFbt3dotT/WotjLbF167lZZnX0ATAOUJmZfXDjrJCwf0fKuLwbmEDPwXSswKFaL4075sYSglV6HnHvCWlnwk5yydvDa3ZjoNJU7wtM1iA==; 25:hAisYc2eoiN8qUg+OusuyiftRVLBuvoYThIPiAxcR9szNx+QiE2xsrzyxVupKInSu7b0ihYq5/74gKGiqiwIMj+unHyXlaIluIJNiSbuKVxVM4JbJOb1O+3Oxesp5aT/ViACwVUN8X8hPZGgfoQNseFTAhxseMGMIWno6p81Gq6h9UvkozPd5KvpGlVZmL3ddPgCpM2Wh8vDMFPFJGA8bEFziz0Q+V5Cubnht8yTbcVgDRICc6Yn2vftm8YBI/0oDBRYqQhgwPTrvo+9xYmi+3uBFGSNzJWp5tLEQp8EYCnFFfCp2EGOUEd4GzPLSA20d4uNky59xwTpHChYGf4Yffh2cW3pZiIfoYjP2xtcdSdgyiQ6obM/RWHPY3MIFMia9DjkNUvCG+cnBKkbJEzlSISF1eazfXwioHd7fIsyubJj7R4SIsAsQWsn84h26XdWbXeFsiq7oY1accWP4nkQ1g== X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1715; 31:oxdR7nkPLj7VkBXhBGmdDx5r5cLtAM4pUSASlBXS5pRsgaMss+RSF7xIE42Jw4FIp+96cH9z42/CBGhhNJcwA8OopbExEHi5EJTmKJh0RjToXJcY6CZ9ETsGKA2OgeAZmAk/Eam3KJwmZeOl8wanWcg5hskknuT3IL6wOlBRXA993xbG7N9XJOhIs3yOmqgio6n7AydkxDC0+wHkohPw+7a8gPxH3kRc+zknKnc1U5s=; 20:uXZa66eNKez4a6zopx/WSuy9nKHWjs7/zUQ8S9WvOsxv1FNo5kEIsHwGIpZuwY/Pc3kixWdd9UuxjIDblS2dW85UCMbsIMOblU8Mdg1Lm4I95yJA7n86+6vaifT9evDLGGx1f818cfal7EohQdzoAjD1YVv5ZrRAN3gFMvMUZjLnSm8DrDTIBxa5tMfq778nOlszS3w4J+bpYVaRRQLCe6MjPI4Tc+Mun3Q4bd7shbZ6EMdT2DX5Hdc87MQaSt5KmSeUyZ0WkxBj5J9j4/mA2NqNoXO+worvOOI/z9K6jTP38t8Zw1GRtCOqaLyEMlVfNCFz36Om3BXNfKWxrtsKid3J/FfVRDffOqkmJqthz/+g+/sba2u826cPztXY7he20flvHr6JOehyQ+tgAZWky4io6JR4VIxjD15eXgrv4/qbBxFws6GGzp8Lj2RI79Ucajev930f2NsHZlaLOZlfMqMJt9sbN7lTMbtATK19uOR8WC6ALE7q2zLxpGlwI2eZ X-Microsoft-Antispam-PRVS: <AM4PR07MB17152F9CABE7CBB8AECA9133ED250@AM4PR07MB1715.eurprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(22074186197030); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123562025)(20161123560025)(20161123558025)(20161123564025)(20161123555025)(6072148); SRVR:AM4PR07MB1715; BCL:0; PCL:0; RULEID:; SRVR:AM4PR07MB1715; X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1715; 4:3XfTreLf5HA/Go30SDvUjJ/5hfPesKtCrIVp5VJHLXUi7Q0ivQ44VdXDTqjiiFpVaBoJh3CbHDKE3z8BPvLIEdlXpiIRzvk3HudPwvUmBevzblDwYJbZYAzMWhkdmJ+ZFEkQoioY6qc9AH6mB6my75xnUP997da2/EPsZ/ujWsxnfY5kgewChK2HdbF4Q80XEOjk66Dbwnk5OqYeYpUY+Tq7SdyJFxsKby/LtZbvzvU2fSt935cPsdn8Hr/cXc/292mB7X20K9qhBMLqhUahMemhVJAsnMgAAkwNa2GYpJB1sbbC5fymR4GCpp4PMawNME0D7qt3ur0dOjcHhQb4TLYt+JUZ2bVlyTGIDDfmrlbcev583IMIwchf0UMz+kqa/dDQTqyLTHSC1UnrrVET/7myUGeOiOvRpxpXOJwYP1bt+qzN80F+q7Jh9f6OS29d7qi9gOwNCOavXojfzVlCy4fl3hDMHr3eRtl7vR7ApT/p0Eg1+sAm+VQ2SO/eZIeKSwe/dw/FDlcQwd91CG30GX7Uw08iT9UwbuQrjaxvlm9up1MynT6WEliac15/zV4wKvqQub6lJrAeCndPLtw8o1rmiKc3/RnDWFqw1meVKoWq1XRcZp4Rao/oiC5rr+B4sg9UhoHPnQly5zXBI5TrqQ== X-Forefront-PRVS: 0245702D7B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39450400003)(2351001)(6506006)(50986999)(50466002)(48376002)(81166006)(966004)(33646002)(86362001)(5003940100001)(25786008)(76176999)(42186005)(110136004)(36756003)(6486002)(8676002)(107886003)(38730400002)(189998001)(53936002)(4326008)(575784001)(66066001)(305945005)(50226002)(5660300001)(1076002)(47776003)(3846002)(7736002)(6306002)(6512007)(2950100002)(6116002)(2906002)(6916009)(6666003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR07MB1715; H:elxcz23q12-y4.ca.am.ericsson.se; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM4PR07MB1715; 23:E35EabNF//ZjWtZ7EAS+5Ua/nT+M95bcSZd+AS7Uv?= =?us-ascii?Q?v33Au0YLsSX908x9a8a13t9qul+7MuFh5wFHAyvd3Xx1LofyrjE+gllD5GCK?= =?us-ascii?Q?ggjRsTSM5Sgxie2BXVKx0cdg45DK7eKqVmMfZUuXIk9nJqbBIWf5qoeBhVwH?= =?us-ascii?Q?hK0SlBSADO76jBUy9V4gwApUWQBS0F3pun63JhdAwCJpfgVkDp60+hJ8kybM?= =?us-ascii?Q?zuL9C3AO/dfM1tCJa7/qUy0vqFv7rx296g7ovy7ghogB2dwkOxZVsWFJ80jF?= =?us-ascii?Q?b0fwOF34USQoxtp3z/4+9+x8F6olfxrF0r/oqPZyAc75ePdU0MSt6VT5aWIE?= =?us-ascii?Q?iIuO+nAFIih+BhjQfqq3M9k8sxSm2KV6VUpco1d5MYlP58tAH+Oy18O4J6pn?= =?us-ascii?Q?ZUGysbcDOub5ro2FyEcS5XSBONhXS2Uu+NM/OV33tGydP3NsqYlDdJaYJsgU?= =?us-ascii?Q?W9YQPejHCx5+bnIaJyIVpGgDNuLgvM7Ncw37mZFCE/TIS+cYVyofaO13B2Nm?= =?us-ascii?Q?36vNpxKfB3TOyMzZX2WRpRz89sigf5xbcYvsVApijnW+5iBL6NMm6o5fPXym?= =?us-ascii?Q?jlW5ODHnkgUPh2psx5fMg/OGqZ7U+N7VXiVZJ0LHZMz0QqXfXr/raK7ne3qa?= =?us-ascii?Q?s/au9gaGeWcPpDy4VZeObtVETkoaHUSSTb3zXBfM9qLJc1eitSXyXEo4hy7J?= =?us-ascii?Q?c8cj00AaroUJVYFmoVo7siBHc0y2NxpYCj2VkLD9dbcEwVaulbQjKO4QnlFv?= =?us-ascii?Q?h6MaS8j3F0cOFrluDQV7dn5UHwzf6DJtpBv2wk6j350NN0Kc9RnT6nc7TLyq?= =?us-ascii?Q?HXRkCqbaIfE7Jf0r4FUMFNa75zkED9FAe61sd9+OPCLIPI3dX12ptZf+JJPO?= =?us-ascii?Q?DgdVjVXIMbp1dcxxz/48BXcOcxR2bz7j7Ej8A5zlwgaVwFG1C344qLJkt+L9?= =?us-ascii?Q?fS35KJsvA/zst/O2f1q1uoKt7AhlOi/8go/PLPxKrj73JQUjQZiziaZHqNKs?= =?us-ascii?Q?V9ryigpufpoxltxO6xffPBp?= X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1715; 6:rZqWG7mgb6ozlkTvPH0WKNbwIOHtihixIE5e7poTPwCoXKrR0/tVHWS1RVQJGY2RhrCNaPf9AfwXenDpRHrjtwboJJhZH9aikPCyqvQmzTA+8e43gkCRmdeGwCMQD1SOhDEb1rZ/NftwJyWRXCc9qvNIPd1Y2jC1beMALMcQiSTe3s1CB0CJw8DdybYZz3RQlf5nGUVCze6Jpm0wlXiiuj92HnEom0ed3i+KR7JoCDtzZagOp1Q2CfBWD4dNvZouNQlH9YGRpgWwtauNGjDPRSUVWHZdqRsi56R81Q0U7HY7cQ0uayOG5IsGls9C9A2cYRIceQWLjiqaBFROdjXpJy5p9c0Yf+2s/VpO2priQ/OymEm/L2d75q6Xu6kLTEHPZrzEYvFfmhemf1fE9eCuqg==; 5:9eC7HHuy88KniLFtEo1RIBuoDTsLGrMbTfi2WU4BNotmknQvtZJJnGgta1I8FOAkE/xz+6W/BlYRxFP+HCtPvIwWrW3BKM7zGnwelfQfEA+ZH7HyYyY+yu+v8eGEc0CsAvL08JUi9rhsv39vKHY06w==; 24:Lx2Od5dcnl8642BQG5Acbj3YrICxiUTx7vZV7WJW7Xko/e5x6pPpAcKSkJuE4w5gPFfVhR7OZZSf/16fPW8TzH9jIMNrI7cbXNAqnX0gGMI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1715; 7:QcTYtXheAIC0Oxg5bYexUJsl/NUqMAaOvKDOxWQpSZyciX2ZYKZaWbFjMfB+uXbdRq+Zdkk/G24KPKBHUg03m5vd2dkYEjrNu+8nB9/JK2AP4yZ4xp6LH98+Mr+fqZG60MHD05cEKqli23ma/eBDGDslHuEv/uHUWkK+7R1216/GIXx3s3zOM2h4QbSJDpP8wAinJt8ensu8CXZ8hYQAFdWvwZt9YH4C77GcI1vO1kkkn2jhwIqzgOtwbLv0ae6d6eoz797soDG+nL8AHe2O4oNUHXwr03NNE0iE7Jl14lBW8O1KXXIHKi9aKZtSaca9xBeKwR4xJ1I6eh1a04hT1g== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2017 21:28:06.2604 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR07MB1715 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes |
Commit Message
Simon Marchi
March 13, 2017, 9:27 p.m. UTC
I noticed that backslash_in_multi_line_command_test in gdb.base/commands.exp failed on our RHEL6 servers. I traced it to the old version of DejaGnu (1.4.4). I have found that instead of receiving the expected: "print \\\nargc\n" gdb received: "print argc\n" thus breaking the test and its purpose. Versionof DejaGnu < 1.5 mess up sending "\\\n", it somehow gets replaced with a space. I found that the following commit in DejaGnu fixed the issue: http://git.savannah.gnu.org/cgit/dejagnu.git/commit/lib/remote.exp?id=3f39294f5cd6802858838d3bcc0ccce847ae17f2 Even though the commit is almost 10 years old, the following release of DejaGnu was only in 2013, which is why we still have systems with the old code. If the DejaGnu version is < 1.5, we just skip the test. gdb/testsuite/ChangeLog: * gdb.base/commands.exp (backslash_in_multi_line_command_test): Skip for versions of DejaGnu < 1.5. --- gdb/testsuite/gdb.base/commands.exp | 11 +++++++++++ 1 file changed, 11 insertions(+)
Comments
OK. Thanks, Pedro Alves On 03/13/2017 09:27 PM, Simon Marchi wrote: > I noticed that backslash_in_multi_line_command_test in > gdb.base/commands.exp failed on our RHEL6 servers. I traced it to the > old version of DejaGnu (1.4.4). I have found that instead of receiving > the expected: > > "print \\\nargc\n" > > gdb received: > > "print argc\n" > > thus breaking the test and its purpose. Versionof DejaGnu < 1.5 mess > up sending "\\\n", it somehow gets replaced with a space. I found that > the following commit in DejaGnu fixed the issue: > > http://git.savannah.gnu.org/cgit/dejagnu.git/commit/lib/remote.exp?id=3f39294f5cd6802858838d3bcc0ccce847ae17f2 > > Even though the commit is almost 10 years old, the following release of > DejaGnu was only in 2013, which is why we still have systems with the > old code. > > If the DejaGnu version is < 1.5, we just skip the test.
diff --git a/gdb/testsuite/gdb.base/commands.exp b/gdb/testsuite/gdb.base/commands.exp index 6d3c398c6e..4963743d2b 100644 --- a/gdb/testsuite/gdb.base/commands.exp +++ b/gdb/testsuite/gdb.base/commands.exp @@ -1007,6 +1007,17 @@ proc_with_prefix redefine_backtrace_test {} { # while entering a multi-line command (in a secondary prompt). proc_with_prefix backslash_in_multi_line_command_test {} { + set dg_ver [dejagnu_version] + set dg_major [lindex $dg_ver 0] + set dg_minor [lindex $dg_ver 1] + + # With older versions of DejaGnu, the "\\\n" we send gets replaced with a + # space, thus breaking the test. Just skip it in that case. + if { $dg_major == 1 && $dg_minor < 5 } { + untested "dejagnu version is too old" + return + } + gdb_breakpoint "main" gdb_test_multiple "commands" "commands" {