Message ID | 20170227191126.13306-1-simon.marchi@ericsson.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 104236 invoked by alias); 27 Feb 2017 19:12:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 103318 invoked by uid 89); 27 Feb 2017 19:12:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Feb 2017 19:12:31 +0000 Received: from ESESSHC018.ericsson.se (Unknown_Domain [153.88.183.72]) by (Symantec Mail Security) with SMTP id E0.99.31774.C1A74B85; Mon, 27 Feb 2017 20:12:29 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.72) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 27 Feb 2017 20:11:39 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxcz23q12-y4.ca.am.ericsson.se (192.75.88.130) by AMSPR07MB392.eurprd07.prod.outlook.com (10.242.22.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.919.10; Mon, 27 Feb 2017 19:11:37 +0000 From: Simon Marchi <simon.marchi@ericsson.com> To: <gdb-patches@sourceware.org> CC: Simon Marchi <simon.marchi@ericsson.com> Subject: [PATCH obv] Remove struct keyword from range-based for loop Date: Mon, 27 Feb 2017 14:11:26 -0500 Message-ID: <20170227191126.13306-1-simon.marchi@ericsson.com> In-Reply-To: <20170227185535.11586-1-simon.marchi@ericsson.com> References: <20170227185535.11586-1-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BN6PR14CA0005.namprd14.prod.outlook.com (10.173.157.143) To AMSPR07MB392.eurprd07.prod.outlook.com (10.242.22.21) X-MS-Office365-Filtering-Correlation-Id: 0c432ad2-38e3-4f62-ef63-08d45f447460 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:AMSPR07MB392; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB392; 3:+QiBspW3Wv7XzftuuZeAKjPog/5mbFXlSUGK9zaBv5opQmvl1OmgkmjuVaFullDLIF08V7JWxnUQcOV/YTtRi601jbTPPeTsBXinfoV0DnXy1eccbBjvCvHjaFGLqOkX6ZRQXm58LAsRYnJE5eZEipsw0in+RwMXsT+sedShDMHwUXsYAFqioeC64Hq8NcLDKzyr6V7cW8C3vI1e+6E0eV+JNaRyH4crKYRvQ8RLgEreY7Oh5o6nlAgQyCqokfBY9O3X490I2tx8bbWDhaV9RQ==; 25:4ouKbko97zlTCg3dXY92iUXuYTm81iH7hfITEJfCzAO6VwwovCPaoVvAbpwZ0YFghUXtdBNs2sUISJIFl+3K5dBntAxHXB94Ug6FPqJOL93gawqEqFnaTFZ2PCsR6vtXv1pF3IO7cTkbg5QRqrMoLLtqoQUJByoB/kouafm4cLRQlPZPV2OmcjUa9GHezqSAMH1btE3blqdMHKdUlKyzSYLbJu4nCRm1Z9SECG8yFkb24OLW53aii5Nws3nZtXPJGKD3zjUjzNKJgLyM3ZUGKw/v04opa4THSV82dpUCAqmUMpHpqYov1L426Xlr5ylg4EN1sT6PGPBzGJaCAuKxWroHvYoCW9HB/YEONv10WtnvwtuiRd36oHUMxfzfCi7BNEqgP+tYSrZnglOREEk3oWlsdxUdbY/VVMr1DAxEEd8W1VX96pgBSIuAlK02+SXhhXTt/mOELovgvQ0uAE0oFA== X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB392; 31:BF0PYE9FPnfa3jd9IuND8aZv2pLhXMO5R5yY0MxmVOSZUQ/8iAJMSEVgSSsxr3wj32wDlX8SfLz4UWg5Ef8ftxmVe4AUlqA0LWwLdZKputreh/ETv8BeDhQxLb1xxMCrNnfDKy1BzMCM05TeKAFp2SUG9PtGV2uhls/aWMehtbgmLXsvn9B61H0lGmrV8FDGZMHyvt7w+uRQ9UQ1FUyWhTxaU5VaM7PB9sqKuY+Y7JI=; 20:BjGUbXK1uliDEPLlZBW7E27LobigsFfZex8mzQTieedAFfKoJ6sfeECUihZGedfvKr06V6N3t+MNYE+jBKnPKqf6mdxk8xjxZxnPnVl6VIv0WHr8A3rgeQy0nlqy4vchKuaI3RywPzA53v8Sdb2PBcqHLrOexU9gYCyMAA/0eTM2t7MPXSJRPKGAA+TMaG1FtAqq5woz4LEZpUxMc94jw1HPFmosTVukm6ZVOwD+I9U0LAQwD9sQ3ijeZ/I31qXr8CPyVNOtxpubx8vpgr00Im+sRHtv0qySZ4+jg9UFLjzGIZXlsMu6Z+FtfHxa3rxCGaJKWddQ9yL/JMoHkYOiq4Y7TdXS2LiCpJIs4VNxgmwLElc0kVnSxMT911tQAVLm7Qi/ixEq9QDxDQuMLNbuwTOBzRpXny8oHQ7hDAAivi/BlPUqopKzE7EN75NLlMWKWt5yPWa/U7myTugYFg7vCMlwYjAPwkeHRrup4KzN33eEONb6qF8vGMfaM9tP2fF7 X-Microsoft-Antispam-PRVS: <AMSPR07MB39226CEBA92C8B8844CEAE0ED570@AMSPR07MB392.eurprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123555025)(20161123558025)(20161123562025)(20161123564025)(20161123560025)(6072148); SRVR:AMSPR07MB392; BCL:0; PCL:0; RULEID:; SRVR:AMSPR07MB392; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB392; 4:W9bLHzKISHmSVfzf+WyDTU73KiZAWWxByWTVmXAG8mUQP9PqYghIc80p/0UmiCaIgotxZWDWBywrbz8MlamtbmcTihaQP0o5PJ7B/uguWwiQ/ar/Z/Q1Y0kSd8xuQdAL9U32v8xCdRzC3EUnUp2Z5S61+TzG21sIi3CJ3GcJhshv3BwWf87sOV2yzWqQK3MhuG68Fm79OTHN0ICZw3050wIvJ5Rkws5FeGhcgZq02uJb/LdfL//jqIfDp/STfVvddZ2h7cX6qLDbShg7hPJiX1O9n42IWbzlu5d39RJbTU4nCKQ2/vtKDFIrcuJqzE7284wlFN3vOu1Xjst5IGzKqKsp6nlVECB2jPNkrX1euVSQVddV0VKYSarV9+JIenEpH2d5baLcH8+aNPiAYERgjOi3XjbDb75bpzQwolG9YjHhkH3fn9CvCQKQECvDeUhMjrPN/0/yxFKU6PPhouJQe8eHQzEw8IhGMl3EnU9TRzlxNorAN98qKOZGXY18jAu7kFL11xSi1x10WCLvmDM6z7Uk1SN0nZ1iSt9bT6Z2P6gMRC26gSd1K8FTWShpo+E1Ljsp2VjqJHGa+fTIgdh/3aV7OxC0jnEv+v6x97n9uiCOieVieJKXWRyj/kvh967HwYrwTUAfqr9v4ITe7qGN8w== X-Forefront-PRVS: 02318D10FB X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(69234005)(189002)(54534003)(377424004)(199003)(36756003)(6486002)(23676002)(97736004)(189998001)(6506006)(25786008)(7736002)(5820100001)(76176999)(66066001)(450100001)(305945005)(6916009)(50986999)(50466002)(47776003)(2950100002)(6666003)(106356001)(68736007)(4326007)(50226002)(2906002)(53936002)(38730400002)(5660300001)(42186005)(2351001)(1076002)(2870700001)(110136004)(92566002)(107886003)(6512007)(81156014)(6116002)(3846002)(81166006)(105586002)(8676002)(101416001)(86362001)(33646002); DIR:OUT; SFP:1101; SCL:1; SRVR:AMSPR07MB392; H:elxcz23q12-y4.ca.am.ericsson.se; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzOTI7MjM6aWhKaUlpQnB3K0ZFOEJhakpFek9yVVV1a1ZU?= =?utf-8?B?dThxbWU0RFBoazVrUDlMdk90c0lNQVFjREpsblVTbzR0c3V5WkRyMFcrU04r?= =?utf-8?B?KzYyLzFZajNzamJ6TUxGQUM1MGM1aFUrTjVOaDB3T3p5aEVCOTNBN3JLbFBI?= =?utf-8?B?WitNV2ZqT1J0Yjc3cDEvcWhVVmFYWWp1YlVRcmxLM3ArcGRHczg1dW9aZHY1?= =?utf-8?B?TmFsTmU0QTdZcDFvYkdObVpFTUFZem5UcWpvcFcvbnlYTnVKTHFUQ0NrUG9a?= =?utf-8?B?YW9YVWdKZ0dLM3RwNGw4YnZ6Z1VIaUE4R0s0OGFEaEtleVhjcHhPQlB5dlcy?= =?utf-8?B?aCtwMmFGWVlQVC9LaVR5enJXM1d5Tk5TVCtadWFndU1vNWZ1RHV2N1MvUDZO?= =?utf-8?B?NnN5RjlxLytXU3ZxdkdSL2QwVk1WQmFYYVBaNE1yelVvRlVsMDdCaXBNQXVN?= =?utf-8?B?Y2JyZkZBNzZOQXppWVczZkNCTmJMeXk3Ukh6K205QW1ycW1pd1B1dHo4U1hh?= =?utf-8?B?Y3l1cngxVDhsNC81WFpBY2VGaCtwMmJ4MGc4K1d1WElBMDlkMDZmWEppMTZt?= =?utf-8?B?L2VTcUg0bGJqdW5Na1VKczVWaFIvcnJMZmh5NVBzWjczaUR6ajJYNWxVUFRM?= =?utf-8?B?Ui9ZcVJzQ25vbk0wMGJXVGdzb2tzOWdaaEduNkNraEExcG9MRjN6TE9oYkVQ?= =?utf-8?B?a1pXZXpsVjNxNWZjL2NLYllmUWkvd1loNmR3bS9WUVJLbG05aDZpeFFUMDBU?= =?utf-8?B?MGVjc2o3VTd2UUtVS1k5V25hZ2F2RkltNGw2WEp1aFpZQThRb3JyQ2VqZDdi?= =?utf-8?B?RnpkMXd4cWwrRmwzVXcwRXlvSU5sZS9QK2M4RW85d01yaUJxYWNEajd5NlVx?= =?utf-8?B?VDMwZERRRGdiUjdveC9OTE13NWlNWE9KMTlFZmE2M2xMR3NMczdWbXFmMmJ3?= =?utf-8?B?WVJ2d1phdm8xWU8vTHVsM2pJUlExUjZiNzQxZDRSNDdwa2paam9KaTZkemU1?= =?utf-8?B?NkdvSkVsQk1BdWVmSk5GNVpwcEV6QXFzQTY3OTdadjJ0OG9qa3hEUlY0clEy?= =?utf-8?B?V2tiMTRLQlNleHpVNjMwaytnNk8relJoUGh4aEcxcm82Q3Z3UGVUTktkVHhu?= =?utf-8?B?NmJva0ZIcHF2TFFaRmRCZVVNYkp6d2x0RHdvV1k5SVhTdEdlV1dKYWxJRmlU?= =?utf-8?B?S3JFWUxNZzZqUTh1UWtnWkNROHpHTnA0eGt1bG5EeElGaXNWMzIrMHRVOVhy?= =?utf-8?B?RHN5VTNTeTFwZzZjekFBSlFDS1NReSt6UCttWDUxalZSbHdReEQ1cHN6eXNo?= =?utf-8?B?WXd5Q2Y5Z3J5ZWZiSWl4dHlUcGRBV1VnMEkxRk80TkpTRmJIWWRYaHNHR3lm?= =?utf-8?B?YzJPT3VEQnhJNjNybm9jU0Y2Y0tjY1crSWRIZFF2WGlYMzZSS091TDR1TDJS?= =?utf-8?B?ZnVzdHhVaFFPN1M4U0VTTWZqWGZYWFdkcndyUmZVZG9WUEhHZjFpZXJvUVZC?= =?utf-8?B?YSt3TFZ3R0pZT1UyanZnQ05pdlJFWSs4UFZncmlBNmdDOHJWMHFoOU1NalNy?= =?utf-8?B?bHZVREFDbm1XUUVuV280N0JCR0VqandPQ081MExNRzMxRGNtWlovUDNnU3VV?= =?utf-8?B?QUxPL0NRNk5aMUtyVzZtQlVNOGRWMUdKcmloUTJVKzBqV1VaYXFQWG5EWUJG?= =?utf-8?Q?6R1b0Hk3dUnIMhHwZNzQ2tyIkbVk4oTFWW/4YH?= X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB392; 6:EoVvRFM+dR+EY7YCk3zXpwkI7UhPvkq+kdDT4egr+0LASeXHPoQP+fDE5YjogoMOUh4nOQDshLeSezZZBZ0fEoTIIC7MTDnWa+FVMRapzNAlCyCEhf0vMjJiti5WeLGq/Um2aqcIM4RqWvmsbbwPOKNbDcm+YppgDgJYMVoLsKfAqCGi25Vu27LzwH4/1r2x5cTQB8TxwdqB1i0sZuLZjmIpoK8yfzKT7/oncHipia9FsvYV0JyRSbBrAa3PSySWy8GW9rWpjmS6bZPTPvs+b0Tlzgv6geZiv+NaDxohhMtt3bzScQBUAEdClZKD8KuIX6Hr2NSc4KrumUxRrJwYsiqNlu3uHb74NdzPyLyuasrBVqM3KFkioieYJTeUtELX3/rNx0OI5NOfxb/FDllQoA==; 5:P70XEiqzfH1R5wKPbk6SwfwkRqC+QlWWyPaBZQ6mVh55uEmTKby6tX2T/g2ANusCO3mEmYQOQldzErVn5u439Zk73GqWNvqdHdDkQr5bL+AFg16wZLknwIsbx2S0vCfrn/1xEYuDJU1216FTog0Gpg==; 24:Uj5Wiw1b1UrgNjnyhZyx0VHfuWQ13acH8GJM14VDzn5nImLBpwR59X2vYVbc5ChkFB3GkiHqHnZjFfj04okpCqisTxrbAoMRb45ugY0X820= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB392; 7:mhSu1kYmEO2r79wOKmrebErTTqIBKIG8cwldUyIfL81Hys0dHZ5c9hO5FKNHgwJj99sIvv9VbkzG9vxngWo846hlezBmiOD3ZPycYxgT+25ceKvxAK3bVtB17hO/GAYnjqmWop3MmUEjGBW3ZKPswyPNfPdl/LgsAmH9YLzuv6yiTjrBzfNhvpFD3yXxL5XRzpOJ0f62BzlIz3xOTkwi8r1monq45jCOffgbs0ql9dytvvkSKssfHo/UsD+7Db2uQLa1NKHTbnQ51q3w9jdi5aBCk69qlARsD3fiH61ksWqC4RW0Y3NOH7ySx/9wAhaoG62t0H9J5XxVp0i/EgdlHQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2017 19:11:37.6513 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB392 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes |
Commit Message
Simon Marchi
Feb. 27, 2017, 7:11 p.m. UTC
FYI, I have pushed this as obvious. My previous patch does not compile with a recent GCC. The previous patch introduced this error with recent-ish GCCs: ../../binutils-gdb/gdb/remote.c: In function ‘int remote_add_target_side_condition(gdbarch*, bp_target_info*, char*, char*)’: ../../binutils-gdb/gdb/remote.c:9668:8: error: types may not be defined in a for-range-declaration [-Werror] for (struct agent_expr *aexpr : bp_tgt->conditions) ^~~~~~ Removing the struct keyword fixes the error. gdb/ChangeLog: * remote.c (remote_add_target_side_condition): Remove "struct" keyword from range-based for loop. --- gdb/ChangeLog | 5 +++++ gdb/remote.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a872f1bfb9..fafa10c84e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2017-02-27 Simon Marchi <simon.marchi@ericsson.com> + * remote.c (remote_add_target_side_condition): Remove "struct" + keyword from range-based for loop. + +2017-02-27 Simon Marchi <simon.marchi@ericsson.com> + * remote.c (remote_add_target_side_condition): Use range-based for loop. Update comment. diff --git a/gdb/remote.c b/gdb/remote.c index aedbd08cc4..5da8319823 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -9665,7 +9665,7 @@ remote_add_target_side_condition (struct gdbarch *gdbarch, buf++; /* Send conditions to the target. */ - for (struct agent_expr *aexpr : bp_tgt->conditions) + for (agent_expr *aexpr : bp_tgt->conditions) { xsnprintf (buf, buf_end - buf, "X%x,", aexpr->len); buf += strlen (buf);