Message ID | 20170111155847.13244-1-simon.marchi@ericsson.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 29653 invoked by alias); 11 Jan 2017 15:59:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 29636 invoked by uid 89); 11 Jan 2017 15:59:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1223 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Jan 2017 15:59:10 +0000 Received: from ESESSHC024.ericsson.se (Unknown_Domain [153.88.183.90]) by (Symantec Mail Security) with SMTP id 14.72.17130.C4656785; Wed, 11 Jan 2017 16:59:08 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.90) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 11 Jan 2017 16:59:01 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxcz23q12-y4.ca.am.ericsson.se (192.75.88.130) by DBXPR07MB397.eurprd07.prod.outlook.com (10.141.14.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.6; Wed, 11 Jan 2017 15:59:00 +0000 From: Simon Marchi <simon.marchi@ericsson.com> To: <gdb-patches@sourceware.org> CC: Simon Marchi <simon.marchi@ericsson.com> Subject: [PATCH] Remove dead serial_interface_lookup calls Date: Wed, 11 Jan 2017 10:58:47 -0500 Message-ID: <20170111155847.13244-1-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: SN1PR0501CA0030.namprd05.prod.outlook.com (10.163.126.168) To DBXPR07MB397.eurprd07.prod.outlook.com (10.141.14.146) X-MS-Office365-Filtering-Correlation-Id: 52b7d2f8-4c9c-4c0d-3a90-08d43a3ac23b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:DBXPR07MB397; X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB397; 3:AC2zOr0U8/WpMF4sd2G4xbatZV5fRGWQsf6X+PL+tadExcAzyngQKnoQykDWyoSgisJaASQBLtg/T4U18yQ+1eGuLFUWcQSnaKo6K5g80fd3yd4WC5x20SxAHz7PSuBfuz0T9b8FNcmTuJR40rdNfGXqq/n1gZWZoBI2cPRe87izjkTJxJHRphwtnA4e28UxyFGa4AaGqZPn0lqzCugB4radYiv40RuqvwYojTTADRiNDnwFrQ3WczeM3N0gi0z7ihHD0tOrEk7M5rW/hDpOGQ==; 25:CyVtaxa7vabZ40JdNggNBZU7LPwLSGjrbO7OPJWRRLGrKbBeYspYPTscLg4mhLS8iONdzYX0GrrjqLisM5xfCGJklyA1cR2y8HmDAtUUxrD5CXrdovhngeGILiuYQ2k8UlAi/aWFHxXWHpoQjCpAFZUa34pEuMtMooXe8sxa2XlpRAwEGTMr6XbaiyvZK45OGr59bgVApcy0cAUQ0Y5jkv9t34qrZ3O+JIkOY4ov5shUDLwMh5I9NNI2ootLPkqeeytCd0rKvHsruRp2lSqZV/gqzoOMN9WvbwmbwB/I0I08v/TI4NLcID4flNVf+RB2jTB7elr01182IIS8dpaMNqA4OtgBogaNDmiykOVmtP/58muAuAnm47y1YnX7bMfdzGeGfuFUE/qpRoxQEZGvyrtukuyMFyFIUFiYIt5BgTrtF6fD3CDH2Vwblj+YbhpvJPrje7FtbznEbPxejrsk8w== X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB397; 31:6H4cgcPila3fSbH2StcRYYOxEMW8bzenPnbJ2ZxVqT0ZD/cSoKWfcNKEkRicTroDVe7PROwdly49J228GOsPjWEnlP43tFeBpnRRYC1jru/DPJFMt7K8uY3FQlAOl5gZtSWx1EtdCw0cdARmTHZkBP+WBlwI07FLLvnkLC7j820H9Pgv1EOzf8/6yUwrYR9CYYeJFUjmqPV0Jw8uG2ifJpQCaPWi6FRNxOM+T9R9J95RzqS0e9U8tlxM/Wdib8LYDCrdMWf5nmbROYieF1LV8Q==; 20:8yGjKKlRbzS31aWtBiJn6ka3oYfSgyeifYWre8UKSEa2hdXostSt/tZFHX7NVGjBKynTtjFiNodsIhIbGxGB7SkdPsOPoDf19QKwVt/joKlpn9PMNI0YSXSxQ+I467FZNdz1Jywgssha7qOVYKu/xK51KCv/zxHa+qiqhflCHQ4rPvY2fGaxZsG8VCXLwIGOzT/J2aXcNyxvIPFKFYJ+HuWsmSDYsP7Q5lvdx2tps0AppUHW7eNkO6j4MfRz6FOdR10oO+XJEHHi86g8u82xFDf7EMdAm72q5jdo0iBSlP796HXcCviyQf9QpCUC9OZcfyHge+V+zcE75S0Gpr6w5CSS6aW13b/y4LDatruBjfbnh93ytNhBtWvGCqaLY9mdUxRQY2T7DuXh3du1qfJoETNsqYi3rUK7GZZYzq9MKsDDL2yYxheHTHKh0MG2DMA81RWr4xmS4x/8hzxZmtmv+L3ajBvg1nIWTCkm5/0jeFl/VPE8Bn6sUgLwIgbDJWzJ X-Microsoft-Antispam-PRVS: <DBXPR07MB39745204CC304C011D3246BED660@DBXPR07MB397.eurprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148); SRVR:DBXPR07MB397; BCL:0; PCL:0; RULEID:; SRVR:DBXPR07MB397; X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB397; 4:pcOJA0fkcxo+aaKyW/K8JKIJWx54rZ1JMZ178TOp2PtxUM6wwPhgUdPc42CQG7C3qZTHm0r2M9s/ddHy6aOLpOP1Tr1hsMLgzwZfcj10WcsK6A9Ke2I+WZ9zteBzlnXcEPxMIsrl6TfcdJ+X3L4c9p9SWgMSvM6wzBA1KZJrseMNQ0hW1zFq6YZFN3L8EtGdTQ8XJnChfbx+0g0xCccOigKXmfzGEFGzQH97K8X3LAnrBT3+7/j+6sFqNjcm/2Tb1II6fOYSotrBFVrAu5Lg82YVFZwI6Uh0esECYiMPl9Tvo+l+7AVGwApzpRvmbdhkLykBzxzGijo2lRmU2yoKg9ljIP/wL9AmlOyZLD4WsYMAraG6hKlaHlZsP4qo8XX26QX1mvdDqMb2CFuS4iIQ4zTzWtNkYT79Ewp8Eh+N/PlTfEhi+U+CcUB2Q6IwOwQCw6dBGE+Rugu3WfCO+yY4ccFXhk5i42Wci7Oy2xJesuPuoQIQIVaLQexXw2FY7zaTDbkzLEEjNfzaNYr9cMfY8daUSgPtAqXlrusWgq2lKV9eXxpjYvTlF402BcS5jnWqcvVt5NP89IHyhZXye6KnhA== X-Forefront-PRVS: 01842C458A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(54534003)(189002)(199003)(50466002)(5003940100001)(81166006)(5660300001)(97736004)(8676002)(50226002)(2351001)(7736002)(4326007)(305945005)(50986999)(66066001)(81156014)(48376002)(36756003)(47776003)(42186005)(6666003)(86362001)(2906002)(101416001)(105586002)(6512007)(6506006)(110136003)(106356001)(38730400001)(68736007)(189998001)(92566002)(1076002)(450100001)(25786008)(6916009)(4001430100002)(3846002)(6116002)(6486002)(107886002)(33646002); DIR:OUT; SFP:1101; SCL:1; SRVR:DBXPR07MB397; H:elxcz23q12-y4.ca.am.ericsson.se; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB397; 23:j3CJVnhgp3G3FaS4AyX4mtuSqz2KjWPGk08oBqe7BH?= =?us-ascii?Q?Nv4o9sHvuUeOxU8TabeT/UnnQUVIi2aOJPqIqwCyTRqpK5hiaIXudIGZDGzH?= =?us-ascii?Q?Wcft9fT2y+yoh2dKHmw6cWD8kzybQXAOi1uJLa7aU0AWc7BDS+FqYPX5OooQ?= =?us-ascii?Q?BBbnAZsmHBKDCqpPKo4GCfYfGtG318GS+vB4K/+KrSqPXuP7DEQ5rRJI97dg?= =?us-ascii?Q?vF3EYK9BWDNQ63e8kpnNtpi0Qzu4V5bc7ShcDFFuJ7P5U3VBLc7k6m2Ef9q0?= =?us-ascii?Q?Nag0lXO2IUv1c9vwwMuWoa7pssRwow3RKm75w49rkuaVxI3BPaarEUOZMTwx?= =?us-ascii?Q?H7E2IwQ6yMOvqyqdVU7tNCCCG5DhLgD9U/w6B6odHLw+yqRyR4DzgJYrujGP?= =?us-ascii?Q?Waoi5KX17ltcyXqIuT51Qtz1l90lFm3kyMqWzWKqAW/dg+WCyxmrvh+urkj7?= =?us-ascii?Q?E7urK+X3fXcLrlH5mEzWcy1E2/ptHfz9SluAs9ITlSXM4+J9Oua1WcKqITJv?= =?us-ascii?Q?llliWNf43+2k93CKpIbk0AtkWtXx+tWI2BW2Q6TwfKTCSua/Zc3rI+SfRvDK?= =?us-ascii?Q?WOpeoVwGeQx9f18gBJxL79sZ/yGAn2JnLysLdIbaAXKiD/tEi1z84lGkHW07?= =?us-ascii?Q?CT0Ro1XvoNfUrUMusUoOx0gEg9/UazWWg5qY6lLHY57AOqJ9N8lvMrBpWTQb?= =?us-ascii?Q?tL8rABmWH1Kn3fjMXkCwfdp5/IcKozT4Nh8kgFwEPhCL8bzT3BSa/P3XDTdH?= =?us-ascii?Q?4zK7jmo1JDi2LkGfSb2wHGGD5/tLRQ/ltKae7ZqatysNaHwqcSuYL0gbxBcA?= =?us-ascii?Q?wNTUSUMWZjiQ+FDOszL8qmsF2TcwHSQkK9e/7+eEoQeHNLcxecqhg4nYG68Y?= =?us-ascii?Q?TnnoadaieBgmAUWriG4YxX95hPCzDe2ZkfcpIbFkCvHu5ktd7RJqkAOs5XOZ?= =?us-ascii?Q?qi+2b14ADtWGUrThQut7E3EId5Y0a22LIYMkuEZk087pAqCtD7qT5nwX8yLn?= =?us-ascii?Q?rYUlWQDAR8629vOKM4E0VipnIwtUCqR/MtY3PKcd4eYpncsOy1rpyj5jfLC6?= =?us-ascii?Q?rfKtkK89eZsETJETOMY77uIHFxbOBz9To6FKl0sRe8tEBaXp/+HrFCTpIK7H?= =?us-ascii?Q?JefAUzFKkaNVip4gRlUO94iMX/I8W7EnKwFhoo4E0O5upNaR0GOg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB397; 6:ziVgSbyVBAinHcVqt2539jKW932KFF/41f41MV84M2fe0ey9wQQDvqgT3Pc7OYFw0FRgLazmuYJItHiidF1T0AGZeh/G0AClIw48XGo5zV64QJeJy2mlEiEqGmSGrzY18Mw6AaD/SKJptkvQIbatt2gqTgUiu4J9Xd8q2dkq9ch/NmCBpEEM6OKmnTz2SY4FyibcVhRPzoLcDmVrnL/icnBZMS/rvsBl0FNrfxlvpepc16rRPRACBw132iNcR34/ZRxnmWayd002/m+CZaBuNmlHUIQU2lqOmfnhGE+j9gszMOMHc6zpRICqJCaTPePESjvUceoUlUmwyzy3JUHL8GQdNn/Sugcw88o5cHJ1llGbS0WdHsNnu5HueLR7sNKMsvFk3d1h89KbTwa0jAmTn0iUDKjRt4h6L8QGdLlu/mE=; 5:MbswkBo+dJ919jxEfEQ6YbhITdAgcbfVDkzszgXpDGmgeD0Dv+DQM26Mw1yhsUOWWgC6Z98xO44A6rU4Y1BiFJUMwMfWOGcOxRQy6xUTN9my6BrEJWILPunKuHXu6J+GN4SIEzrn+4Y+NgR7lgPUfA==; 24:rMau5IuTzyjqkYdU9w2FPTY/9ZjO6ice0l/k504qh/77cZ1QLY6qOboVeLO7MdK9ST4tOu+k2G8MxfecXNVbU2DL1Z2tYIVhfajQsAMvrIA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB397; 7:A/hAP/HFmEOl2Ywi701SJTnRQe6lvaBQLsc7OG5DX4qkrQ73IZPhlJjxE7KX8z9gXlj68Ev0m6sijYnyFM2cywdxwG1WQZ9xhJdulzGpKwlOLVmYjRORjWUkvy/dsv1dvXD+49qjmYT7hKf1hNZVKL/Xp9VqnSSd/Zw9v9QBmkV9d1h0tckaL5q4I+tR7mo9YM8YfMthq/VMC1ZDGhFxI7AfGrCjIidO+8agsukB5GPVA02uCxk3HRjfKYGQjLB95DzuRTmeGZtK3Yh3V/XwSE6E1e8DYTbIqJtOvhy2Kw9CMEmtXFwSGAvBPVn/HkX3Qi7OYJDFBN6klzm4Jf65n4oWHfL6bT/oD6KB1YZ5cKTUqn/fO47dFteWJgESlWsctZQHJaet9Pzp/DjN1v8tKrYYUfOvgY2qUqiYMhOXYA0pc+599nonx1TBk28hUoQO6CJF3CtNSgWh7dkXlEG+hA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2017 15:59:00.0452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB397 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes |
Commit Message
Simon Marchi
Jan. 11, 2017, 3:58 p.m. UTC
By inspecting the serial_add_interface calls, I found that the serial interface names that we have today are: - hardwire - terminal - pipe - tcp - event The calls to serial_interface_lookup with any other names are most likely leftovers which can be removed since these serial interfaces don't exist anymore. If you go back to the commits that added the lines this patch removes, you'll find the serial interface that existed at that time. gdb/ChangeLog: * serial.c (serial_open): Forget about "pc" and "lpt" serial interface. --- gdb/serial.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
Comments
On 17-01-11 10:58:47, Simon Marchi wrote: > By inspecting the serial_add_interface calls, I found that the serial > interface names that we have today are: > > - hardwire > - terminal > - pipe > - tcp > - event > > The calls to serial_interface_lookup with any other names are most > likely leftovers which can be removed since these serial interfaces > don't exist anymore. If you go back to the commits that added the > lines this patch removes, you'll find the serial interface that existed > at that time. It would be nice to show the commits remove these serial interfaces. > > gdb/ChangeLog: > > * serial.c (serial_open): Forget about "pc" and "lpt" serial interface. Patch is good to me. > --- > gdb/serial.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/gdb/serial.c b/gdb/serial.c > index ac7c1b99c1..afb70758c6 100644 > --- a/gdb/serial.c > +++ b/gdb/serial.c > @@ -209,11 +209,7 @@ serial_open (const char *name) > const struct serial_ops *ops; > const char *open_name = name; > > - if (strcmp (name, "pc") == 0) > - ops = serial_interface_lookup ("pc"); It was removed by cb2a4ac5dae478fcd9d6e772530c3aba0576fc7a -static struct serial_ops e7000pc_ops = -{ - "pc", - 0, - e7000pc_open, - e7000pc_close, - e7000pc_readchar, - e7000pc_write, - e7000pc_noop, /* flush output */ > - else if (startswith (name, "lpt")) > - ops = serial_interface_lookup ("parallel"); It was removed by e386d4d2fb55042f77d0557a0849ed2464aee7b3 -static struct serial_ops go32_ops = -{ - "parallel", - 0, - go32_open, - go32_close, - go32_readchar, - go32_write, - go32_noop, /* flush output */
diff --git a/gdb/serial.c b/gdb/serial.c index ac7c1b99c1..afb70758c6 100644 --- a/gdb/serial.c +++ b/gdb/serial.c @@ -209,11 +209,7 @@ serial_open (const char *name) const struct serial_ops *ops; const char *open_name = name; - if (strcmp (name, "pc") == 0) - ops = serial_interface_lookup ("pc"); - else if (startswith (name, "lpt")) - ops = serial_interface_lookup ("parallel"); - else if (startswith (name, "|")) + if (startswith (name, "|")) { ops = serial_interface_lookup ("pipe"); /* Discard ``|'' and any space before the command itself. */