diff mbox

Update comment in linux_nat_can_async_p

Message ID 20170110203026.31683-1-simon.marchi@ericsson.com
State New, archived
Headers

Commit Message

Simon Marchi Jan. 10, 2017, 8:30 p.m. UTC 
  I think this comment is outdated.  Nowadays, linux-nat is always async,
unless the user has explictly turned it off with
"maint set target-async off".

gdb/ChangeLog:

	* linux-nat.c (linux_nat_can_async_p): Update comment.
---
 gdb/linux-nat.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Yao Qi Jan. 11, 2017, 8:25 a.m. UTC | #1 
On 17-01-10 15:30:26, Simon Marchi wrote:
> I think this comment is outdated.  Nowadays, linux-nat is always async,
> unless the user has explictly turned it off with
> "maint set target-async off".
> 
> gdb/ChangeLog:
> 
> 	* linux-nat.c (linux_nat_can_async_p): Update comment.

Looks good to me.
Simon Marchi Jan. 12, 2017, 4:05 p.m. UTC | #2 
On 2017-01-11 03:25, Yao Qi wrote:
> On 17-01-10 15:30:26, Simon Marchi wrote:
>> I think this comment is outdated.  Nowadays, linux-nat is always 
>> async,
>> unless the user has explictly turned it off with
>> "maint set target-async off".
>> 
>> gdb/ChangeLog:
>> 
>> 	* linux-nat.c (linux_nat_can_async_p): Update comment.
> 
> Looks good to me.

Thanks, I pushed it.
diff mbox

Patch

diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index dd5c6d2c4d..c58ed83efd 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -4417,9 +4417,8 @@  linux_nat_is_async_p (struct target_ops *ops)
 static int
 linux_nat_can_async_p (struct target_ops *ops)
 {
-  /* NOTE: palves 2008-03-21: We're only async when the user requests
-     it explicitly with the "set target-async" command.
-     Someday, linux will always be async.  */
+  /* We're always async, unless the user explicitly prevented it with the
+     "maint set target-async" command.  */
   return target_async_permitted;
 }