Patchwork [1/2] gnu: Add r-bit.

login
register
mail settings
Submitter Ben Woodcroft
Date Dec. 13, 2016, 10 a.m.
Message ID <20161213100008.19640-1-donttrustben@gmail.com>
Download mbox | patch
Permalink /patch/18422/
State New
Headers show

Comments

Ben Woodcroft - Dec. 13, 2016, 10 a.m.
* gnu/packages/statistics.scm (r-bit): New variable.
---
 gnu/packages/statistics.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
Ricardo Wurmus - Dec. 13, 2016, 4:30 p.m.
Hi Ben,

thanks for the patch!

> * gnu/packages/statistics.scm (r-bit): New variable.
> ---
>  gnu/packages/statistics.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index 36f1889ef..ea9ef0e39 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -205,6 +205,29 @@ publication-quality data plots.  A large amount of 3rd-party packages are
>  available, greatly increasing its breadth and scope.")
>      (license license:gpl3+)))
>  
> +(define-public r-bit
> +  (package
> +    (name "r-bit")
> +    (version "1.1-12")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "bit" version))
> +       (sha256
> +        (base32
> +         "0a6ig6nnjzq80r2ll4hc74za3xwzbzig6wlyb4dby0knzf3iqa6f"))))
> +    (build-system r-build-system)
> +    (home-page "http://ff.r-forge.r-project.org")
> +    (synopsis "A class for vectors of 1-bit booleans")

Without “A” please.  Just “Class for vectors …”.

> +    (description
> +     "This package provides bitmapped vectors of booleans (no NAs), coercion
> +from and to logicals, integers and integer subscripts; fast boolean operators
> +and fast summary statistics.  With 'bit' vectors true binary booleans

“With *the @code{bit} class* vectors *of* true binary booleans …”

> +{FALSE,TRUE} can be stored with 1 bit only, on a 32 bit architecture this
> +means factor of 32 less RAM and a factor of 32 more speed on boolean
> +operations.")

I’d leave off “, on a 32 bit architecure …”.  If you want to keep it,
though, I’d suggest making this a separate full sentence (or at least
separate them with a semicolon).

> +    (license license:gpl2)))
> +
>  (define-public r-colorspace
>    (package
>      (name "r-colorspace")

Pity it’s GPL2 only, but this seems to be correct (there are even
license headers with an explicit version).

Okay with these changes.  Thanks!
Ben Woodcroft - Dec. 14, 2016, 10:45 a.m.
On 14/12/16 02:30, Ricardo Wurmus wrote:
> [..]
>
> Okay with these changes.  Thanks!

Quite right. I made a few more changes to the description and push the 
series ending in 'ce3f92e7018e140f5e6b7333a604f26506de6c2a'.

Thanks for the prompt review.
ben

Patch

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 36f1889ef..ea9ef0e39 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -205,6 +205,29 @@  publication-quality data plots.  A large amount of 3rd-party packages are
 available, greatly increasing its breadth and scope.")
     (license license:gpl3+)))
 
+(define-public r-bit
+  (package
+    (name "r-bit")
+    (version "1.1-12")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "bit" version))
+       (sha256
+        (base32
+         "0a6ig6nnjzq80r2ll4hc74za3xwzbzig6wlyb4dby0knzf3iqa6f"))))
+    (build-system r-build-system)
+    (home-page "http://ff.r-forge.r-project.org")
+    (synopsis "A class for vectors of 1-bit booleans")
+    (description
+     "This package provides bitmapped vectors of booleans (no NAs), coercion
+from and to logicals, integers and integer subscripts; fast boolean operators
+and fast summary statistics.  With 'bit' vectors true binary booleans
+{FALSE,TRUE} can be stored with 1 bit only, on a 32 bit architecture this
+means factor of 32 less RAM and a factor of 32 more speed on boolean
+operations.")
+    (license license:gpl2)))
+
 (define-public r-colorspace
   (package
     (name "r-colorspace")