Patchwork gnu: python-flask: Make python-click a propagated-input.

login
register
mail settings
Submitter Danny Milosavljevic
Date Dec. 4, 2016, 11:10 a.m.
Message ID <20161204111030.23002-1-dannym@scratchpost.org>
Download mbox | patch
Permalink /patch/18170/
State New
Headers show

Comments

Danny Milosavljevic - Dec. 4, 2016, 11:10 a.m.
* gnu/packages/python.scm (python-click)[native-inputs]: Move to ...
  [propagated-inputs]: ... here.
---
 gnu/packages/python.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Marius Bakke - Dec. 4, 2016, 6:07 p.m.
Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/python.scm (python-click)[native-inputs]: Move to ...
>   [propagated-inputs]: ... here.
> ---
>  gnu/packages/python.scm | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 8f8b0de72..9c3902c3e 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -9153,9 +9153,8 @@ useful for solving the Assignment Problem.")
>      (propagated-inputs
>       `(("python-itsdangerous" ,python-itsdangerous)
>         ("python-jinja2" ,python-jinja2)
> -       ("python-werkzeug" ,python-werkzeug)))
> -    (native-inputs
> -     `(("python-click" ,python-click)))
> +       ("python-werkzeug" ,python-werkzeug)
> +       ("python-click" ,python-click)))

The commit message and diff is contradictory :) Did you mean to make
python-werkzeug a native-input?
Chris Marusich - Dec. 7, 2016, 5:57 a.m.
Marius Bakke <mbakke@fastmail.com> writes:

> Danny Milosavljevic <dannym@scratchpost.org> writes:
>
>> * gnu/packages/python.scm (python-click)[native-inputs]: Move to ...
>>   [propagated-inputs]: ... here.
>> ---
>>  gnu/packages/python.scm | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> index 8f8b0de72..9c3902c3e 100644
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -9153,9 +9153,8 @@ useful for solving the Assignment Problem.")
>>      (propagated-inputs
>>       `(("python-itsdangerous" ,python-itsdangerous)
>>         ("python-jinja2" ,python-jinja2)
>> -       ("python-werkzeug" ,python-werkzeug)))
>> -    (native-inputs
>> -     `(("python-click" ,python-click)))
>> +       ("python-werkzeug" ,python-werkzeug)
>> +       ("python-click" ,python-click)))
>
> The commit message and diff is contradictory :) Did you mean to make
> python-werkzeug a native-input?
>

The diff here looks correct; Danny removed the native-input line, so the
result is that python-werkzeug and python-click are both
propagated-inputs.

Patch

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 8f8b0de72..9c3902c3e 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9153,9 +9153,8 @@  useful for solving the Assignment Problem.")
     (propagated-inputs
      `(("python-itsdangerous" ,python-itsdangerous)
        ("python-jinja2" ,python-jinja2)
-       ("python-werkzeug" ,python-werkzeug)))
-    (native-inputs
-     `(("python-click" ,python-click)))
+       ("python-werkzeug" ,python-werkzeug)
+       ("python-click" ,python-click)))
     (home-page "https://github.com/mitsuhiko/flask/")
     (synopsis "Microframework based on Werkzeug, Jinja2 and good intentions")
     (description "Flask is a micro web framework based on the Werkzeug toolkit