diff mbox

[obvious?] Revert change to gdb.cp/ovldbreak.exp

Message ID 1480698816-10237-1-git-send-email-lgustavo@codesourcery.com
State New, archived
Headers

Commit Message

Luis Machado Dec. 2, 2016, 5:13 p.m. UTC 
  This reverts the timeout handling (removed by
018572b88885ae67d22612937fa1e4fd98d5f5ad) for gdb.cp/ovldbreak.exp until we
decide what to do about this particular function.

I take it it is obvious?

gdb/testsuite/ChangeLog:

2016-12-02  Luis Machado  <lgustavo@codesourcery.com>

	* gdb.base/ovldbreak.exp (take_gdb_out_of_choice_menu): Restore
	timeout handling.
---
 gdb/testsuite/gdb.cp/ovldbreak.exp | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Pedro Alves Dec. 2, 2016, 5:32 p.m. UTC | #1 
On 12/02/2016 05:13 PM, Luis Machado wrote:
> This reverts the timeout handling (removed by
> 018572b88885ae67d22612937fa1e4fd98d5f5ad) for gdb.cp/ovldbreak.exp until we
> decide what to do about this particular function.
> 
> I take it it is obvious?
> 
> gdb/testsuite/ChangeLog:
> 
> 2016-12-02  Luis Machado  <lgustavo@codesourcery.com>
> 
> 	* gdb.base/ovldbreak.exp (take_gdb_out_of_choice_menu): Restore
> 	timeout handling.

OK.

Thanks,
Pedro Alves
Luis Machado Dec. 2, 2016, 5:39 p.m. UTC | #2 
On 12/02/2016 11:32 AM, Pedro Alves wrote:
> On 12/02/2016 05:13 PM, Luis Machado wrote:
>> This reverts the timeout handling (removed by
>> 018572b88885ae67d22612937fa1e4fd98d5f5ad) for gdb.cp/ovldbreak.exp until we
>> decide what to do about this particular function.
>>
>> I take it it is obvious?
>>
>> gdb/testsuite/ChangeLog:
>>
>> 2016-12-02  Luis Machado  <lgustavo@codesourcery.com>
>>
>> 	* gdb.base/ovldbreak.exp (take_gdb_out_of_choice_menu): Restore
>> 	timeout handling.
>
> OK.
>
> Thanks,
> Pedro Alves
>

Thanks, pushed as 008459ea88ad4fdcb7da37dad7f68888ef6ecc47.
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.cp/ovldbreak.exp b/gdb/testsuite/gdb.cp/ovldbreak.exp
index b6c5efd..2c1ff6c 100644
--- a/gdb/testsuite/gdb.cp/ovldbreak.exp
+++ b/gdb/testsuite/gdb.cp/ovldbreak.exp
@@ -58,6 +58,10 @@  proc take_gdb_out_of_choice_menu {} {
     gdb_test_multiple " " " " {
         -re ".*$gdb_prompt $" {
         }
+	timeout {
+	    perror "could not resynchronize to command prompt (timeout)"
+	    continue
+	}
     }
 }