Patchwork [3/3] gnu: python-flask: Update to 0.11.1.

login
register
mail settings
Submitter Danny Milosavljevic
Date Nov. 26, 2016, 1:51 p.m.
Message ID <20161126135122.3906-4-dannym@scratchpost.org>
Download mbox | patch
Permalink /patch/17951/
State New
Headers show

Comments

Danny Milosavljevic - Nov. 26, 2016, 1:51 p.m.
* gnu/packages/python.scm (python-flask): Update to 0.11.1.
[native-inputs]: Add python-click.
---
 gnu/packages/python.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Leo Famulari - Nov. 27, 2016, 5:27 a.m.
On Sat, Nov 26, 2016 at 02:51:22PM +0100, Danny Milosavljevic wrote:
> * gnu/packages/python.scm (python-flask): Update to 0.11.1.
> [native-inputs]: Add python-click.

python2-flask can't find click:

starting phase `check'
running "python setup.py" with command "test" and parameters ()
running test
Searching for click>=2.0
Reading https://pypi.python.org/simple/click/
Download error on https://pypi.python.org/simple/click/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'click' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.python.org/simple/
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or download links found for click>=2.0
error: Could not find suitable distribution for Requirement.parse('click>=2.0')
phase `check' failed after 0.2 seconds
builder for `/gnu/store/mrm59ipqv4kknmq1n2bm0dxfjcbggs08-python2-flask-0.11.1.drv' failed with exit code 1
Marius Bakke - Nov. 27, 2016, 12:25 p.m.
Leo Famulari <leo@famulari.name> writes:

> On Sat, Nov 26, 2016 at 02:51:22PM +0100, Danny Milosavljevic wrote:
>> * gnu/packages/python.scm (python-flask): Update to 0.11.1.
>> [native-inputs]: Add python-click.
>
> python2-flask can't find click:
>
> starting phase `check'
> running "python setup.py" with command "test" and parameters ()
> running test
> Searching for click>=2.0
> Reading https://pypi.python.org/simple/click/
> Download error on https://pypi.python.org/simple/click/: [Errno -2] Name or service not known -- Some packages may not be found!
> Couldn't find index page for 'click' (maybe misspelled?)
> Scanning index of all packages (this may take a while)
> Reading https://pypi.python.org/simple/
> Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
> No local packages or download links found for click>=2.0
> error: Could not find suitable distribution for Requirement.parse('click>=2.0')
> phase `check' failed after 0.2 seconds
> builder for `/gnu/store/mrm59ipqv4kknmq1n2bm0dxfjcbggs08-python2-flask-0.11.1.drv' failed with exit code 1

I picked Dannys latest commit which fixed this.

However it does seem to skip the tests entirely:

starting phase `check'
running "python setup.py" with command "test" and parameters ()
running test
phase `check' succeeded after 0.1 seconds
Leo Famulari - Nov. 27, 2016, 3:24 p.m.
On Sun, Nov 27, 2016 at 01:25:25PM +0100, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> > error: Could not find suitable distribution for Requirement.parse('click>=2.0')
> > phase `check' failed after 0.2 seconds
> > builder for `/gnu/store/mrm59ipqv4kknmq1n2bm0dxfjcbggs08-python2-flask-0.11.1.drv' failed with exit code 1
> 
> I picked Dannys latest commit which fixed this.

Thanks!

> However it does seem to skip the tests entirely:
> 
> starting phase `check'
> running "python setup.py" with command "test" and parameters ()
> running test
> phase `check' succeeded after 0.1 seconds

I guess it must be doing *something* if it was looking for click and
failing previously.

But, I think this is similar to the issue whereby many test suites were
silently skipped with Python 3.4. We could try invoking them manually.
At least, it looks the same in the build log.

Patch

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index ad27934..497da52 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9558,18 +9558,20 @@  useful for solving the Assignment Problem.")
 (define-public python-flask
   (package
     (name "python-flask")
-    (version "0.10.1")
+    (version "0.11.1")
     (source (origin
               (method url-fetch)
               (uri (pypi-uri "Flask" version))
               (sha256
                (base32
-                "0wrkavjdjndknhp8ya8j850jq7a1cli4g5a93mg8nh1xz2gq50sc"))))
+                "03kbfll4sj3v5z7r31c7bhfpi11r1np076d4p1k2kg4yzcmkywdl"))))
     (build-system python-build-system)
     (propagated-inputs
      `(("python-itsdangerous" ,python-itsdangerous)
        ("python-jinja2" ,python-jinja2)
        ("python-werkzeug" ,python-werkzeug)))
+    (native-inputs
+     `(("python-click" ,python-click)))
     (home-page "https://github.com/mitsuhiko/flask/")
     (synopsis "Microframework based on Werkzeug, Jinja2 and good intentions")
     (description "Flask is a micro web framework based on the Werkzeug toolkit