Patchwork gnu: qemu: Install all required info files.

login
register
mail settings
Submitter Alex Kost
Date Nov. 23, 2016, 8:50 p.m.
Message ID <87eg21ly3p.fsf@gmail.com>
Download mbox | patch
Permalink /patch/17746/
State New
Headers show

Comments

Alex Kost - Nov. 23, 2016, 8:50 p.m.
The current info manual of QEMU "does not work": qemu package provides
"qemu-doc.info" but not "qemu-doc.info-1" and other "*.info-N" files.

I believe the attached patch should fix it, but I couldn't test it, as
when I tried to build qemu, it failed on the check phase.  I am confused
as qemu has recently been built successfully on hydra, and to be honest
I don't have a wish to investigate.  So if anyone would like to test if
this patch really fixes the info manual, please do it :-)
Chris Marusich - Nov. 24, 2016, 8:50 a.m.
Alex Kost <alezost@gmail.com> writes:

> The current info manual of QEMU "does not work": qemu package provides
> "qemu-doc.info" but not "qemu-doc.info-1" and other "*.info-N" files.
>
> I believe the attached patch should fix it, but I couldn't test it, as
> when I tried to build qemu, it failed on the check phase.  I am confused
> as qemu has recently been built successfully on hydra, and to be honest
> I don't have a wish to investigate.  So if anyone would like to test if
> this patch really fixes the info manual, please do it :-)

This patch works for me.  I built qemu successfully using it.  The info
docs are present now, and they were missing before.  I'd say ship it!
Ludovic Court├Ęs - Nov. 24, 2016, 4:11 p.m.
Chris Marusich <cmmarusich@gmail.com> skribis:

> Alex Kost <alezost@gmail.com> writes:
>
>> The current info manual of QEMU "does not work": qemu package provides
>> "qemu-doc.info" but not "qemu-doc.info-1" and other "*.info-N" files.
>>
>> I believe the attached patch should fix it, but I couldn't test it, as
>> when I tried to build qemu, it failed on the check phase.  I am confused
>> as qemu has recently been built successfully on hydra, and to be honest
>> I don't have a wish to investigate.  So if anyone would like to test if
>> this patch really fixes the info manual, please do it :-)
>
> This patch works for me.  I built qemu successfully using it.  The info
> docs are present now, and they were missing before.  I'd say ship it!

+1!

Ludo'.
Alex Kost - Nov. 25, 2016, 1:12 p.m.
> Chris Marusich <cmmarusich@gmail.com> skribis:
>
>> Alex Kost <alezost@gmail.com> writes:
>>
>>> The current info manual of QEMU "does not work": qemu package provides
>>> "qemu-doc.info" but not "qemu-doc.info-1" and other "*.info-N" files.
>>>
>>> I believe the attached patch should fix it, but I couldn't test it, as
>>> when I tried to build qemu, it failed on the check phase.  I am confused
>>> as qemu has recently been built successfully on hydra, and to be honest
>>> I don't have a wish to investigate.  So if anyone would like to test if
>>> this patch really fixes the info manual, please do it :-)
>>
>> This patch works for me.  I built qemu successfully using it.  The info
>> docs are present now, and they were missing before.  I'd say ship it!

Thanks for checking!  Pushed.  (I guessed it should work, it's just that
my computer is not powerful enough to build some packages.)

Patch

From 86851ad63ddf8586507606508011753838b1e715 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Wed, 23 Nov 2016 23:25:27 +0300
Subject: [PATCH] gnu: qemu: Install all required info files.

* gnu/packages/qemu.scm (qemu)[arguments]: Adjust 'install-info' phase
to find all info files (including "*.info-N").
---
 gnu/packages/qemu.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/qemu.scm b/gnu/packages/qemu.scm
index 3c48b7a..e429c04 100644
--- a/gnu/packages/qemu.scm
+++ b/gnu/packages/qemu.scm
@@ -119,7 +119,7 @@ 
                         (let ((infodir (string-append out "/share/info")))
                           (for-each (lambda (info)
                                       (install-file info infodir))
-                                    (find-files "." "\\.info$"))
+                                    (find-files "." "\\.info"))
                           #t))))))
          (add-before 'check 'make-gtester-verbose
            (lambda _
-- 
2.10.2