Patchwork gnu: gnome-control-center: Add gdk-pixbuf input.

login
register
mail settings
Submitter rennes@openmailbox.org
Date Nov. 18, 2016, 6:01 a.m.
Message ID <3eecaa737fe8ccd7cc040cd7c59e73c3@openmailbox.org>
Download mbox | patch
Permalink /patch/17559/
State New
Headers show

Comments

rennes@openmailbox.org - Nov. 18, 2016, 6:01 a.m.
Hello,
this patch allow to gnome-control-center to load images in SVG format.
E.G. GNOME logo and Mouse & Touchpad settings image.

Thanks
Danny Milosavljevic - Nov. 18, 2016, 8:10 a.m.
Hi,

On Fri, 18 Nov 2016 00:01:40 -0600
rennes@openmailbox.org wrote:

> this patch allow to gnome-control-center to load images in SVG format.
> E.G. GNOME logo and Mouse & Touchpad settings image.

>+       ("gdk-pixbuf" ,gdk-pixbuf) ; for load files with SVG extension.

; to load SVG files

or

; for loading SVG files

.

Gdk-pixbuf doesn't care whether they have a "SVG" filename extension or not (if you meant that).
Leo Famulari - Nov. 18, 2016, 8:19 p.m.
On Fri, Nov 18, 2016 at 12:01:40AM -0600, rennes@openmailbox.org wrote:
> Hello,
> this patch allow to gnome-control-center to load images in SVG format.
> E.G. GNOME logo and Mouse & Touchpad settings image.
> 
> Thanks

> From 6aa42f1298bbd7b1582fb6894f9ebd1029b203a8 Mon Sep 17 00:00:00 2001
> From: Rene Saavedra <rennes@openmailbox.org>
> Date: Thu, 17 Nov 2016 23:48:11 -0600
> Subject: [PATCH] gnu: gnome-control-center: Add gdk-pixbuf input.
> 
> * gnu/packages/gnome.scm (gnome-control-center): Add gdk-pixbuf input.

I'm not a GNOME user. The issue is that the control center has missing
icons / logos because they are SVG files? I'm just trying to understand
the reason for the change.
rennes@openmailbox.org - Nov. 19, 2016, 3:10 a.m.
Hello Leo, Danny.

On 2016-11-18 14:19, Leo Famulari wrote:
> 
> I'm not a GNOME user. The issue is that the control center has missing
> icons / logos because they are SVG files? I'm just trying to understand
> the reason for the change.

To find the issue with some pictures in control center, I debugging:

$ gnome-control-center -v
(gnome-control-center:4956): Gtk-WARNING **: Could not load a pixbuf 
from /org/gtk/libgtk/theme/Adwaita/assets/bullet-symbolic.svg.
This may indicate that pixbuf loaders or the mime database could not be 
found.

After adding gdk-pixbuf to input, the pictures are displayed.
I attach pictures.

Thank you
Leo Famulari - Nov. 19, 2016, 3:38 p.m.
On Fri, Nov 18, 2016 at 09:10:11PM -0600, rennes@openmailbox.org wrote:
> Hello Leo, Danny.
> 
> On 2016-11-18 14:19, Leo Famulari wrote:
> > 
> > I'm not a GNOME user. The issue is that the control center has missing
> > icons / logos because they are SVG files? I'm just trying to understand
> > the reason for the change.
> 
> To find the issue with some pictures in control center, I debugging:
> 
> $ gnome-control-center -v
> (gnome-control-center:4956): Gtk-WARNING **: Could not load a pixbuf from
> /org/gtk/libgtk/theme/Adwaita/assets/bullet-symbolic.svg.
> This may indicate that pixbuf loaders or the mime database could not be
> found.
> 
> After adding gdk-pixbuf to input, the pictures are displayed.
> I attach pictures.

Thanks for explaining! Pushed as 3446ffb57c229

Patch

From 6aa42f1298bbd7b1582fb6894f9ebd1029b203a8 Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Thu, 17 Nov 2016 23:48:11 -0600
Subject: [PATCH] gnu: gnome-control-center: Add gdk-pixbuf input.

* gnu/packages/gnome.scm (gnome-control-center): Add gdk-pixbuf input.
---
 gnu/packages/gnome.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 8c422c5..b7e6d4d 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -4747,6 +4747,7 @@  devices using the GNOME desktop.")
        ("cups" ,cups)
        ("dconf" ,dconf)
        ("docbook-xsl" ,docbook-xsl)
+       ("gdk-pixbuf" ,gdk-pixbuf) ; for load files with SVG extension.
        ("gnome-bluetooth" ,gnome-bluetooth)
        ("gnome-desktop" ,gnome-desktop)
        ("gnome-online-accounts" ,gnome-online-accounts)
-- 
2.10.1