Patchwork gnu: mpop: Update to 1.2.6.

login
register
mail settings
Submitter Arun
Date Nov. 17, 2016, 11:43 a.m.
Message ID <cu7oa1enxfl.fsf@systemreboot.net>
Download mbox | patch
Permalink /patch/17542/
State New
Headers show

Comments

Arun - Nov. 17, 2016, 11:43 a.m.
Please find attached patch to update mpop from 1.2.5 to 1.2.6.

Thanks,
Arun
Marius Bakke - Nov. 17, 2016, 4:46 p.m.
Arun Isaac <arunisaac@systemreboot.net> writes:

> Please find attached patch to update mpop from 1.2.5 to 1.2.6.

Thanks for this. I'm unable to download the new version with
`./pre-inst-env guix build mpop`; however downloading manually with
`guix download` works fine and returns the hash, so I pushed the patch.

Here is the output from `./pre-inst-env guix build`, it appears to give
up after the redirect to HTTPS from sourceforge.

@ build-started /gnu/store/10wpp69fc0v7dk0mqk3075cy9d7iwwmh-mpop-1.2.6.tar.xz.drv - x86_64-linux /var/log/guix/drvs/10//wpp69fc0v7dk0mqk3075cy9d7iwwmh-mpop-1.2.6.tar.xz.drv.bz2

Starting download of /gnu/store/nxf0mgh6dynniy99gsxhff9xr217s1rl-mpop-1.2.6.tar.xz
From http://downloads.sourceforge.net/mpop/mpop-1.2.6.tar.xz...
following redirection to `http://downloads.sourceforge.net/project/mpop/mpop/1.2.6/mpop-1.2.6.tar.xz'...
following redirection to `https://netcologne.dl.sourceforge.net/project/mpop/mpop/1.2.6/mpop-1.2.6.tar.xz'...
;;; Failed to autoload make-session in (gnutls):
;;; ERROR: missing interface for module (gnutls)
ERROR: In procedure module-lookup: Unbound variable: make-session

Starting download of /gnu/store/nxf0mgh6dynniy99gsxhff9xr217s1rl-mpop-1.2.6.tar.xz
From http://mirror.hydra.gnu.org/file/mpop-1.2.6.tar.xz/sha256/0p1ix63jh64dibrlccch8q7gxl9nn18wd2qpyr5z1h4gs2fpmv4z...
[...]
Arun - Nov. 17, 2016, 7:46 p.m.
Marius Bakke writes:

> Thanks for this. I'm unable to download the new version with
> `./pre-inst-env guix build mpop`;

Not sure what the problem is. I was able to build mpop successfully on
my system. But, I did download manually with `guix download'
first. Perhaps the build used that downloaded source tarball.

> however downloading manually with
> `guix download` works fine and returns the hash, so I pushed the patch.

Thank you.
Marius Bakke - Nov. 17, 2016, 8:46 p.m.
Arun Isaac <arunisaac@systemreboot.net> writes:

> Marius Bakke writes:
>
>> Thanks for this. I'm unable to download the new version with
>> `./pre-inst-env guix build mpop`;
>
> Not sure what the problem is. I was able to build mpop successfully on
> my system. But, I did download manually with `guix download'
> first. Perhaps the build used that downloaded source tarball.

Yes, if the hash already exists in the store, it will be used instead of
downloading.  This has caused some confusion before :-)
Leo Famulari - Nov. 17, 2016, 9:09 p.m.
On Thu, Nov 17, 2016 at 09:46:38PM +0100, Marius Bakke wrote:
> Arun Isaac <arunisaac@systemreboot.net> writes:
> > Marius Bakke writes:
> >
> >> Thanks for this. I'm unable to download the new version with
> >> `./pre-inst-env guix build mpop`;
> >
> > Not sure what the problem is. I was able to build mpop successfully on
> > my system. But, I did download manually with `guix download'
> > first. Perhaps the build used that downloaded source tarball.

I fixed the URL and made it use our SourceForge mirror in commit
5837e6993.

> Yes, if the hash already exists in the store, it will be used instead of
> downloading.  This has caused some confusion before :-)

As Marius hints at, using `guix download` to get source code while
writing a package masks errors in the package's URL. You should always
download the source code "out of band" with wget, curl, a web browser,
etc, and then use `guix hash` to calculate the hash.

That way, you can be sure the package works.

Also, you don't leak information (via `guix download`'s network
signature) to potentially hostile servers that you are packaging
software for Guix.
Arun - Nov. 19, 2016, 2:24 a.m.
> I fixed the URL and made it use our SourceForge mirror in commit
> 5837e6993.

Thanks.

>> Yes, if the hash already exists in the store, it will be used instead of
>> downloading.  This has caused some confusion before :-)
>
> As Marius hints at, using `guix download` to get source code while
> writing a package masks errors in the package's URL. You should always
> download the source code "out of band" with wget, curl, a web browser,
> etc, and then use `guix hash` to calculate the hash.

Sure, will do from next time...!

Patch

From 5cb8a651b9eb97b8f6db36bb479140d6ed5692c1 Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Thu, 17 Nov 2016 13:34:42 +0530
Subject: [PATCH] gnu: mpop: Update to 1.2.6.

* gnu/packages/mail.scm (mpop): Update to 1.2.6.
---
 gnu/packages/mail.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 5d304d5..c294e20 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -1471,7 +1471,7 @@  converts them to maildir format directories.")
 (define-public mpop
   (package
     (name "mpop")
-    (version "1.2.5")
+    (version "1.2.6")
     (source
      (origin
        (method url-fetch)
@@ -1479,7 +1479,7 @@  converts them to maildir format directories.")
                            version ".tar.xz"))
        (sha256
         (base32
-         "0n0ij258kn8lfa6nyr6l6plc4hf1wvyf1hkwicvdbjqdqrgjnq81"))))
+         "0p1ix63jh64dibrlccch8q7gxl9nn18wd2qpyr5z1h4gs2fpmv4z"))))
     (build-system gnu-build-system)
     (inputs
      `(("gnutls" ,gnutls)
-- 
2.10.2