Patchwork gnu: fftw: Build threads library.

login
register
mail settings
Submitter Ricardo Wurmus
Date Nov. 14, 2016, 10:43 p.m.
Message ID <20161114224342.11644-2-rekado@elephly.net>
Download mbox | patch
Permalink /patch/17481/
State New
Headers show

Comments

Ricardo Wurmus - Nov. 14, 2016, 10:43 p.m.
* gnu/packages/algebra.scm (fftw)[arguments]: Add "--enable-threads" to
configure flags.
---
 gnu/packages/algebra.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Ludovic Courtès - Nov. 15, 2016, 10:13 a.m.
Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/algebra.scm (fftw)[arguments]: Add "--enable-threads" to
> configure flags.
> ---
>  gnu/packages/algebra.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
> index 8e9695d..e212775 100644
> --- a/gnu/packages/algebra.scm
> +++ b/gnu/packages/algebra.scm
> @@ -544,7 +544,8 @@ a C program.")
>                 "1kwbx92ps0r7s2mqy7lxbxanslxdzj7dp7r7gmdkzv1j8yqf3kwf"))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(#:configure-flags '("--enable-shared" "--enable-openmp")
> +     '(#:configure-flags
> +       '("--enable-shared" "--enable-openmp" "--enable-threads")
>         #:phases (alist-cons-before
>                   'build 'no-native
>                   (lambda _

LGTM!

Per
<https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html>,
this is a perfect candidate for ‘staging’.

(In the meantime, if that helps, you could additionally create an FFTW
variant for use by Ardour, in master.)

Ludo’.
Ricardo Wurmus - Nov. 15, 2016, 8:36 p.m.
Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> * gnu/packages/algebra.scm (fftw)[arguments]: Add "--enable-threads" to
>> configure flags.
>> ---
>>  gnu/packages/algebra.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
>> index 8e9695d..e212775 100644
>> --- a/gnu/packages/algebra.scm
>> +++ b/gnu/packages/algebra.scm
>> @@ -544,7 +544,8 @@ a C program.")
>>                 "1kwbx92ps0r7s2mqy7lxbxanslxdzj7dp7r7gmdkzv1j8yqf3kwf"))))
>>      (build-system gnu-build-system)
>>      (arguments
>> -     '(#:configure-flags '("--enable-shared" "--enable-openmp")
>> +     '(#:configure-flags
>> +       '("--enable-shared" "--enable-openmp" "--enable-threads")
>>         #:phases (alist-cons-before
>>                   'build 'no-native
>>                   (lambda _
>
> LGTM!
>
> Per
> <https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html>,
> this is a perfect candidate for ‘staging’.

Thanks for the reference.  We don’t have a staging branch yet, as far as
I can tell.  May I just push this commit to a new “staging” branch then?

> (In the meantime, if that helps, you could additionally create an FFTW
> variant for use by Ardour, in master.)

Yes, I’ll do that.

~~ Ricardo
Ludovic Courtès - Nov. 16, 2016, 9:23 p.m.
Ricardo Wurmus <rekado@elephly.net> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Ricardo Wurmus <rekado@elephly.net> skribis:
>>
>>> * gnu/packages/algebra.scm (fftw)[arguments]: Add "--enable-threads" to
>>> configure flags.
>>> ---
>>>  gnu/packages/algebra.scm | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
>>> index 8e9695d..e212775 100644
>>> --- a/gnu/packages/algebra.scm
>>> +++ b/gnu/packages/algebra.scm
>>> @@ -544,7 +544,8 @@ a C program.")
>>>                 "1kwbx92ps0r7s2mqy7lxbxanslxdzj7dp7r7gmdkzv1j8yqf3kwf"))))
>>>      (build-system gnu-build-system)
>>>      (arguments
>>> -     '(#:configure-flags '("--enable-shared" "--enable-openmp")
>>> +     '(#:configure-flags
>>> +       '("--enable-shared" "--enable-openmp" "--enable-threads")
>>>         #:phases (alist-cons-before
>>>                   'build 'no-native
>>>                   (lambda _
>>
>> LGTM!
>>
>> Per
>> <https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html>,
>> this is a perfect candidate for ‘staging’.
>
> Thanks for the reference.  We don’t have a staging branch yet, as far as
> I can tell.  May I just push this commit to a new “staging” branch then?

Yep!  So the idea would be to freeze it in ~2 weeks (Nov. 30) and to
merge it in 3 weeks (Dec. 7).  Let’s see if we can be disciplined.  :-)

Ludo’.

Patch

diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
index 8e9695d..e212775 100644
--- a/gnu/packages/algebra.scm
+++ b/gnu/packages/algebra.scm
@@ -544,7 +544,8 @@  a C program.")
                "1kwbx92ps0r7s2mqy7lxbxanslxdzj7dp7r7gmdkzv1j8yqf3kwf"))))
     (build-system gnu-build-system)
     (arguments
-     '(#:configure-flags '("--enable-shared" "--enable-openmp")
+     '(#:configure-flags
+       '("--enable-shared" "--enable-openmp" "--enable-threads")
        #:phases (alist-cons-before
                  'build 'no-native
                  (lambda _