Patchwork [07/68] gnu: bluez-qt: Update to 5.27.0.

login
register
mail settings
Submitter David Craven
Date Oct. 29, 2016, 6:04 p.m.
Message ID <20161029180519.6061-7-david@craven.ch>
Download mbox | patch
Permalink /patch/16949/
State New
Headers show

Comments

David Craven - Oct. 29, 2016, 6:04 p.m.
* gnu/packages/kde-frameworks.scm (bluez-qt): Update to 5.27.0 and
  fix indentation.
---
 gnu/packages/kde-frameworks.scm | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)
Leo Famulari - Oct. 29, 2016, 8:33 p.m.
On Sat, Oct 29, 2016 at 08:04:18PM +0200, David Craven wrote:
> * gnu/packages/kde-frameworks.scm (bluez-qt): Update to 5.27.0 and
>   fix indentation.

In general, when making many changes that have no effect (for example,
several dozen indentation fixes), I think they should be done
separately.

A purely cosmetic commit can be easily audited by rebuilding the package
after the commit. If only indentation was changed, no rebuild will be
required.

By combining the "real" and cosmetic changes, the burden on reviewers is
increased significantly. Now, we have to manually compare the
re-indented code to verify that nothing changed.

Something to keep in mind in the future...
Leo Famulari - Oct. 29, 2016, 8:42 p.m.
On Sat, Oct 29, 2016 at 08:04:18PM +0200, David Craven wrote:
> * gnu/packages/kde-frameworks.scm (bluez-qt): Update to 5.27.0 and
>   fix indentation.
> ---
>  gnu/packages/kde-frameworks.scm | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 653e8fb..ba22f89 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -216,16 +216,16 @@ http://freedesktop.org/wiki/Specifications/open-collaboration-services/")
>  (define-public bluez-qt
>    (package
>      (name "bluez-qt")
> -    (version "5.24.0")
> -    (source
> -      (origin
> -        (method url-fetch)
> -        (uri (string-append "mirror://kde/stable/frameworks/"
> -                            (version-major+minor version) "/"
> -                            name "-" version ".tar.xz"))

Could this mirror URL be factored into something like
"kde-frameworks-uri" (in a later set of patches)?

Patch

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 653e8fb..ba22f89 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -216,16 +216,16 @@  http://freedesktop.org/wiki/Specifications/open-collaboration-services/")
 (define-public bluez-qt
   (package
     (name "bluez-qt")
-    (version "5.24.0")
-    (source
-      (origin
-        (method url-fetch)
-        (uri (string-append "mirror://kde/stable/frameworks/"
-                            (version-major+minor version) "/"
-                            name "-" version ".tar.xz"))
-        (sha256
-         (base32
-          "0gy0m7lcwwklf021l5i3v7j0cl7qz7cgvzrwpj87ix3kyw5xs80z"))))
+    (version "5.27.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://kde/stable/frameworks/"
+                    (version-major+minor version) "/"
+                    name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "111gqxw1bvazdhxk5rcfhi438i6bd92r3wvlkxsdqrp7ypcqdpig"))))
     (build-system cmake-build-system)
     (native-inputs
      `(("dbus" ,dbus)
@@ -234,13 +234,13 @@  http://freedesktop.org/wiki/Specifications/open-collaboration-services/")
      `(("qtbase" ,qtbase)))
     (arguments
      `(#:configure-flags
-        '("-DINSTALL_UDEV_RULE:BOOL=OFF")
+       '("-DINSTALL_UDEV_RULE:BOOL=OFF")
        #:phases
-        (modify-phases %standard-phases
-          (replace 'check
-            (lambda* _
-              (setenv "DBUS_FATAL_WARNINGS" "0")
-              (zero? (system* "dbus-launch" "ctest" ".")))))))
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (setenv "DBUS_FATAL_WARNINGS" "0")
+             (zero? (system* "dbus-launch" "ctest" ".")))))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "QML wrapper for BlueZ")
     (description "bluez-qt is a Qt-style library for accessing the bluez